From 842106d9d89b9fa8505be708a8b813a8eff40103 Mon Sep 17 00:00:00 2001 From: thomaslantern Date: Wed, 20 Apr 2022 22:53:53 -0400 Subject: [PATCH] removed m.room.message.feedback --- .../modules/instant_messaging.md | 11 -------- .../examples/m.room.message.feedback.yaml | 8 ------ .../schema/m.room.message.feedback.yaml | 26 ------------------- 3 files changed, 45 deletions(-) delete mode 100644 data/event-schemas/examples/m.room.message.feedback.yaml delete mode 100644 data/event-schemas/schema/m.room.message.feedback.yaml diff --git a/content/client-server-api/modules/instant_messaging.md b/content/client-server-api/modules/instant_messaging.md index 3ca5668d..f7f4d8ca 100644 --- a/content/client-server-api/modules/instant_messaging.md +++ b/content/client-server-api/modules/instant_messaging.md @@ -12,17 +12,6 @@ room itself such as a room name and topic. {{% event event="m.room.message" %}} -{{% event event="m.room.message.feedback" %}} - -Usage of this event is discouraged for several reasons: -- The number of feedback events will grow very quickly with the number - of users in the room. This event provides no way to "batch" - feedback, unlike the [receipts module](#receipts). -- Pairing feedback to messages gets complicated when paginating as - feedback arrives before the message it is acknowledging. -- There are no guarantees that the client has seen the event ID being - acknowledged. - {{% event event="m.room.name" %}} {{% event event="m.room.topic" %}} diff --git a/data/event-schemas/examples/m.room.message.feedback.yaml b/data/event-schemas/examples/m.room.message.feedback.yaml deleted file mode 100644 index e146e874..00000000 --- a/data/event-schemas/examples/m.room.message.feedback.yaml +++ /dev/null @@ -1,8 +0,0 @@ -{ - "$ref": "core/room_event.json", - "type": "m.room.message.feedback", - "content": { - "type": "delivered", - "target_event_id": "$WEIGFHFW:localhost" - } -} diff --git a/data/event-schemas/schema/m.room.message.feedback.yaml b/data/event-schemas/schema/m.room.message.feedback.yaml deleted file mode 100644 index fbb39c0a..00000000 --- a/data/event-schemas/schema/m.room.message.feedback.yaml +++ /dev/null @@ -1,26 +0,0 @@ ---- -allOf: - - $ref: core-event-schema/room_event.yaml -description: '**NB: Usage of this event is discouraged in favour of the** [receipts module](/client-server-api/#receipts). **Most clients will not recognise this event.** Feedback events are events sent to acknowledge a message in some way. There are two supported acknowledgements: `delivered` (sent when the event has been received) and `read` (sent when the event has been observed by the end-user). The `target_event_id` should reference the `m.room.message` event being acknowledged.' -properties: - content: - properties: - target_event_id: - description: The event that this feedback is related to. - type: string - type: - description: The type of feedback. - enum: - - delivered - - read - type: string - required: - - type - - target_event_id - type: object - type: - enum: - - m.room.message.feedback - type: string -title: MessageFeedback -type: object