From 67743d5715071afa4a2b8553321dccf5339a330d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Commaille?= <76261501+zecakeh@users.noreply.github.com> Date: Tue, 13 May 2025 17:09:18 +0200 Subject: [PATCH] Fix generation of historical spec (#2123) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit With the move of the config file, the command in CI did not work as expected anymore. I am unsure why Hugo actually ignored the missing config file in the command… To avoid this problem in the future and simplify the job, we use the default config and add an environment variable for the status which will always take precedence over the config. Signed-off-by: Kévin Commaille --- .github/workflows/main.yml | 5 +++-- changelogs/internal/newsfragments/2123.clarification | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 changelogs/internal/newsfragments/2123.clarification diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index daa8fb67..446aca9c 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -284,10 +284,11 @@ jobs: npm i npm run get-proposals - name: "⚙️ hugo" + env: + HUGO_PARAMS_VERSION_STATUS: "historical" # Create a baseURL like `/v1.2` out of the `v1.2` tag run: | - echo -e '[params.version]\nstatus="historical"' > historical.toml - hugo --config config.toml,historical.toml --baseURL "/${GITHUB_REF/refs\/tags\//}" -d "spec" + hugo --baseURL "/${GITHUB_REF/refs\/tags\//}" -d "spec" - name: "📥 Spec definition download" uses: actions/download-artifact@v4 diff --git a/changelogs/internal/newsfragments/2123.clarification b/changelogs/internal/newsfragments/2123.clarification new file mode 100644 index 00000000..af26abaf --- /dev/null +++ b/changelogs/internal/newsfragments/2123.clarification @@ -0,0 +1 @@ +Fix the historical info box when generating the historical spec in CI.