From 2c3d7b168212893ecd38c0ccf984098fba3599bd Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Mon, 3 May 2021 19:33:15 -0600 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Hubert Chathi --- content/client-server-api/modules/sso_login.md | 2 +- data/api/client-server/definitions/sso_login_flow.yaml | 4 ++-- informal/idp-brands.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/content/client-server-api/modules/sso_login.md b/content/client-server-api/modules/sso_login.md index fe3f5322..2bc3916b 100644 --- a/content/client-server-api/modules/sso_login.md +++ b/content/client-server-api/modules/sso_login.md @@ -40,7 +40,7 @@ administrator to configure where the CAS server is and the REST endpoints which consume the ticket. Homeservers may optionally expose multiple possible SSO options for -the user to pursue, typically in the form of several "login with $provider" +the user to pursue, typically in the form of several "log in with $provider" buttons. These are known as "identity providers" (IdPs). #### Client login via SSO diff --git a/data/api/client-server/definitions/sso_login_flow.yaml b/data/api/client-server/definitions/sso_login_flow.yaml index 6aa03282..0dd011b3 100644 --- a/data/api/client-server/definitions/sso_login_flow.yaml +++ b/data/api/client-server/definitions/sso_login_flow.yaml @@ -27,8 +27,8 @@ properties: and would map to the appropriate IdP-dependent redirect endpoint for that IdP. example: [ - {"id": "com.example.idp.github", "name": "Github", "brand": "github"}, - {"id": "com.example.idp.gitlab", "name": "Gitlab", "icon": "mxc://example.com/abc123"}, + {"id": "com.example.idp.github", "name": "GitHub", "brand": "github"}, + {"id": "com.example.idp.gitlab", "name": "GitLab", "icon": "mxc://example.com/abc123"}, ] items: type: object diff --git a/informal/idp-brands.md b/informal/idp-brands.md index 1dbf0c8d..24f91811 100644 --- a/informal/idp-brands.md +++ b/informal/idp-brands.md @@ -46,7 +46,7 @@ Suitable for "Sign in with Apple": see https://developer.apple.com/design/human- Logos available at https://github.com/logos. -### Gitlab +### GitLab **Identifier**: `gitlab`