From 083e6ef25da712eecc1b56a8e3a2fafaf48d130d Mon Sep 17 00:00:00 2001
From: Michael Telatynski <7t3chguy@gmail.com>
Date: Fri, 22 Mar 2024 18:27:42 +0000
Subject: [PATCH] Fix npm publishing being broken in CI (#1765)

* Fix `v` tag_name prefix sneaking into npm version

* Fix `yarn version` failing in CI due to no git global ident name

* Add changelog

* Rename 1765.misc to 1765.clarification
---
 .github/workflows/release.yaml                       | 3 ++-
 changelogs/internal/newsfragments/1765.clarification | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
 create mode 100644 changelogs/internal/newsfragments/1765.clarification

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
index 05e5be7a..6f8d1353 100644
--- a/.github/workflows/release.yaml
+++ b/.github/workflows/release.yaml
@@ -26,8 +26,9 @@ jobs:
       - name: 🔨 Install dependencies
         run: "yarn install --frozen-lockfile"
 
+      # We bump the package.json version to git, we just need it for publish to do the right thing
       - name: 🎖 Bump package.json version
-        run: "yarn version --new-version $VERSION"
+        run: "yarn version --new-version ${VERSION#v} --no-git-tag-version"
         env:
           VERSION: ${{ github.event.release.tag_name }}.0
 
diff --git a/changelogs/internal/newsfragments/1765.clarification b/changelogs/internal/newsfragments/1765.clarification
new file mode 100644
index 00000000..c1b999bf
--- /dev/null
+++ b/changelogs/internal/newsfragments/1765.clarification
@@ -0,0 +1 @@
+Fix npm release script for `@matrix-org/spec`.