Commit Graph

77 Commits (main)

Author SHA1 Message Date
kegsay 94de0bde0f
Clarify that invite->knock is not legal. (#4091)
Reverts https://github.com/matrix-org/matrix-spec-proposals/pull/3850
3 months ago
Travis Ralston dbc7937cd0
Clarify accidentally-legal `invite->knock` membership transition (#3850) 2 years ago
Travis Ralston fc3f7d60eb
Remove `aliases` from `/publicRooms` response (#3624)
Through attempting to land [Synapse#11667](https://github.com/matrix-org/synapse/pull/11667) it was found that Synapse doesn't return the `aliases` property on `/publicRooms` as it was [removed](https://github.com/matrix-org/synapse/pull/6970) by a [tracking issue](https://github.com/matrix-org/synapse/issues/6898) referencing [MSC2432](https://github.com/matrix-org/matrix-doc/pull/2432) as its base. Though MSC2432 does not make mention of this, the [document](https://docs.google.com/document/d/1NNDkobiFLeUkJtyj0H6qvKIedgvIkZnFKo78-03cGEk/edit) the MSC is based upon makes deliberate effort to mention the endpoint and the removal of `aliases`. Thus, it is determined as a likely accidental omission from the formal MSC and therefore the formal spec.

This has been corrected here by amending the MSC (per the process) and removing the field, basing itself off of the [spec PR for spaces](https://github.com/matrix-org/matrix-doc/pull/3610) for diff clarity.
2 years ago
Patrick Cloke cee03d7625 Use the same domain for room ID and avatar URL. 3 years ago
Andrew Morgan a8f4ada8a8 Make join_rules field of PublicRoomChunk an optional value 3 years ago
Andrew Morgan 9ebfd98a7a
Apply suggestions from code review
Co-authored-by: Alexey Rusakov <Kitsune-Ral@users.sf.net>
3 years ago
Andrew Morgan 10267df76e Add missing 403/404 response codes 3 years ago
Andrew Morgan 11996fb436 clarify some words 3 years ago
Andrew Morgan a1a40c6346 Be consistent about event auth rules 3 years ago
Andrew Morgan 7f0b2d66a0 Update unstable endpoints from i.e xyz.amorgan/knock -> xyz.amorgan.knock
I'm doing this for two reasons:

1) If I ever wanted to create another knock-related MSC, it would be nice to be able
to give it a different namespace for endpoints, such as xyz.amorgan.knock2/knock. If
we were only using xyz.amorgan as the namespace for endpoints, that restricts that
namespace to only work for one MSC which attempts to use /knock as part of an endpoint.

2) I accidentally made the implementation use xyz.amorgan.knock/knock :)
3 years ago
Andrew Morgan 68d2d7cfdb Note that homeservers should pass down invites to the client if they fail on autojoin 3 years ago
Andrew Morgan 8bfef19a39 Remove further traces of old /rooms/roomId/knock CS endpoint 3 years ago
Andrew Morgan ef840c1b53 Split the 'Membership change to ' section into rejecting/rescinding knocks 3 years ago
Andrew Morgan 6556b95233 Move API endpoint sections up to the top of the proposal 3 years ago
Andrew Morgan c915b6442b Update alternatives section 3 years ago
Andrew Morgan 09018be96c Link to existing spec documentation on the public rooms directory 3 years ago
Andrew Morgan 53ad7e3f66 Ensure we return the room_id after knocking via the CS API 3 years ago
Andrew Morgan c575f88d13 Move endpoint extras under endpoint's header 3 years ago
Andrew Morgan c9f34e818e Link to /join/roomIdOrAlias 3 years ago
Andrew Morgan 49a72862a9 Allow knock->knock transitions 3 years ago
Andrew Morgan e790ad2120
Apply suggestions from code review
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
3 years ago
Andrew Morgan 24f61c283c Note that implementations may choose to auto-accept knock-related invites 3 years ago
Andrew Morgan eda65847a3 Comment on push rules 3 years ago
Andrew Morgan 248a3da5ca Switch /send_knock/ from v2 to v1; leave a note as to why 3 years ago
Andrew Morgan 74f3b12a17 Note experimental room version ID 3 years ago
Andrew Morgan 04cd6b3d3e
fix typo
Co-authored-by: Hubert Chathi <hubert@uhoreg.ca>
3 years ago
Andrew Morgan 337c87b949 Add 404 on make_knock if unknown room ID 3 years ago
Andrew Morgan 8400877574 Make ver a required parameter for make_knock 3 years ago
Andrew Morgan d5a2a284c5 Note clients should try to prevent impersonation attacks during knocking 3 years ago
Andrew Morgan 5c620de273 typo fix 3 years ago
Andrew Morgan 6a0d07c799 Public rooms directory backwards compatibility note 3 years ago
Andrew Morgan 51a7778217 typo 3 years ago
Andrew Morgan e99649cb84 Foreshadow power level requirements for approval/denial of knock 3 years ago
Andrew Morgan 42e01b8e91 Add join_rules to room chunks returned on a public room dir query 3 years ago
Andrew Morgan 7dcff8f2e1 Disallow invite->knock membership changes 4 years ago
Andrew Morgan 6c75b83b99 Address Travis and Patrick's feedback 4 years ago
Andrew Morgan 815dae6eae Note that redactions of knocks are not a concern 4 years ago
Andrew Morgan a924f5b3d5 Fix incorrect assumptions about the sender field of a knock event
Got a bit confused with the sender and state_key being different in invite
membership events. In case of a knock, even if the knock event is being
inserted into the room by another homeserver over federation, the sender
of the event is still the knocking user, just like the state_key.
4 years ago
Andrew Morgan 525d1d33e0 Some clarifications and wording fixes 4 years ago
Andrew Morgan 6f7bcb6052 Explicitly state what changes to the auth rules are necessary 4 years ago
Andrew Morgan 5097fad4e7 Fix unstable prefix bullet points 4 years ago
Andrew Morgan 6b99228386 Remove section duplicated by membership change section 4 years ago
Andrew Morgan fd8176b93d Clarify endpoint calls clients and servers need to use to handle knocks 4 years ago
Andrew Morgan 9e5ac042ac Explicitly state that the hs that received the knock must put in the room 4 years ago
Andrew Morgan e58e207bbf Go into more depth about membership changes surrounding knocking 4 years ago
Andrew Morgan 340f888de3 Mention unstable prefixes for sync, join_rules and membership events 4 years ago
Andrew Morgan 6e47e86f01 Add unstable endpoint replacements 4 years ago
Andrew Morgan fd9d57b8c4 Match state events sent to a remote server when inviting a user 4 years ago
Andrew Morgan 630f7c458c Allow users to knock over and over, removing CS complexity 4 years ago
Andrew Morgan 61fea58ce0 Merge branch 'soru/knock' of github.com:sorunome/matrix-doc into soru/knock 4 years ago