From fffed943bcdfc3b016a5c03ce4fa66c35160220b Mon Sep 17 00:00:00 2001 From: Hubert Chathi Date: Tue, 5 May 2020 19:18:04 -0400 Subject: [PATCH 1/3] proposal to add endpoint to delete backups --- proposals/xxxx-add-delete-backup.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) create mode 100644 proposals/xxxx-add-delete-backup.md diff --git a/proposals/xxxx-add-delete-backup.md b/proposals/xxxx-add-delete-backup.md new file mode 100644 index 000000000..b84de399e --- /dev/null +++ b/proposals/xxxx-add-delete-backup.md @@ -0,0 +1,14 @@ +# Add ability to delete key backups + +[MSC1219](https://github.com/matrix-org/matrix-doc/issues/1219) defined a +mechanism for key backups. However, it inadvertently omitted the endpoint to +delete an entire key backup. This proposal adds the endpoint. + +## Proposal + +An endpoint is added, `DELETE /room_keys/version/{version}`, that deletes a +backup version. Both the information about the key backup, as well as all keys +associated with the backup should be deleted. Like `POST +/room_keys/version/{version}`, and unlike `GET /room_keys/version/{version}`, +`{version}` cannot be empty, to ensure that the wrong backup is not +accidentally deleted. From 0b39308a139276a3ed02297bac4e9a5f99032a3e Mon Sep 17 00:00:00 2001 From: Hubert Chathi Date: Tue, 5 May 2020 19:20:20 -0400 Subject: [PATCH 2/3] rename to use msc number --- .../{xxxx-add-delete-backup.md => 2526-add-delete-backup.md} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename proposals/{xxxx-add-delete-backup.md => 2526-add-delete-backup.md} (93%) diff --git a/proposals/xxxx-add-delete-backup.md b/proposals/2526-add-delete-backup.md similarity index 93% rename from proposals/xxxx-add-delete-backup.md rename to proposals/2526-add-delete-backup.md index b84de399e..e4d589e3c 100644 --- a/proposals/xxxx-add-delete-backup.md +++ b/proposals/2526-add-delete-backup.md @@ -1,4 +1,4 @@ -# Add ability to delete key backups +# MSC2526: Add ability to delete key backups [MSC1219](https://github.com/matrix-org/matrix-doc/issues/1219) defined a mechanism for key backups. However, it inadvertently omitted the endpoint to From bac9afa124b47ed722a74c00ef7c65d83308beb4 Mon Sep 17 00:00:00 2001 From: Hubert Chathi Date: Fri, 15 May 2020 12:14:46 -0400 Subject: [PATCH 3/3] document error codes and remove a statement that isn't true --- proposals/2526-add-delete-backup.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/proposals/2526-add-delete-backup.md b/proposals/2526-add-delete-backup.md index e4d589e3c..b41fe5a3b 100644 --- a/proposals/2526-add-delete-backup.md +++ b/proposals/2526-add-delete-backup.md @@ -8,7 +8,7 @@ delete an entire key backup. This proposal adds the endpoint. An endpoint is added, `DELETE /room_keys/version/{version}`, that deletes a backup version. Both the information about the key backup, as well as all keys -associated with the backup should be deleted. Like `POST -/room_keys/version/{version}`, and unlike `GET /room_keys/version/{version}`, -`{version}` cannot be empty, to ensure that the wrong backup is not -accidentally deleted. +associated with the backup should be deleted. If the specified version was +previously deleted, the endpoint succeeds, returning an HTTP code of 200. If +the specified version never existed, the endpoint returns an HTTP code of 404 +with a Matrix `errcode` of `M_NOT_FOUND`.