From e5fb2175a185ff982ec11a76512d53ee282a98ad Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Thu, 1 Jun 2023 15:02:57 -0600 Subject: [PATCH] More using of modern push rule practices --- proposals/3930-polls-notifications.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/proposals/3930-polls-notifications.md b/proposals/3930-polls-notifications.md index 2d74ffe5..c40fd10d 100644 --- a/proposals/3930-polls-notifications.md +++ b/proposals/3930-polls-notifications.md @@ -27,7 +27,7 @@ order presented by this MSC. {"kind": "room_member_count", "is": "2"}, // Note: `.` is escaped once, but for valid JSON we need to escape the escape. - {"kind": "event_property_is", "key": "type", "pattern": "m\\.poll\\.start"} + {"kind": "event_property_is", "key": "type", "value": "m\\.poll\\.start"} ], "actions": [ "notify", @@ -43,7 +43,7 @@ order presented by this MSC. "enabled": true, "conditions": [ // Note: `.` is escaped once, but for valid JSON we need to escape the escape. - {"kind": "event_property_is", "key": "type", "pattern": "m\\.poll\\.start"} + {"kind": "event_property_is", "key": "type", "value": "m\\.poll\\.start"} ], "actions": [ "notify" @@ -60,7 +60,7 @@ order presented by this MSC. {"kind": "room_member_count", "is": "2"}, // Note: `.` is escaped once, but for valid JSON we need to escape the escape. - {"kind": "event_property_is", "key": "type", "pattern": "m\\.poll\\.end"} + {"kind": "event_property_is", "key": "type", "value": "m\\.poll\\.end"} ], "actions": [ "notify", @@ -76,7 +76,7 @@ order presented by this MSC. "enabled": true, "conditions": [ // Note: `.` is escaped once, but for valid JSON we need to escape the escape. - {"kind": "event_property_is", "key": "type", "pattern": "m\\.poll\\.end"} + {"kind": "event_property_is", "key": "type", "value": "m\\.poll\\.end"} ], "actions": [ "notify" @@ -128,6 +128,9 @@ While the order within the MSC is deliberate for the new rules, the positioning already in the spec is fairly arbitrary. The new rules are placed at the end of each list (underride and override) for simplicity, but could realistically go anywhere in the list. +See ["Dot-separated property paths"](https://spec.matrix.org/v1.7/appendices/#dot-separated-property-paths) +for more information on why we escape the `event_property_is` condition values. + ## Security considerations None applicable - no new considerations need to be made with this proposal.