Merge pull request #1975 from matrix-org/rav/thumbnail_dimensions

Make thumbnail dimensions mandatory
5 years ago · de3eb3218e
parent dc09dcd64b 14715468bb
commit de3eb3218e
2 changed files with 3 additions and 0 deletions
--- a/api/client-server/content-repo.yaml
+++ b/api/client-server/content-repo.yaml
@ -202,6 +202,7 @@ paths:
          type: integer
          x-example: 64
          name: width
+          required: true
          description: |-
            The *desired* width of the thumbnail. The actual thumbnail may not
            match the size specified.
@ -209,6 +210,7 @@ paths:
          type: integer
          x-example: 64
          name: height
+          required: true
          description: |-
            The *desired* height of the thumbnail. The actual thumbnail may not
            match the size specified.
--- a/changelogs/client_server/newsfragments/1975.clarification
+++ b/changelogs/client_server/newsfragments/1975.clarification
@ -0,0 +1 @@
+Clarify that ``width`` and ``height`` are required parameters on ``/_matrix/media/r0/thumbnail/{serverName}/{mediaId}``. It is somewhat meaningless to request a thumbnail without specifying a desired size, and Synapse has never permitted such requests.
				`@ -0,0 +1 @@`
				Clarify that ``width`` and ``height`` are required parameters on ``/_matrix/media/r0/thumbnail/{serverName}/{mediaId}``. It is somewhat meaningless to request a thumbnail without specifying a desired size, and Synapse has never permitted such requests.