From 469d540756d3e5ae08ebed57ebaf68b3aa2f7671 Mon Sep 17 00:00:00 2001 From: Kerry Date: Mon, 21 Nov 2022 14:35:00 +1300 Subject: [PATCH 1/2] Update proposals/3881-remote-push-notification-toggling.md Co-authored-by: Travis Ralston --- proposals/3881-remote-push-notification-toggling.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proposals/3881-remote-push-notification-toggling.md b/proposals/3881-remote-push-notification-toggling.md index c2bf482d..7f3bb32d 100644 --- a/proposals/3881-remote-push-notification-toggling.md +++ b/proposals/3881-remote-push-notification-toggling.md @@ -43,7 +43,7 @@ A new optional field `device_id` is added to the `Pusher` model as returned from | `device_id` | string | **Optional** The device_id of the session that registered the pusher -To be able to remove Pushers when sessions are deleted some home servers have some existing way to link a session to +To be able to remove Pushers when sessions are deleted some homeservers have some existing way to link a session to pusher, so exposing the `device_id` on http pushers should be trivial. (Synapse, for instance, stores the [access token](https://github.com/matrix-org/synapse/blob/3d201151152ca8ba9b9aae8da5b76a26044cc85f/synapse/storage/databases/main/pusher.py#L487) when adding a pusher, which is usually associated with a device) From 8fc3851cd0b9d50fc6a64b16220afd77fe6fd174 Mon Sep 17 00:00:00 2001 From: Kerry Date: Mon, 21 Nov 2022 14:35:25 +1300 Subject: [PATCH 2/2] Update proposals/3881-remote-push-notification-toggling.md Co-authored-by: Travis Ralston --- proposals/3881-remote-push-notification-toggling.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/proposals/3881-remote-push-notification-toggling.md b/proposals/3881-remote-push-notification-toggling.md index 7f3bb32d..795451d9 100644 --- a/proposals/3881-remote-push-notification-toggling.md +++ b/proposals/3881-remote-push-notification-toggling.md @@ -61,7 +61,7 @@ MSC. Home servers should indicate their support of this MSC by adding `org.matrix.msc3881` and `org.matrix.msc3881.stable` in the response of `/_matrix/client/versions`. -Clients that connect to a home server that doesn't yet support this proposal should interpret a missing `enabled` value +Clients that connect to a homeserver that doesn't yet support this proposal should interpret a missing `enabled` value as `true`. Home servers should migrate pushers that were registered before this proposal so that `enabled` is `true`