mirror of https://github.com/ansible/ansible.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
edaeb69a35
Unified tmp accidentally removed the containing tmpdir from the list of files to fix the permissions on when we're becoming a different unprivileged user. This resulted in a visible bug for script but not for patch. This is because patch also uploads the module to the same temporary directory and the uploaded module also ends up calling fixup_perms2() which includes the temporary directory. So by the time patch needs to access the temporary patch file, the directory is appropriately set. script's breakage was visible because script does not upload a module (it's akin to raw in this way). Therefore, we only call fixup_perms2() once in script and so leaving out the tmpdir in script means that the containing directory never has its permissions set appropriately. Fixing both because it does not cause an extra round trip for patch so any speedup would be minimal and it's better to fix the perms as close as possible to where we know we need it. Otherwise, changes to seemingly unrelated code later could end up breaking it. Fixes #36398 |
8 years ago | |
|---|---|---|
| .. | ||
| cli | 8 years ago | |
| compat | 8 years ago | |
| config | 8 years ago | |
| errors | 8 years ago | |
| executor | 8 years ago | |
| galaxy | 8 years ago | |
| inventory | 8 years ago | |
| module_utils | 8 years ago | |
| modules | 8 years ago | |
| parsing | 8 years ago | |
| playbook | 8 years ago | |
| plugins | 8 years ago | |
| template | 8 years ago | |
| utils | 8 years ago | |
| vars | 8 years ago | |
| __init__.py | 10 years ago | |
| constants.py | 8 years ago | |
| release.py | 8 years ago | |