e96549c95d
Before this patch:
- Command was matched if 'Command' field of docker-py
representation of Docker container ends with 'command' passed
to Ansible docker module by user.
- That can give false positives and false negatives.
- For example:
a) If 'command' was set up with more than one spaces,
like 'command=sleep 123', it would be never matched again
with a container(s) launched by this task.
Because after launching, command would be normalized and
appear, in docker-py API call, just as 'sleep 123' - with one
space. This is false negative case.
b) If 'entrypoint + command = command', for example
'sleep + 123 = sleep 123', module would give false positive
match.
This patch fixes it, by making matching more explicit - against
'Config'->Cmd' field of 'docker inspect' output, provided by docker-py
API and with proper normalization of user input by splitting it to
tokens with 'shlex.split()'.
|
10 years ago | |
|---|---|---|
| cloud | 10 years ago | |
| commands | 11 years ago | |
| database | 11 years ago | |
| files | 10 years ago | |
| inventory | 11 years ago | |
| network | 10 years ago | |
| packaging | 10 years ago | |
| source_control | 10 years ago | |
| system | 10 years ago | |
| utilities | 10 years ago | |
| web_infrastructure | 10 years ago | |
| windows | 10 years ago | |
| .gitignore | 11 years ago | |
| .travis.yml | 11 years ago | |
| CONTRIBUTING.md | 11 years ago | |
| COPYING | 11 years ago | |
| README.md | 11 years ago | |
| __init__.py | 11 years ago | |
| test-docs.sh | 11 years ago | |
README.md
ansible-modules-core
This repo contains Ansible's most popular modules that are shipped with Ansible.
New module submissions for modules that do not yet exist should be submitted to ansible-modules-extras, rather than this repo.
Take care to submit tickets to the appropriate repo where modules are contained. The docs.ansible.com website indicates this at the bottom of each module documentation page.
Reporting bugs
Take care to submit tickets to the appropriate repo where modules are contained. The repo is mentioned at the bottom of module documentation page at docs.ansible.com.
Testing modules
Ansible module development guide contains the latest info about that.
License
As with Ansible, modules distributed with Ansible are GPLv3 licensed. User generated modules not part of this project can be of any license.
Installation
There should be no need to install this repo separately as it should be included in any Ansible install using the official documented methods.