You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Toshio Kuratomi 00a02574c2 Make the timeout decorator raise an exception out of the function's scope (#49921) ... * Revert "allow caller to deal with timeout (#49449)" This reverts commit 63279823a7. Flawed on many levels * Adds poor API to a public function * Papers over the fact that the public function is doing something bad by catching exceptions it cannot handle in the first place * Papers over the real cause of the issue which is a bug in the timeout decorator * Doesn't reraise properly * Catches the wrong exception Fixes #49824 Fixes #49817 * Make the timeout decorator properly raise an exception outside of the function's scope signal handlers which raise exceptions will never work well because the exception can be raised anywhere in the called code. This leads to exception race conditions where the exceptions could end up being hanlded by unintended pieces of the called code. The timeout decorator was using just that idiom. It was especially bad because the decorator syntactically occurs outside of the called code but because of the signal handler, the exception was being raised inside of the called code. This change uses a thread instead of a signal to manage the timeout in parallel to the execution of the decorated function. Since raising of the exception happens inside of the decorator, now, instead of inside of a signal handler, the timeout exception is raised from outside of the called code as expected which makes reasoning about where exceptions are to be expected intuitive again. Fixes #43884 * Add a common case test. Adding an integration test driven from our unittests. Most of the time we'll timeout in run_command which is running things in a subprocess. Create a test for that specific case in case anything funky comes up between threading and execve. * Don't use OSError-based TimeoutError as a base class Unlike most standard exceptions, OSError has a specific parameter list with specific meanings. Instead follow the example of other stdlib functions, concurrent.futures and multiprocessing and define a separate TimeoutException. * Add comment and docstring to point out that this is not hte Python3 TimeoutError (cherry picked from commit bd072fe83a)		7 years ago
..
cli	Fix unit tests which modify the source tree. (#45763)	7 years ago
config	[stable-2.6] Fix another corner case of too many warnings for world readable current working directory	7 years ago
contrib	Update vmware_inventory (#26308)	9 years ago
errors	test/: PEP8 compliancy (#24803)	9 years ago
executor	module_common: handle None value for templar (#36651)	8 years ago
inventory_test_data/group_vars	Merge branch 'v2_final' into devel_switch_v2	11 years ago
mock	avoid caching invetnory sources in loader (#38242)	8 years ago
module_utils	Make the timeout decorator raise an exception out of the function's scope (#49921)	7 years ago
modules	[stable-2.6] Fix unit test issues with pytest >= 4.0.0.	7 years ago
parsing	[stable-2.6] Support nested JSON decoding in AnsibleJSONDecoder (#45924)	7 years ago
playbook	Fix multiple var files combining (followup to #36357)	8 years ago
plugins	[stable-2.6] Disallow use of remote home directories containing .. in their path (CVE-2019-3828) (#52133)	7 years ago
template	Remove duplicated "instead" word (#38800)	8 years ago
utils	[aws unit test utils] only create a recordings directory when the env var is set (#45752)	7 years ago
vars	Miscellaneous pylint fixes.	8 years ago
__init__.py	Add empty-init code-smell script. (#18406)	9 years ago
ansible.cfg	Fix ansible-test config management.	8 years ago
conftest.py	Run unit tests in parallel. (#45812)	7 years ago
test_constants.py	1st part of ansible config, adds ansible-config to view/manage configs (#12797)	9 years ago