You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/lib/ansible/module_utils/common
Sam Doran 7e4cffc5d2
[stable-2.10] Change default file permissions so they are not world readable (#70221) (#70824)
* Change default file permissions so they are not world readable

CVE-2020-1736

Set the default permissions for files we create with atomic_move() to 0o0660. Track
which files we create that did not exist and warn if the module supports 'mode'
and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults.

A code audit is needed to find all instances of modules that call atomic_move()
but do not call set_mode_if_different(). The findings need to be documented in
a changelog since we are not warning. Warning in those instances would be frustrating
to the user since they have no way to change the module code.

- use a set for storing list of created files
- just check the argument spac and params rather than using another property
- improve the warning message to include the default permissions.
(cherry picked from commit 5260527c4a)

Co-authored-by: Sam Doran <sdoran@redhat.com>
5 years ago
..
text Properly handle unicode in safe_eval (#68576) 6 years ago
__init__.py Add boilderplate to remove a module but keep documentation. 8 years ago
_collections_compat.py Python 3.8 collections compatibility fixes. 7 years ago
_json_compat.py Move type checking methods out of basic.py and add unit tests (#53687) 7 years ago
_utils.py Cleanups to the common.sys_info API 7 years ago
collections.py __eq__ should be redefined if __hash__ is defined. 6 years ago
dict_transformations.py module_utils.common.*: removed unused objects (#59570) 6 years ago
file.py [stable-2.10] Change default file permissions so they are not world readable (#70221) (#70824) 5 years ago
json.py [stable-2.10] Ensure single vaulted values aren't counted as sequences. Fixes #70784 (#70786) (#70791) 5 years ago
network.py [stable-2.10] Fix boilerplate in setup.py and lib/ansible/ dir.. 5 years ago
parameters.py Deprecation revisited (#69926) 6 years ago
process.py Make get_bin_path() always raise an exception (#56813) 6 years ago
removed.py Nuke all removed_module stubs (#67139) 6 years ago
sys_info.py Replaces deprecated usage of functions in ansible.module_utils.basic (#63990) 6 years ago
validation.py Fix and add tests for some module_utils.common.validation (#67771) 6 years ago
warnings.py Deprecation revisited (#69926) 6 years ago