You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Antoine Pietri 9f0130e2c3 module_utils: require X_OK when checking cwd sanity ... Every time an Ansible module is run, it checks that it is running from a "sane" working directory, a.k.a where it has the permission to be. This is because when running commands, it might temporarily change its working directory, then later restore pop the cwd to the previous one. Therefore, if the module is not run from a working directory where it has the permission to be, the module will execute fine, but then fail when trying to restore to the previous directory. Up until now the way this cwd "sanity" was checked was by checking for the F_OK and R_OK permissions, which respectively check that the directory exists and is readable. However, this is actually not sufficient to check whether you can cwd to it! You also need to check for X_OK, which for directories mean that the directory is searchable. See for example: >>> cwd = os.getcwd() >>> cwd '/root' >>> os.access(cwd, os.F_OK | os.R_OK) True >>> os.access(cwd, os.F_OK | os.R_OK | os.X_OK) False >>> os.chdir(cwd) Traceback (most recent call last): File "<stdin>", line 1, in <module> PermissionError: [Errno 13] Permission denied: '/root' Basically, this means that Ansible will fail every time you run a "become" command from a directory with the mode o+r-x. This commit fixes this issue by adding a requirement for X_OK when checking the sanity of the current working directory.		5 years ago
..
fragments	module_utils: require X_OK when checking cwd sanity	5 years ago
CHANGELOG.rst	fix RPM builds with placeholder CHANGELOG	7 years ago
config.yaml	Implement new changelog generator.	7 years ago