You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/test/units/playbook
David Shrewsbury ff47d3f766
Make sure collection is a list if a str is given (#69081)
* Make sure collection is a list if a str is given

* Call field validation early on collections

Because we are doing work on modifying the collections value before
it is actually validated, we can validate it ourselves early to make
sure the user supplies either a string or list. Dicts are not valid.

The new validation allows us to simplify the _ensure_default_collection()
function. And since the field is now static, we no longer need to specify
a default for it, which also allows us to simplify the function. Since
the default is now removed, we can also remove the sanity/ignore.txt entry
for collectionsearch.py.

New unit tests are added (and the existing one modified) that allow us to
make sure that we throw a parser error if a user specifies something other
than a string or list for the collections value everywhere it can be specified.

* Revert removing the collection default

The default is actually used, so restore it.

* Fix unit tests in test_helpers.py affected by early collection validation
5 years ago
..
role Remove empty setUp/tearDown/tearDownClass methods in test classes. 5 years ago
__init__.py
test_attribute.py Move unit test compat code out of `lib/ansible/`. (#46996) 6 years ago
test_base.py Replace TestCase.assertEquals with TestCase.assertEqual. 5 years ago
test_block.py Remove empty overridden unittest.setUp and unittest.tearDown methods. 5 years ago
test_collectionsearch.py Make sure collection is a list if a str is given (#69081) 5 years ago
test_conditional.py conditional: fix direct boolean "shortcut" (#47941) 6 years ago
test_helpers.py Make sure collection is a list if a str is given (#69081) 5 years ago
test_included_file.py Check if task file is specified for import_tasks (#57572) 5 years ago
test_play.py Remove empty overridden unittest.setUp and unittest.tearDown methods. 5 years ago
test_play_context.py Split test_play_context_make_become_cmd into files (#68026) 5 years ago
test_playbook.py Remove empty setUp/tearDown/tearDownClass methods in test classes. 5 years ago
test_taggable.py Allow tags to be templated from a variable (#49833) 6 years ago
test_task.py Replace TestCase.assertEquals with TestCase.assertEqual. 5 years ago