You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/lib/ansible
Ganesh Nalawade 90cd87f950
Fix debug logs failing with persistent connection (#33049)
* Fix debug logs failing with persistent connection

Fixes #33047

*  As debug logs are written on stdout, it interrupts
   the communication between ansible-connection(background)
   process and main process. To avoid this add a string similar
   to exactly identify the response string.

*  Remove unwanted code in ansible-connection

*  Fix review comments

* Fix spurious log emitted on ansible-connection stdout issue

*  ansible-connection which runs as a background process sends a
   json string (contains response received from remote device)
   to foreground ansible-playbook process over stdout.

*  If in case debug flag is enabled the connection_loader api
   invoked from ansible-connection `ssh = connection_loader.get('ssh', class_only=True)`
   results in emitting debug logs on stdout. This  spurious log
   interfere with the actual response and results in failure while
   reading json string in ansible-playbook process

* To avoid this save stdout of ansible-connection and redirect it string
  buffer to accumulate all the logs emitted by core API's

* Add these logs in `result['messages']` which is send a json string after reinstating saved stdout

*  Remove unwanted code in ansible-connection

* Fix review comment
7 years ago
..
cli add a vault --encrypt-vault-to specify vault id to use for encrypt (#31067) 7 years ago
compat Create a short license for PSF and MIT. (#32212) 7 years ago
config spelling (#35258) 7 years ago
errors Make AnsibleActionDone a private exception 7 years ago
executor Fix debug logs failing with persistent connection (#33049) 7 years ago
galaxy Catch exception comparing role versions, and provide a user friendly error message. Fixes #32301 (#34427) 7 years ago
inventory add inventory caching & use in virtualbox inventory plugin (#34510) 7 years ago
module_utils More bug fixes before 2.5 (#35260) 7 years ago
modules Support for Services in the IPA module (#35175) 7 years ago
parsing Remove deprecated code (#34828) 7 years ago
playbook Temporary (#31677) 7 years ago
plugins Fix debug logs failing with persistent connection (#33049) 7 years ago
template [template/vars] Use to_native(exception) as a fallback for Python 3 which doesn't have a .message attribute (#34044) 7 years ago
utils Fix debug logs failing with persistent connection (#33049) 7 years ago
vars Don't skip an inventory source just because it has a comma (#35002) 7 years ago
__init__.py Fix ziploader for the cornercase of ansible invoking ansible. 9 years ago
constants.py Move module_set_locale and module_lang back to global 7 years ago
release.py Bump the versions now that devel is 2.5 7 years ago