mirror of https://github.com/ansible/ansible.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
7e4cffc5d2
* Change default file permissions so they are not world readable
CVE-2020-1736
Set the default permissions for files we create with atomic_move() to 0o0660. Track
which files we create that did not exist and warn if the module supports 'mode'
and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults.
A code audit is needed to find all instances of modules that call atomic_move()
but do not call set_mode_if_different(). The findings need to be documented in
a changelog since we are not warning. Warning in those instances would be frustrating
to the user since they have no way to change the module code.
- use a set for storing list of created files
- just check the argument spac and params rather than using another property
- improve the warning message to include the default permissions.
(cherry picked from commit
|
6 years ago | |
|---|---|---|
| .. | ||
| _vendor | 6 years ago | |
| ansible_test | 6 years ago | |
| cli | 6 years ago | |
| compat | 7 years ago | |
| config | 6 years ago | |
| errors | 6 years ago | |
| executor | 6 years ago | |
| galaxy | 6 years ago | |
| inventory | 6 years ago | |
| inventory_test_data/group_vars | 11 years ago | |
| mock | 6 years ago | |
| module_utils | 6 years ago | |
| modules | 6 years ago | |
| parsing | 6 years ago | |
| playbook | 6 years ago | |
| plugins | 6 years ago | |
| regex | 7 years ago | |
| template | 6 years ago | |
| utils | 6 years ago | |
| vars | 6 years ago | |
| __init__.py | 9 years ago | |
| requirements.txt | 6 years ago | |
| test_constants.py | 6 years ago | |
| test_context.py | 6 years ago | |