mirror of https://github.com/ansible/ansible.git
You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
0868fec8bd
* nxos_vpc: pkl_vrf fixes for #57069 Fixes #57069 - Symptom: When playbooks specify `pkl_vrf: default`, the result is that the cli does not set the `vrf` state. - Analysis: - First issue: 'default' is a reserved word when used with the `peer-keepalive` `vrf` keyword. It refers to the default rib. - This is confusing in several ways because `peer-keepalive`'s *default* vrf is the `management` vrf. - Second issue: When changing only one optional value (`pkl_vrf`) while other optional values are idempotent (`pkl_src`), the result is that the idempotent values are ignored; unfortunately the device cli *replaces* the entire command, in which case the idempotent values are removed. - e.g. playbook specifies this: ``` { pkl_dest: 10.1.1.1, pkl_src: 10.2.2.2, pkl_vrf: my_vrf } ``` ``` peer-keepalive dest 10.1.1.1 src 10.2.2.2 # original peer-keepalive dest 10.1.1.1 src 10.2.2.2 vrf my_vrf # intended result peer-keepalive dest 10.1.1.1 vrf my_vrf # actual result ``` - Third issue: the `pkl` getter was relying on positional data. This broke when the `udp` keyword nvgen'd where `vrf` used to appear (shifting all keywords to the right). - Tested on regression platforms: `N3K,N6k,N7K,N9K,N3K-F,N9K-F` * PEP fixes * PEP fix 2 * pkl should merge by default, not override * rmv debugs * add mike's tests * fix comments |
7 years ago | |
|---|---|---|
| .. | ||
| aireos | 7 years ago | |
| aruba | 7 years ago | |
| asa | 7 years ago | |
| basics | 9 years ago | |
| checkpoint | 7 years ago | |
| cli | 7 years ago | |
| cloudvision | 7 years ago | |
| cnos | 7 years ago | |
| cumulus | 8 years ago | |
| dellos6 | 7 years ago | |
| dellos9 | 7 years ago | |
| dellos10 | 7 years ago | |
| edgeos | 7 years ago | |
| edgeswitch | 7 years ago | |
| enos | 7 years ago | |
| eos | 7 years ago | |
| exos | 7 years ago | |
| f5 | 7 years ago | |
| fortimanager | 7 years ago | |
| frr | 7 years ago | |
| ftd | 7 years ago | |
| ingate | 7 years ago | |
| ios | 7 years ago | |
| iosxr | 7 years ago | |
| ironware | 7 years ago | |
| itential | 7 years ago | |
| junos | 7 years ago | |
| netact | 7 years ago | |
| netscaler | 7 years ago | |
| netvisor | 7 years ago | |
| nos | 7 years ago | |
| nso | 7 years ago | |
| nuage | 7 years ago | |
| nxos | 7 years ago | |
| onyx | 7 years ago | |
| opx | 7 years ago | |
| ovs | 7 years ago | |
| radware | 7 years ago | |
| routeros | 7 years ago | |
| slxos | 7 years ago | |
| voss | 7 years ago | |
| vyos | 7 years ago | |
| __init__.py | 9 years ago | |