You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/test
Rick Elrod e2a57414f4 Remove `with` statement for pytest-mock unit tests
As per:
https://github.com/pytest-dev/pytest-mock#note-about-usage-as-context-manager
pytest-mock is not meant to be used within a `with` context or as a
decorator. Instead, pytest-mock will automatically unpatch the mocked
methods when each test is complete.

In newer pytest-mock, this use actually throws an exception and causes
the tests to fail.

This hasn't been hit in Ansible's CI yet, because the docker image
that the tests run in uses an older version of pytest-mock. However,
there is no constraint on the upper bound of pytest-mock in
test/lib/ansible_test/_data/requirements/constraints.txt which means
that when running the tests locally, outside of that docker image, the
tests never pass.

This patch removes the `with` context in each such case.

Signed-off-by: Rick Elrod <rick@elrod.me>
5 years ago
..
ansible_test Relocate ansible-test self tests outside package. (#61255) 5 years ago
integration vmware_vswitch/test: clean up vmswitch_0002 5 years ago
legacy Use context manager for file handling in misc files. (#65372) 5 years ago
lib/ansible_test Forbid `state=(list|info)` in modules via ansible-test sanity check 5 years ago
sanity Forbid `state=(list|info)` in modules via ansible-test sanity check 5 years ago
units Remove `with` statement for pytest-mock unit tests 5 years ago
utils Consolidate remote Shippable scripts. 5 years ago