You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/test/units
Adrian Likins a14d0f3586 Use vault_id when encrypted via vault-edit (#30772)
* Use vault_id when encrypted via vault-edit

On the encryption stage of
'ansible-vault edit --vault-id=someid@passfile somefile',
the vault id was not being passed to encrypt() so the files were
always saved with the default vault id in the 1.1 version format.

When trying to edit that file a second time, also with a --vault-id,
the file would be decrypted with the secret associated with the
provided vault-id, but since the encrypted file had no vault id
in the envelope there would be no match for 'default' secrets.
(Only the --vault-id was included in the potential matches, so
the vault id actually used to decrypt was not).

If that list was empty, there would be an IndexError when trying
to encrypted the changed file. This would result in the displayed
error:

ERROR! Unexpected Exception, this is probably a bug: list index out of range

Fix is two parts:

1) use the vault id when encrypting from edit

2) when matching the secret to use for encrypting after edit,
include the vault id that was used for decryption and not just
the vault id (or lack of vault id) from the envelope.

add unit tests for #30575 and intg tests for 'ansible-vault edit'

Fixes #30575
7 years ago
..
cli Don't ask for password confirm on 'ansible-vault edit' (#30514) 7 years ago
contrib Update vmware_inventory (#26308) 7 years ago
errors test/: PEP8 compliancy (#24803) 8 years ago
executor Ansible Config part2 (#27448) 7 years ago
inventory INI inventory plugin: add documentation about variable types (#25798) 7 years ago
inventory_test_data/group_vars Merge branch 'v2_final' into devel_switch_v2 10 years ago
mock Fix dangerous default args. (#29839) 7 years ago
module_utils Fix 'distribution' fact for ArchLinux (#30723) 7 years ago
modules - Adds sub-interface support for nxos_interface and nxos_ip_interface (#30830) 7 years ago
parsing Use vault_id when encrypted via vault-edit (#30772) 7 years ago
playbook less confusing 'args' message (#29053) 7 years ago
plugins Enable more pylint rules and fix reported issues. (#30543) 7 years ago
template template: fix KeyError: 'undefined variable: 0 (#27972) 7 years ago
utils test/: PEP8 compliancy (#24803) 8 years ago
vars Miscellaneous pylint fixes. 7 years ago
__init__.py Add empty-init code-smell script. (#18406) 8 years ago
conftest.py Fix bugs in ansible-test units command. (#24044) 8 years ago
test_constants.py 1st part of ansible config, adds ansible-config to view/manage configs (#12797) 8 years ago