You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/windows
Dreamcat4 469d22df97 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
9 years ago
..
__init__.py package file 10 years ago
win_chocolatey.ps1 win_chocolatey bugfixes 9 years ago
win_chocolatey.py Add author data 9 years ago
win_dotnet_ngen.ps1 Create win_dotnet_ngen module 9 years ago
win_dotnet_ngen.py more doc fixes 9 years ago
win_environment.ps1 Update attribution 9 years ago
win_environment.py Update attribution 9 years ago
win_firewall_rule.ps1 fix: The names of firewall profiles are different on win10 & win2008r2 9 years ago
win_firewall_rule.py fix: The names of firewall profiles are different on win10 & win2008r2 9 years ago
win_iis_virtualdirectory.ps1 Modules to manage IIS 10 years ago
win_iis_virtualdirectory.py minor doc fixes 9 years ago
win_iis_webapplication.ps1 Modules to manage IIS 10 years ago
win_iis_webapplication.py Fix up docs 9 years ago
win_iis_webapppool.ps1 Modules to manage IIS 10 years ago
win_iis_webapppool.py These modules were added to version 2.0, not 1.9 9 years ago
win_iis_webbinding.ps1 Modules to manage IIS 10 years ago
win_iis_webbinding.py These modules were added to version 2.0, not 1.9 9 years ago
win_iis_website.ps1 Workaround for bug in PowerShell Get-Website cmdlet. 9 years ago
win_iis_website.py These modules were added to version 2.0, not 1.9 9 years ago
win_nssm.ps1 Move comments to the documentation 9 years ago
win_nssm.py doc formatting fixes 9 years ago
win_package.ps1 fixes #984 9 years ago
win_package.py added module author 9 years ago
win_regedit.ps1 Adding functionality to not only edit Values, but also Keys. 9 years ago
win_regedit.py Adding functionality to not only edit Values, but also Keys. 9 years ago
win_scheduled_task.ps1 Remove duplicate action declaration. 9 years ago
win_scheduled_task.py Note parameters that are not idempotent 9 years ago
win_unzip.ps1 use convertto-bool for rm and recurse params 9 years ago
win_unzip.py minor doc fixes that had lingering description of deprecated functions 9 years ago
win_updates.ps1 win_updates rewrite for 2.0 9 years ago
win_updates.py win_updates rewrite for 2.0 9 years ago
win_webpicmd.ps1 win_webpicmd module for IIS module installation 9 years ago
win_webpicmd.py more doc fixes 9 years ago