You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
ansible/test/units/modules
Chris Van Heuveln 0868fec8bd nxos_vpc: pkl_vrf fixes for #57069 (#57370)
* nxos_vpc: pkl_vrf fixes for #57069

Fixes #57069

- Symptom: When playbooks specify `pkl_vrf: default`, the result is that the cli does not set the `vrf` state.

- Analysis:
 - First issue: 'default' is a reserved word when used with the `peer-keepalive` `vrf` keyword. It refers to the default rib.
   - This is confusing in several ways because `peer-keepalive`'s *default* vrf is the `management` vrf.

 - Second issue: When changing only one optional value (`pkl_vrf`) while other optional values are idempotent (`pkl_src`), the result is that the idempotent values are ignored; unfortunately the device cli *replaces* the entire command, in which case the idempotent values are removed.
   - e.g. playbook specifies this:
     ```
     { pkl_dest: 10.1.1.1, pkl_src: 10.2.2.2, pkl_vrf: my_vrf }
     ```

     ```
     peer-keepalive dest 10.1.1.1 src 10.2.2.2             # original

     peer-keepalive dest 10.1.1.1 src 10.2.2.2 vrf my_vrf  # intended result

     peer-keepalive dest 10.1.1.1 vrf my_vrf               # actual result
     ```

 - Third issue: the `pkl` getter was relying on positional data. This broke when the `udp` keyword nvgen'd where `vrf` used to appear (shifting all keywords to the right).

- Tested on regression platforms: `N3K,N6k,N7K,N9K,N3K-F,N9K-F`

* PEP fixes

* PEP fix 2

* pkl should merge by default, not override

* rmv debugs

* add mike's tests

* fix comments
5 years ago
..
cloud kubevirt: more unit tests (#57739) 5 years ago
crypto New LUKS devices management module (#48991) 6 years ago
files Fixes #34893 (#40166) 7 years ago
messaging Rabbitmq user permission fixes (#49404) 6 years ago
monitoring Move unit test compat code out of `lib/ansible/`. (#46996) 6 years ago
net_tools Hetzner failover IP: refactoring (#56203) 6 years ago
network nxos_vpc: pkl_vrf fixes for #57069 (#57370) 5 years ago
notification Add support for hex color in slack module (#49804) 6 years ago
packaging rename rhsm_repository_release to rhsm_release (#53430) 6 years ago
remote_management Adding dell ome device_info module (#53438) 5 years ago
source_control gitlab_runner: Fix idempotency when creating runner (#57833) 5 years ago
storage na_ontap_snapshot_policy: Add ability to multiple schedules (#57366) 5 years ago
system pamd: fix idempotence issue when removing rules (#54105) 6 years ago
web_infrastructure Python 3.8 collections compatibility fixes. 6 years ago
__init__.py Some algorithmic unittests for the apt and docker modules 9 years ago
conftest.py fix missing attribs with dirct module execution (#53875) 6 years ago
utils.py Move unit test compat code out of `lib/ansible/`. (#46996) 6 years ago