Commit Graph

39 Commits (ffb87adbc2fa14d5162b185a2621583545a78448)

Author SHA1 Message Date
Michael DeHaan 5826e1354a Slightly revise wording. 11 years ago
Michael DeHaan ff2177442b Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 11 years ago
James Cammarata 09c998f104 Fixing some parsing issues in authorized_key module
Also adds an integration test for authorized_key for future validation.

Fixes #6700
11 years ago
Michael DeHaan 9fa0ec57fb Scrub choices=BOOLEANS from remaining core module references. Correct form in argument_spec is type='dict'. 11 years ago
Till Maas a063987d0e authorized_key: Be more specific about manage_dir
- Explain which properties are managed when manage_dir is True.
11 years ago
Laurens Van Houtven c50b772e61 Support ssh-ed25519 keys
The newest version of OpenSSH supports a new, wonderful key type. authorized_key incorrectly discards pubkeys of this type as busted because it doesn't recognize type signature.
11 years ago
kustodian 405dee2398 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
11 years ago
Scott Gilbert df72690e6c Allow keystring passed to authorized_key to contain blank lines and comments 11 years ago
James Tanner a9c5aa8f78 Remove unused variable from authorized_key 11 years ago
James Tanner 30f7b2d298 Fixes #5486 Keep authorized key options in tact and ordered 11 years ago
jctanner 4125713b6e Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
11 years ago
James Tanner 4f9aadcc07 Addresses #5023 Fix import comments 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Matthias Blaser 1e1def3fbd rewrite options to dict parser, fixes #5032 11 years ago
Michael DeHaan 4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan 9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
James Tanner fa4b30819a Fix comment yaml escaping in authorized_key module 11 years ago
James Tanner 999b04f7fa Save comment hashes in sshkeys 11 years ago
James Tanner 7de788f346 Cleanup debug statements 11 years ago
James Tanner d0c2b37688 Fixes #5032 escape and safely split key options in authorized_keys module 11 years ago
James Tanner 407d6041b3 Fixes #5021 safely split hostkeys with quotes 11 years ago
James Cammarata 4c80cf411c Fixing authorized_keys module to make the key part detection better
Fixes #4677
Fixes #4657
Fixes #4599
11 years ago
James Cammarata a220d7c18c Merge branch 'fix_autorized_keys' of https://github.com/mscherer/ansible into mscherer-fix_autorized_keys 11 years ago
James Cammarata 8fc62a1fb0 Fixing up authorized_keys to accept comments with spaces 11 years ago
Michael Scherer d53abc2d5e make sure that options are quoted, as people can add a shell
script there with a comma that would produce invalid configuration
upon being wrote again
11 years ago
Michael Scherer 2ad3a46e13 sort the option_key to have a constant predictable line 11 years ago
Michael Scherer 7afaeea131 adding a single comma at the end of the options list confuse the module
it start to duplicate line, because this create
a empty option in the list, and so the module add a new line along the previous
one. See

>>> ' a,b, '.strip().split(',')
['a', 'b', '']
11 years ago
jctanner 6dedb68bde Merge pull request #4517 from adfinis-sygroup/devel
Remove keys regardless of the options
11 years ago
James Cammarata 57cec2a88b Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
11 years ago
Stefan Heinemann 576f5813a2 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
11 years ago
Stefan Heinemann 948713db5e Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
11 years ago
James Cammarata 2753a40d5a Adding 'unique' option to authorized_key module and cleanup
A small refactoring of the authorized_key module to accomodate these
changes, plus fixing some things like not rewriting the file on every
new key. These changes bring the original feature for ssh options in-
line with the comments in #3798

Fixes #3785
11 years ago
David Minor 0828d3a316 Add ssh key options parameter to authorized_key module 11 years ago
Joshua Lund d75f73fffe Added a new with_file example to the authorized_key documentation 12 years ago
Jan-Piet Mens 3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Joshua Lund dcad99ca6b Updates to the authorized_key documentation
* Clarified the meaning of 'user'
* Changed 'sshdir' to 'path' in the example
  * 'sshdir' is used internally in the module, but the argument is 'path'
* Made the capitalization consistent in the descriptions
12 years ago
Lorin Hochstein ec2fc7c983 authorized_key: Set manage_dir default value
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
12 years ago
Oleg 6735ec6e9d fix for authorized_key: skip chown and chmod if authorized_key_file is link 12 years ago
Michael DeHaan cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago