Commit Graph

26 Commits (fca8ec3d3c090f2a28c4774a29019c05e5eff787)

Author SHA1 Message Date
Justin Ludwig 26374d89a0 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
11 years ago
James Tanner fb903c5317 Change s3 module to use shared ec2 authorization module snippet 11 years ago
dragon3 e54832a730 Remove duplicate "download_s3file" execution when the destination path doesn't exist 11 years ago
Lorin Hochstein 1c5bdba977 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
11 years ago
James Tanner d21a0287a2 Remove all sys.exit calls in the cloud/s3 module
Fixes #4458
11 years ago
Matthew Barrington ce0bf71245 Fixed crash when s3 bucket did not exist for put operation 11 years ago
James Tanner c679491ece #4408 s3: add force alias for overwrite and set True by default 11 years ago
James Tanner c55107fa83 Remove debug comment from s3 module 11 years ago
James Tanner 9c3fb9c2b7 4006: return s3 url even if file exists 11 years ago
Michael DeHaan d803ce7ab3 Fix documentation of default value in s3 module. Fixes #4289 11 years ago
Benno Joy c1198dc12c change "Changed" to changed 11 years ago
bennojoy 00dcf0f1ac minor fixes 11 years ago
Jeremy Price f56b3fba3e dest in s3 module does not work with ~username notation for home directories. Wrapped dest definition in os.path.expanduser() which will return the expanded path in case of successful tilde expansion and otherwise the original value 11 years ago
Bruce Pennypacker 0f458210bc Rebase attempt
No idea if I'm rebasing properly or not.  This is my first attempt.
11 years ago
Michael DeHaan 0b4e145709 Merge pull request #3772 from lorin/s3-docpatch
Minor doc update to s3 & ec2 modules
11 years ago
Michael DeHaan 0edcbdca05 Merge pull request #3709 from lwade/devel
S3folder
11 years ago
Lorin Hochstein 729c03ed88 Minor doc update to s3 & ec2 modules
Adds some additional docs about the module parameters for s3
and ec2 modules.
11 years ago
Michael DeHaan dab48fa3ed Slight docs tweak and remove redundant sys.exit call 11 years ago
lwade f6cb9bce15 Added ability to create virtual directories. 12 years ago
Peter Hall d1369f3d95 Adding getstr mode to download an object into a variable 12 years ago
lwade ae992c6b6e Rewritten s3 module to allow for additional modes of operation. 12 years ago
Jan-Piet Mens 5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Michael DeHaan e06ced89fb Doc standardization/style 12 years ago
Shahar Kedar fe6ca38bec Issue #3079: Initializing key_exists in case the S3 bucket does not exist 12 years ago
Ralph Tice 918de8d6dc amended s3 plugin to support 'dest' parameter to allow uploading to custom location 12 years ago
Michael DeHaan 391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago