Commit Graph

2808 Commits (fb779bf30cfe4bbe15b2fe685974caeca71b941c)

Author SHA1 Message Date
Ryan 810b40aee9 fix typo in azure_rm_storageaccount (#4236) 8 years ago
chrisweaver 8879931f0c Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
8 years ago
Matthew Martin 34d48eb89b Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
8 years ago
Michael Baydoun 07383c40d7
fixes issues where iam_policy incorrected reported changed 8 years ago
Andrei Lukovenko 3945794704 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
8 years ago
John Baublitz e85c2f8253 Collapse boilerplate code into change_instance_state function 8 years ago
Toshio Kuratomi 55e6703209 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
8 years ago
John Baublitz b5da9d190d Add states for stopping and starting machines 8 years ago
Ryan Brown f61ddbc8a9 Merge pull request #3863 from ryansb/iam-pass-module
Bugfix: IAM group modules need `module` passed
8 years ago
Tom Melendez 7c8d972d8f Added helper function and logic to sort attributes before comparing. 8 years ago
Tom Melendez 0f1c083d25 Allow GCE firewall rules to be updated when attributes changes. Fixes #2111.
Previously, when the attributes of a GCE firewall change, they were ignored.  This PR changes that behavior and now updates them.

Note that the "update" also removes attributes that are not specified.

An overview of the firewall rule behavior is as follows:

1. firewall name in GCP, state=absent in PLAYBOOK: Delete from GCP
2. firewall name in PLAYBOOK, not in GCP: Add to GCP.
3. firewall name in GCP, name not in PLAYBOOK: No change.
4. firewall names exist in both GCP and PLAYBOOK, attributes differ: Update GCP to match attributes from PLAYBOOK.
8 years ago
Chris Houseknecht eab6bb8794 Merge pull request #4176 from h-hirokawa/fix4174
Fix azure_rm_virtualmachine to create a storage account with name contains lower-case only  (#4174).
8 years ago
Chris Houseknecht 77db7011f0 Merge pull request #4173 from chouseknecht/fix_entrypoint
Fix entrypoint. Should behave the same as command.
8 years ago
h-hirokawa 977a6a8b28 Fix azure_rm_virtualmachine (#4174). 8 years ago
Chris Houseknecht a75ee76aa3 Entrypoint fails with 'command not found' error. 8 years ago
Chris Houseknecht 58b551774c Add push parameter. Let API handle registry authentication check. 8 years ago
Chris Houseknecht 1058094b64 Fix module failing when no ports are exposed 8 years ago
jjshoe 90b8281a51 Fixed a typo (#4168) 8 years ago
Chris Houseknecht 73dbb744b5 Merge pull request #3887 from Jorge-Rodriguez/docker-image-no-push-on-load
Don't forcibly push loaded images to registry.
8 years ago
Kai Kousa 7632bc1ecb Improve documentation on security_groups-option 8 years ago
Chris Houseknecht 328f047fda Merge pull request #4040 from qiluo-msft/qiluo/actual_stdin_open
Fix getting actual_stdin_open
8 years ago
Chris Houseknecht 4aee56553f
Fix multi-interface port binding. 8 years ago
Chris Houseknecht 9c88c45dd2 Merge pull request #4155 from chouseknecht/fix_4091
Support publishing all ports.
8 years ago
Chris Houseknecht e51024c84d Fix 'all' option for published_ports parameter. 8 years ago
Chris Houseknecht 36ed0ad766 Add cleanup parameter. (#4144) 8 years ago
David Shrewsbury a606e9cd37 Fix bug in os_router.py when router is not actually updated. (#4107)
The shade update_router() call will return None if the router is
not actually updated. This will cause the module to fail if we
do not protect against that.
8 years ago
Chris Houseknecht 391561fa5d Merge pull request #4151 from chouseknecht/fix_4139
Fix purge_networks
8 years ago
Rene Moser 45845e0bdc os_server, doc: add version added for delete_fip
Also see #3509
8 years ago
David Shrewsbury 3979faf3e5 Allow os_server to delete FIP (#3509)
The os_server module could automatically generate a floating IP for
the user with auto_ip=true, but we didn't allow for this FIP to be
automatically deleted when deleting the instance, which is a bug.
Add a new option called delete_fip that enables this.
8 years ago
Chris Houseknecht 78f6c7e51e
Fix purge_networks 8 years ago
Andrei Lukovenko ff223ee14c Bug: invocation with state=absent always leads to (#3051)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: destroy domain
  digital_ocean_domain: state=absent name=DOMAIN_NAME

Problem: DigitalOcean API accepts domain name, not record ID
(https://developers.digitalocean.com/documentation/v2/#delete-a-domain)
8 years ago
Adrian Moisey 74285d6a53 Add default port for aurora (#4102)
If a port isn't specified, it's looked up. The lookup breaks without
this.

Related: https://github.com/ansible/ansible-modules-core/pull/3414
8 years ago
Chris Houseknecht bb582ae574
Remove object name validation. 8 years ago
Chris Houseknecht 90b3860f5b Merge pull request #4097 from chouseknecht/azure-rc5
Update and pin to azure-2.0.0rc5
8 years ago
chouseknecht de9959b129 Update and pin to azure-2.0.0rc5 8 years ago
Patrick Uiterwijk 414d3611cb nova_compute: indicate argument type (#4070)
Without this, ansible 2.1 will convert some arguments that are
meant to be dict or list type to their str representation.

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
8 years ago
Matt Davis 0ee7b9896d Merge pull request #4080 from talonx/devel
Fix for #16518 - added missing regions
8 years ago
Ryan Brown 4845c96b00 Remove double-assignment of EC2 parameters (#4081)
The `source_dest_check` and `termination_protection` variables are being
assigned twice in ec2.py, likely due to an incorrect merge somewhere
along the line.
8 years ago
Hrishikesh Barua 718471e302 Fix for #16518 - added missing regions 8 years ago
Qi Luo 93e502f019 Fix getting actual_stdin_open 9 years ago
Graham Goldstein 4f8f0cf66b Change documented options for os_networks_facts (#3970)
* Change documented options for os_networks_facts

os_network_facts currently lists 'network' as an available option, taking the Name or ID. In Ansible 2.0.2 to 2.2.0, this is not valid. Options 'name' and 'id' should be used instead.

* Update os_networks_facts.py

* Update os_networks_facts.py

Set version_added to the only accepted value

* Update os_networks_facts.py

Removed inappropriate 'ID' parameter
9 years ago
Ryan Brown 47e22248c4 Merge pull request #3091 from jmunhoz/s3-ceph
Add Ceph RGW S3 compatibility
9 years ago
Chris Houseknecht 75d167e34f Merge pull request #3994 from chouseknecht/fix_ulimit
Fix ulimit comparison
9 years ago
Javier M. Mellid a88d6d9a53 Add s3_url requirement in doc when rgw support is enabled in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
9 years ago
Javier M. Mellid a52ff221f7 Add proper version_added for rgw option in s3.py
Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
9 years ago
Javier M. Mellid b1724344d5 Add Ceph RGW S3 compatibility
Ceph Object Gateway (Ceph RGW) is an object storage interface built on top of
librados to provide applications with a RESTful gateway to Ceph Storage
Clusters:

http://docs.ceph.com/docs/master/radosgw/

This patch adds the required bits to use the RGW S3 RESTful API properly.

Signed-off-by: Javier M. Mellid <jmunhoz@igalia.com>
9 years ago
chouseknecht 7f97cf4d04
Fix compose_version error. Check has compose before checking version. 9 years ago
chouseknecht 34305ded28 Fix index 9 years ago
chouseknecht 5f9f1642bc
Fix ulimit comparison 9 years ago
Mario David ae5ccf29ed add project to os_router (#3869)
* add project to os_router

* version_added fix

* correct place of version_added

* remove extraneous else

* * add shade version dependency check
* option project only on router creation

* * fix shade minimal version
* remove pop of option project

* * fix square brackets
* delete router by router_id
9 years ago
Adam Butler 1c41b6fdb2 Fixes incorrect key name protocols -> protocol (#3963) 9 years ago
Hagen Kuehn a5fdd8c128 fixed unknown type <type 'list'> error (#3959) 9 years ago
Chris Houseknecht 0802569af9 Merge pull request #3894 from stefanha/docker_image-load_image-streaming
Stream image data in load_image() to avoid out-of-memory
9 years ago
Chris Houseknecht 0098dc322f Merge pull request #3535 from picpicpic/devel
fixes dns type in docker module
9 years ago
chouseknecht d988187860
Remove dns from container create parameters. 9 years ago
chouseknecht 0884a942bf Fix #3945 docker_container detach not waiting on container to execute. 9 years ago
Adrian Likins 97ac3f2cc8 Merge pull request #3701 from gillesgagniard/gce-subnetwork-dev
GCE : Add support for subnet networks
9 years ago
Toshio Kuratomi 1d0f408897 Finish python3 syntax compilation fixing for core repo 9 years ago
chouseknecht af8eabe06f Fix #3941 9 years ago
Stefan Hajnoczi 8254e2b547 docker_service: make PyYAML requirement explicit
The "Developing Modules" documentation states:

  Include a minimum of dependencies if possible. If there are
  dependencies, document them at the top of the module file, and have
  the module raise JSON error messages when the import fails.

When docker_service runs on a remote host without PyYAML it crashes with
ImportError.

This patch raises a JSON error message when import fails, but only if
the PyYAML module is actually used.  It's only needed when the
"definition" parameter is given.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
9 years ago
chouseknecht b9b727f435 Fix #16211 - only stop/kill running containers 9 years ago
Chris Houseknecht 964d9b3a6d Fix #3906 - Enforce required minimum compose version. (#3925)
* Fix #3906 - Require minimum compose version.

* Fix typo in message text.
9 years ago
Bradley Phipps 4a8930f886 added missing colons to documentation (#3913) 9 years ago
Stefan Hajnoczi 47cc422b8a Stream image data in load_image() to avoid out-of-memory
Reading the entire tar file into memory can result in out-of-memory
conditions such as this traceback:

Traceback (most recent call last):
  File "/tmp/ansible_YELTSu/ansible_module_docker_image.py", line 486, in load_image
    self.client.load_image(image_data)
  File "/usr/local/lib/python2.7/dist-packages/docker/api/image.py", line 147, in load_image
    res = self._post(self._url("/images/load"), data=data)
  ...
  File "/usr/lib/python2.7/httplib.py", line 997, in endheaders
    self._send_output(message_body)
  File "/usr/lib/python2.7/httplib.py", line 848, in _send_output
    msg += message_body
MemoryError

Luckily docker-py's load_image(), which calls requests post(), accepts a
file-like object instead of a string.  Pass in the file object to avoid
reading the full file into memory.  This allows larger tar files to load
succesfully.

Signed-off-by: Stefan Hajnoczi <stefanha@gmail.com>
9 years ago
Vince v. Oosten fd418c19c2 move environment variable gathering to end of __init__() (#3890)
* This moves the lines in the code that parse the `env` and `env_file` options for docker to the end of the `__init__()` function.
This is needed because the `_check_capabilites` function needs both a working `self.client` and a proper `self.docker_py_versioninfo`.
`_check_capabilities` is used by `ensure_capabilities` which is, in turn, used by `get_environment`

This means that before this commit, the environment variables could not be loaded because both `self.client` and `self.docker_py_versioninfo` were not set at that time.

This commit fixes that by putting the environment variable parsing after those two.

* This moves the lines in the code that parse the `env` and `env_file` options for docker to the end of the `__init__()` function.
This is needed because the `_check_capabilites` function needs both a working `self.client` and a proper `self.docker_py_versioninfo`.
`_check_capabilities` is used by `ensure_capabilities` which is, in turn, used by `get_environment`

This means that before this commit, the environment variables could not be loaded because both `self.client` and `self.docker_py_versioninfo` were not set at that time.

This commit fixes that by putting the environment variable parsing after those two.
9 years ago
Matt Davis a8e5f27b2c Iam trust policy (#3885)
* added support for trust policies

* added version_added to new params in DOC string

* update version_added on new iam args to 2.2
9 years ago
Rodríguez, Jorge 7d33c6ccdf Do not forcibly push when building, either. 9 years ago
Rodríguez, Jorge a0be466f90 Don't forcibly push loaded images to registry. Fixes #3763 9 years ago
mansunkuo 91e9223a76 Add an example to delete Route53 alias record set (#3834) 9 years ago
chouseknecht 68151790c2
Fix issue #3866 9 years ago
nitzmahone 2bd8d78a8b correct gs_storage docs to match reality 9 years ago
Ryan Brown 878cdb10f9 Merge pull request #3847 from washingtoneg/postgres9.5-rds-param-group-support
Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846)
9 years ago
Ryan Brown f54e39450c Merge pull request #2555 from jsternberg/paginate-iam-results
Paginate the results from `boto.iam`
9 years ago
Ryan S. Brown 1b9e28cc68 IAM group modules need `module` passed
The IAM group modules were not receiving the `module` object, but they
use `module.fail_json()` in their exception handlers. This patch passes
through the module object so the real errors from boto are exposed,
rather than errors about "NoneType has no method `fail_json`".
9 years ago
Michael Pappas d26bb2eb41 Prevent ec2group from deleting sgs during check_mode runs 9 years ago
codemeup @ Work a51a896d20 Fixing Rackspace compile time errors irt exception handling for Python 3 (#3849) 9 years ago
codemeup @ Work 18455b2e72 Fixing open stack compile time errors irt exception handling for Python 3 (#3848) 9 years ago
codemeup @ Work d0a955452a Fixing gce compile time errors irt exception handling for Python 3 (#3845) 9 years ago
chouseknecht 1a3e277f95
Fix 3857 name regex 9 years ago
chouseknecht d43a91c627 Fix #147 automatically expose published ports 9 years ago
chouseknecht 67432709a4
Remove unused method in ContainerManager 9 years ago
Chris Houseknecht 0a42ada42a Merge pull request #3844 from Hypermanzer/docker-python-3-compat-bug
Fixing Docker compile time errors irt exception handling for Python 3
9 years ago
Chris Houseknecht 93c8d923c4 Merge pull request #3837 from chouseknecht/devel
Fix #3822 stop container
9 years ago
chouseknecht 09fe0416b6 Fix #3822 stop container 9 years ago
Jonathan A. Sternberg 969471f2ab Paginate the results from `boto.iam`
The default pagination is every 100 items with a maximum of 1000 from
Amazon. This properly uses the marker returned by Amazon to concatenate
the various pages from the results.

This fixes #2440.
9 years ago
Elena Washington e1d7d78fcc Add support for PostgreSQL 9.5 in rds_param_group (fix for #3846) 9 years ago
codemeup @ Work 27ad29d376 Fixing compile time error exception handling for python 3. (#3843) 9 years ago
Mike Mars 1c63fb754d Fixing Docker compile time errors irt exception handling for Python 3 9 years ago
codemeup @ Work 7314cc3867 Fixing error exception handling for python3. Does not need to be compa… (#3840)
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing compile time errors IRT error exception handling for Python 3.5.
This does not need to be compatible with Python2.4 b/c Boto is Python 2.6 and above.
9 years ago
codemeup @ Work 5b1ab46265 Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above. (#3839) 9 years ago
chouseknecht a676d9e126 Remove registery option per #3824. 9 years ago
chouseknecht 4ded9313b7 Fix upate typo and expected volume compare. 9 years ago
Chris Houseknecht b5e93b51cf Merge pull request #3828 from chouseknecht/winggundamth-devel
Fix volume to support not binding volumes to host
9 years ago
chouseknecht e2d8d9d09a Fixed binds and volumes. Now recognizes bound vs unbound as well as named volumes. 9 years ago
chouseknecht de15a631ad Fix missing ansible_facts. 9 years ago
Jirayut 'Dear' Nimsaeng 1212e2ed25 Fix volume to support not binding volumes to host 9 years ago
Anton Simernia d30040f9dc Update gc_storage.py (#3802) 9 years ago
Chris Houseknecht bf6bf9e68f Merge pull request #3796 from chouseknecht/fix_3766
Fix 3766
9 years ago
chouseknecht e8db7fd8cc
Remove debug/register from examples. 9 years ago
chouseknecht 0601df8c70
Fix network comparison. Fix handling of links. Updated doc strings. Added more examples. 9 years ago
David Shrewsbury d952087557 Merge pull request #3732 from GheRivero/devel
Make add ip_floating_ip idempotent
9 years ago
chouseknecht d9c751be16
Set version added to 2.2 so that tests pass 9 years ago
chouseknecht 78019e4388
For new options move vesion_added to 2.1.1 9 years ago
chouseknecht 633e11be1e
Fixed bug in _get_network_id 9 years ago
chouseknecht 6d9de1b5a1 Fix doc strings. 9 years ago
chouseknecht 3292121e6d
Fixed issues post testing. 9 years ago
chouseknecht 8cd028bd8e First pass at implementing networks parameter. Also added purge_networks option to remove container from networks not included in networks param. 9 years ago
chouseknecht 23816c9c04 Fix for 3768 - adding support for env_file 9 years ago
Chris Houseknecht 4d8f7d161b Merge pull request #3776 from danschmidt5189/fix-docker_container-typo
Fix "ansbile_facts" typo in docker_container module
9 years ago
chouseknecht cba5b37c9f
Check self.parameters.env exists. 9 years ago
chouseknecht c419d351c5 Fix for issue #3775 - env config comparison 9 years ago
chouseknecht 651133469c
Update restart_policy doc strings. 9 years ago
chouseknecht 6aa4feb459
Fix restart_poicy 9 years ago
Chris Houseknecht 9a1387f255 Merge pull request #3784 from chouseknecht/fix_3783
Fix for #3783 - command returns not found or does not exist.
9 years ago
chouseknecht af0aa8247d
Fix for #3783 - command returns not found or does not exist. 9 years ago
pic fee0055f9f fix #3528 : dns type 9 years ago
Dan Schmidt 31d21efbc5 Fix "ansbile_facts" typo in docker_container module 9 years ago
Chris Houseknecht 90e8a36d4c Merge pull request #3347 from dougluce/fix-s3-region-error
Fix S3 unavailable region error
9 years ago
David Fischer d8ad80ae0f Add MariaDB to valid RDS engines (#3337)
* Add MariaDB to valid RDS engines

* Update RDS module documentation
9 years ago
chouseknecht 97f16b52cf
Fix missing key error when updating existing virtual network. 9 years ago
Chris Houseknecht ddb0b53c66 Merge pull request #3745 from chouseknecht/fix_3740
Fix for issue 3740. Make docker_service more resilient when targeting…
9 years ago
Roberto Bampi 423209d187 Add an example for SRV record in route53 (#3749) 9 years ago
chouseknecht 904d947172 Fix for issue 3740. Make docker_service more resilient when targeting older API versions. 9 years ago
Brian Coca d8b67bdeb0 deprecated docker (#3710)
* deprecated docker

* updated formatting
9 years ago
Alvaro Aleman 7f7b9054fd Fix can_update test in os_subnet (#3664) 9 years ago
René Moser 215da19511 Add no_gateway_ip option to os_subnet module (#3736)
no_gateway_ip option can provide subnet that is not having a gateway.
fixes #1880
9 years ago
Doug Luce ec0f2113e0 Fix S3 unavailable region error
This is to address this error:

  fatal: [site]: FAILED! => {"changed": false, "failed": true, "msg": "Failed to connect to S3: Region  does not seem to be available for awsmodule boto.s3. If the region definitely exists, you may need to upgrade boto or extend with endpoints_path"}

Commit 0dd58e9 changed the logic so an exception is thrown (by
`connect_to_aws`) before the `s3 is None` check is performed. This
changes the `None` check to a catch so the old logic can compensate.
9 years ago
Ghe Rivero c5430d0f92 Make add ip_floating_ip idempotent
Closes issue #1858
9 years ago
Ryan Brown aa995806b9 Merge pull request #3320 from hyperized/patch-1
Added restart functionality to ec2.py
9 years ago
Michael Scherer b78d708678 Port vsphere_guest to py3/py2.4 syntax (#3721) 9 years ago
Kenny Woodson 5474da09bc Unindenting the delete to user (#3147) 9 years ago
Ryan Brown 58bb2fc4f6 Allow users to pick AWS Aurora as an RDS engine (#3414)
Per the [RDS docs](http://docs.aws.amazon.com/AmazonRDS/latest/APIReference/API_CreateDBInstance.html),
add `aurora` as a valid DB engine.
9 years ago
Nathan Brown 97f6daa854 Do not expect the elb to have policies or instances. Fixes #3593 (#3595) 9 years ago
kwerey 1bfc33728b Add option to make RDS param groups for the MySQL 5.7 engine family. (#3695) 9 years ago
Gilles Gagniard 8231a1afc8 better error message if libcloud is not recent enough to use gce subnetworks 9 years ago
Lloyd Hazlett 3cf40d9596 Add path type to argument_spec where applicable (#3040) 9 years ago
Matt Martz 1d87213de1 2 Module fixes (#3611)
* Fix syntax error in azure_rm_virtualmachine.py

* Allow rhn_register to fail gracefully when rhn-client-tools is not installed
9 years ago
Toshio Kuratomi 521370459c Py3 exclude list (#3698)
* Fix a few modules to pass syntax checks under python3

* Move from a whitelist of modules to check for python3 compat to a blacklist
9 years ago
Cheuk Lam d3097bf580 Added support for accepting extra config options in vm reconfiguration. (#3327) 9 years ago
chouseknecht a8bf8260aa
Fixed the URL in description. It's now valid Yaml. 9 years ago
chouseknecht 3d43ccae1e
Remove the U(). 9 years ago
Gilles Gagniard c859a9d339 fix documentation to reflect subnetwork option is new in ansible 2.2 9 years ago
Gilles Gagniard 2a008998fd Initial support for specifying in which subnetwork a gce instance should be created. This is required for non-legacy networks. 9 years ago
chouseknecht fe45ec9d9e
Uppercase 9 years ago
chouseknecht 10ee35ff26
Make the new bits a NOTE 9 years ago
chouseknecht 1825a73c40
Where to get the full docker picture. 9 years ago
Kaz Cheng f87f0ec277 Allow create_iam_role to return an additional value of role_result and (#2418)
instance_profile_result, in addition to the existing role list and change value
9 years ago
Shubham 64b104ac37 remove module argument, fix #3682 (#3683) 9 years ago
Matt Martz 9b6a7eb4f9 Revert "Fix doc strings spacing."
This reverts commit 127d518011.
9 years ago
chouseknecht 127d518011
Fix doc strings spacing. 9 years ago