Commit Graph

5033 Commits (f9d9c1b6d7d8326142ec1c4e6db46fb4e9e808ab)
 

Author SHA1 Message Date
Patrik Lundin f9d9c1b6d7 Multiple fixes for OpenBSD rcctl handling.
* Use the newly added 'default' argument to know if the default flags are set
  or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.

Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
10 years ago
Patrik Lundin e463400412 Simplify self.arguments logic.
Strange logic pointed out by @jarmani, thanks!
10 years ago
Patrik Lundin 924cf20cf8 Depend more on rcctl if it is present.
* Make the module support enable/disable of special services like pf via rcctl.
  Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
  match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
  is available.
10 years ago
Patrik Lundin 5f37624eb4 Tweak error checking for "enabled" code.
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
  trying to handle the different meanings of rc after running "status",
  just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
  turn up on stderr.
10 years ago
Patrik Lundin c6dd88c1d1 Fail if "rcctl status" writes to stderr. 10 years ago
Patrik Lundin 1a8cdb5e3e Check rc and print error message if any.
It is probably good to use stdout before printing a generic error
message as well.
10 years ago
Patrik Lundin c46e030100 Make "enabled" code aware of --check mode. 10 years ago
Jonathan Armani 1b97390765 Add enable / disable of services for OpenBSD if rcctl is present 10 years ago
James Cammarata cb69744bce Adding file doc fragment to those modules in files/ missing it 10 years ago
Michael DeHaan 1c2995d71f Merge pull request #77 from major/suggest-selinux-enforcing
Updating SELinux example doc in lininefile module
10 years ago
Michael DeHaan 797dc9d09a Merge pull request #87 from offby1/devel
Tweak docs to mention `replace`
10 years ago
Eric Hanchrow cc0a38d268 Tweak docs to mention `replace` 10 years ago
Major Hayden 6d697780f9 Updating SELinux example doc in lininefile module
Encouraging users to use this Ansible module to enable SELinux seems
like a better idea. It also warms Dan Walsh's heart.

Signed-off-by: Major Hayden <major@mhtx.net>
10 years ago
Michael DeHaan db5668b84c Update README.md 10 years ago
Michael DeHaan 617a52b20d Fix filename error. 10 years ago
Michael DeHaan 385a037cd6 package files 10 years ago
Michael DeHaan c8e1a2077e file extensions! 10 years ago
Michael DeHaan 417309a626 Restructuring. 10 years ago
Michael DeHaan 8cdea3edf0 Core/extras split WIP. 10 years ago
Michael DeHaan 7e94a05dd6 Core/Extras splitting WIP. 10 years ago
Michael DeHaan dc8540c755 Not core. 10 years ago
Michael DeHaan 1e47a969b8 Fix typo in README filename 10 years ago
Michael DeHaan 73123b69fa Move modules into subdirectory. 10 years ago
Michael DeHaan b2b5cc032c Add basic top level files. 10 years ago
James Cammarata a099a3c7f5 Merge branch 'admiller/async_resume' of https://github.com/maxamillion/ansible into maxamillion-admiller/async_resume 10 years ago
James Cammarata 1ef592ff00 Push the expanduser call on the source down to slurp rather than fetch
Also moves the calculation of the destination file name until after
the slurp of the file contents, since the source as returned by slurp
may now be different, so we want to use that expanded path locally.

Fixes #8942
10 years ago
James Cammarata 61f6a70401 Skip null id route tables when adding/deleting them in ec2_vpc
Fixes #8552
10 years ago
Steven Ringo bcb78335cf Expand description for ec2_facts module 10 years ago
James Cammarata dea00c767b Merge branch 'dmage-devel' into devel 10 years ago
James Cammarata bb8bac490a Merge branch 'devel' of https://github.com/dmage/ansible into dmage-devel 10 years ago
Toshio Kuratomi 8b81062be0 The fix for gh-7284 causes problems for initscripts which have the
standards compliant return codes but return a verbose error message via
stdout.  Limit the times when we invoke the heuristic to attempt to work
around this.
10 years ago
Toshio Kuratomi 724b484577 Merge pull request #9084 from mscherer/fix9704/fix_service
Fix #9704, correctly set changed as false when nothing is done
10 years ago
Michael DeHaan 062cc9bd04 Merge pull request #9082 from mscherer/fix9080/file_not_working_py24
Make file module work on python 2.4, fix #9080
10 years ago
Michael Scherer 7420a450a5 Fix indentation and bug #8895 10 years ago
Michael Scherer c9a0a7ae4b Fix #9704, correctly set changed as false when nothing is done 10 years ago
Michael Scherer d15931f15a Make file module work on python 2.4, fix #9080
Python 2.4 do not support "except ... as ..." construct, so
revert back to the older syntax.
10 years ago
James Cammarata 0d0576a97f Add note on ec2_lc regarding immutability of configs once created
Fixes #8927
10 years ago
Toshio Kuratomi 74e466557d Merge pull request #9060 from jamespharaoh/apt-lang
add LANG=C to apt module so the string matches on the output always matc...
10 years ago
Toshio Kuratomi 7b100dd389 Be more specific in checking if a job restarted successfully.
Fixes: #9056
10 years ago
Toshio Kuratomi 36083c3b90 Failure to enable a service now fails the task
Fixes: 8855
10 years ago
James Pharaoh 27ccd01db4 add LANG=C to apt module so the string matches on the output always match 10 years ago
James Cammarata d5546d7a0a Merge pull request #9052 from EvanDotPro/docs/fix-rax-public-key-example
Update rax root pubkey example
10 years ago
Evan Coury 54a979ddd3 Update rax root pubkey example
The example was showing how to use the `files` option to pass in a local file as an authorized public key for root. While this works, it's a bit sloppy, given that there's a specific option, `key_name` which will use one of your public keys on your rackspace account and add it as an authorized key for root. In our case, one of our admins didn't notice the `key_name` option because they scrolled straight to the example and saw the `files` strategy.

I propose that the example still shows `files`, but not using a root public key as an example, and instead also demonstrate the `key_name` option so that it's clear from the example how to get the initial root public key deployed.
10 years ago
Sam Pierson 3f8e45f864 [#9048] convert Route53 TTL to integer before comparison
boto/Route53 are returning TTL as a string.
The route53 module is comparing it with an integer and therfore thinks the DNS entry has always changed.
10 years ago
James Cammarata 633f86d30a Allow filtering by availability zone for exact_count with ec2
Fixes #8863
10 years ago
Toshio Kuratomi a50258d26a remove debugging that was causing failure 10 years ago
Toshio Kuratomi 2e16bd3a44 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
Toshio Kuratomi 104401805b Revert "Refactor the Linux service_enable() method" needs some debugging
This reverts commit e294e31fd3.
10 years ago
Toshio Kuratomi c362902f50 Refactor the Linux service_enable() method
* Fix check_mode for initctl systems

Fixes #9009
10 years ago
James Cammarata 0257cb1201 Allow git repo queries without a clone when update=no
This commit also makes the dest parameter optional, unless update=yes
(the default), since it is not required for queries without an update.

Fixes #8630
10 years ago