ansible

Commit Graph

Author	SHA1	Message	Date
Sam Doran	5260527c4a	Change default file permissions so they are not world readable (#70221 ) * Change default file permissions so they are not world readable CVE-2020-1736 Set the default permissions for files we create with atomic_move() to 0o0660. Track which files we create that did not exist and warn if the module supports 'mode' and it was not specified and the module did not call set_mode_if_different(). This allows the user to take action and specify a mode rather than using the defaults. A code audit is needed to find all instances of modules that call atomic_move() but do not call set_mode_if_different(). The findings need to be documented in a changelog since we are not warning. Warning in those instances would be frustrating to the user since they have no way to change the module code. - use a set for storing list of created files - just check the argument spac and params rather than using another property - improve the warning message to include the default permissions	4 years ago
Brian Coca	ac509d489b	Revert "stricter permissions on atomic_move when creating new file (#68970 )" (#68983 ) This reverts commit `566f2467f6`.	5 years ago
Brian Coca	566f2467f6	stricter permissions on atomic_move when creating new file (#68970 ) fixes #67794 updated some tests that expected previous defaults CVE-2020-1736	5 years ago
Tim Rupp	46214c9ef4	Replaces #16690 (#58369 ) Adding integration tests for testing the 'mode' arg of the apt_repository module	5 years ago
Jordan Borean	bbad033a5e	ansible-test: apt cleanup and futher 18.04 fixes (#50906 )	6 years ago
Julien Vey	26d9de6f3e	apt_repository: check attribute repo for None value (#36944 )	7 years ago
Matt Martz	4fe08441be	Deprecate tests used as filters (#32361 ) * Warn on tests used as filters * Update docs, add aliases for tests that fit more gramatically with test syntax * Fix rst formatting * Add successful filter, alias of success * Remove renamed_deprecation, it was overkill * Make directory alias for is_dir * Update tests to use proper jinja test syntax * Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax * Add conversion script, porting guide updates, and changelog updates * Update newly added uses of tests as filters * No underscore variable * Convert recent tests as filter changes to win_stat * Fix some changes related to rebasing a few integration tests * Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name * Add test for tests_as_filters_warning * Update tests as filters in newly added/modified tests * Address recent changes to several integration tests * Address recent changes in cs_vpc	7 years ago
Adrien Vergé	0e834fc9e4	Fix cosmetic problems in YAML source This change corrects problems reported by the `yamllint` linter. Since key duplication problems were removed in `4d48711`, this commit mainly fixes trailing spaces and extra empty lines at beginning/end of files.	8 years ago
Matt Clay	75e4645ee7	Migrate Linux CI roles to test targets. (#17997 )	8 years ago

9 Commits (f9c3c6cba6f74f9c50c023389bf8f37a8534ada1)