Commit Graph

26007 Commits (f8df9e12d46a14afa2f97b7904a35f2e48c53632)
 

Author SHA1 Message Date
Siva Popuri 01847f7bfc Ansible module for managing server snapshots in Centurylink Cloud 8 years ago
Toshio Kuratomi 60c495f18c Fix win_acl docs build 8 years ago
Toshio Kuratomi 0111b616d7 Fix docs to build 8 years ago
Linus Unnebäck ebfb8bc7cf iptables: add note about rules 8 years ago
Linus Unnebäck 8d93747275 iptables: expand rule options 8 years ago
Linus Unnebäck 1790722dd4 module: system/iptables 8 years ago
Phil 0524904dda fixes examples in docs to use updated param name 8 years ago
Phil 43074a736d changes param src to path, and updates docs accordingly 8 years ago
Phil 00a4ec5e3b updates user search verification for local/domain - Thanks to @trondhindenes for implementing this strategy - also updated documentation 8 years ago
Phil 9ad30acd96 changes check for src 8 years ago
Phil 6abfcffc70 check if the rule exists or not before allow/deny rules are added/removed, and fixes where result changed would be true on all executions. 8 years ago
schwartzmx 25a3793a49 inital commit win_acl 8 years ago
Brian Coca a65647efee added version_added and fixed some doc parsing issues 8 years ago
Jeremy Wells c8e0f3a552 Add consul http checks to consul.py
Consul module already supports ttl and script checks. This commit adds
http checks.
8 years ago
Steve fea8995df1 Fix bug #1105 - incorrect use of lstrip()
Remove only the literal prefix '/dev/mapper/' - not any of the characters
in '/dev/mapper/' - from the name param of the crypttab module.
8 years ago
Brian Coca d530764c49 fixed option in examples 8 years ago
Charles Paul 3913de1c43 reference instance_id in docs, fixes for calls to fail_json 8 years ago
Trond Hindenes 15ac8e9141 turned out strict msi code checking 8 years ago
Nicolas Landais 4fc4030c58 Adding fix to get around bug found with the New-Webstire command when running playbook on a vanilla machine. 8 years ago
Dreamcat4 40a1bd1962 fix: Add 'enable:' flag for enabling existing rules which are disabled by default.
This is a very much needed flag. To turn on/off existing firewall rules. And like the recent fix of the 'Profile' key, the netsh cmd prints 'Enabled' in the textual output. (at least on win10 it does). So again a similar small code added for the necessary exception handling when the difference check happens.

Please merge / push upstream like the other fixes. Many thanks. This is the last fix I have put together for this patch set. So I will raise my PR now.

But if you want to fix more bugs, it seems there may be others. In terms of the control code. Sometimes it will delete a rule under 'force' condition (when found difference) - but instead it is supposed to just modify the existing rule. Some weird behaviour regarding that. The other problem is that ansible does not return the error text printed by 'netsh' cmd verbatim... but it should as that makes debugging these errors a *lot* easier.
8 years ago
Dreamcat4 e0da4a3362 fix: update documentation with new module name "win_firewall_rule" 8 years ago
Dreamcat4 7188ae4fe1 fix: The names of firewall profiles are different on win10 & win2008r2
Hi again. This commit removes a small portion of your script's own internal error checking. In specific: for the value of the profile: key. This is essential to avoid errors on other verisons of the windows operating system which are not win2008r2 (your version).

For example: on win10 (and most likely win8x too), the names of the profiles don't include the values 'current' and 'all'. But instead the values are 'Public' 'Private' 'Domain' and 'Any. But in addition, there are also certain combinatorial values, such as profile=Public,Private etc. Which is too many to error check yourself.

Yet removing the error checking here should not cause any ill effects however: since the netsh advfirewall ... cmds themselves to add / remove / modify actually to their own error checking of the profile=value. So when the cmd is run, it will error out itself with an appropriate / informative error msg. No harm done.

Therefore please remove the highlighed portions from your own script. It is essential for interoperability with win10 and win8x. Many thanks.
8 years ago
Dreamcat4 f64e438150 fix: win10 - Add exception handling for 'Profiles:' textual output key name mismatch.
In win10 (and pribably win8x also):

The output of 'show rule' key includes the line "Profiles:<TAB>Public,Private".
Yet your script expects the key name printed out to be "Profile:<TAB>value".

This commit added the necessary exception handling to avoid flagging 'different=true' under the false circumstance. The key name to SET a firewall rule is still "profile=" and not "profiles=".

There is coming up another commit to fix the value handling for win10/win8. Which is another (different) error with the profile: key.
8 years ago
Dreamcat4 b9dd3568f3 fix: fw rule names must always be quoted, to permit spaces ' ' and brackets '()'
Without this fix, the 'netsh' command gets name=Firewall Rule Name instead of name="Firewall Rule Name". Thus causing all sorts of havoc. Basic shell quoting rules seems to apply to Windows Powershell too. This is very much needed as many of windows 10's default firewall rules contain spaces and brackets () characters.
8 years ago
Ramon de la Fuente 1d09eaf6d0 updated the examples to the new Slack API 8 years ago
Ramon de la Fuente 918012a42f module guidelines compliency 8 years ago
Stefan Berggren aeb1090542 Add attachments support to slack module. 8 years ago
Kevin b43329b6a0 Remove `homebrew-` prefix when checking if repo has already been tapped
See: https://github.com/Homebrew/homebrew/blob/master/Library/Homebrew/cmd/tap.rb

Example:

```
$ brew tap neovim/homebrew-neovim
$ brew tap
neovim/neovim
...
```
8 years ago
Luis Rodriguez adedc7ef3f Fix bug #1067 8 years ago
Brian Coca 1426c3ba02 added missing GPL licences fixes #508 8 years ago
Michael Perzel f84dc8fd5d Improve example wide_ip variable 8 years ago
Michael Perzel 9c8891740c Wrap main() in conditional 8 years ago
Michael Perzel 21425f36ef Update bigip_api method to use variable name server 8 years ago
Michael Perzel 6681a5b386 Style updates 8 years ago
Michael Perzel ca0d4aad52 Module for managing F5 wide ip 8 years ago
Toby Fleming 3293fe7231 Homebrew: Allow colons, direct check for outdated formula 8 years ago
Indrajit Raychaudhuri e115f62a2d homebrew: Also add 'formula' as alias for 'name' and reformat 8 years ago
Indrajit Raychaudhuri c397dfe9ed homebrew: Improve 'argument_spec' handling
- Remove choice list for boolean values in argument_spec and make it
  more consistent with core modules
- Add 'package' alias and support for list type for 'name' parameter
- Added self as maintainer
8 years ago
jhawkesworth@users.noreply.github.com 17d1c8916d Document module limitations to resolve https://github.com/ansible/ansible-modules-extras/issues/908 8 years ago
Matt Martz 803d9695e0 sys.exit removal for system/capabilities.py 8 years ago
Matt Martz a87cf4967e sys.exit removal for notification/mail.py 8 years ago
Matt Martz e99a202ac5 sys.exit removal for cloud/google/gce_img.py and cloud/google/gce_tag.py 8 years ago
Matt Martz 7cb0d86c27 sys.exit removal for cloud/misc/ovirt.py 8 years ago
Matt Martz 950c951e06 sys.exit removal for cloud/xenserver_facts.py 8 years ago
James Cammarata 766ad0ace2 Updating version for 2.0.0-0.3.beta1 release 8 years ago
Matt Martz 9c4fae7e3f Fix open_iscsi EXAMPLES section 8 years ago
Matt Martz e2872a984a Switch from old style replacer code to new style for ansible.module_utils.basic 8 years ago
Matt Martz 793f0e0fd1 Fix interpreter line in a few vmware modules 8 years ago
Rick Mendes 7bb6a5aa90 added missing license 8 years ago
Charles Paul 0acfd95747 allow floating point input for size vale 8 years ago