24386 Commits (f8d2be407db701535c3bf9102baec377dcb4b941)

 

All Branches   

Search

Author	SHA1	Message	Date
Ryan Brown	6ae4e50e47	Fix failure when powering on/off EC2 instances by tag only. (#4767) ... If you apply `wait=yes` and use `instance_tags` as your filter for stopping/starting EC2 instances, this stack trace happens: ``` An exception occurred during task execution. The full traceback is: │~ Traceback (most recent call last): │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module> │~ main() │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main │~ (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags) │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances │~ if len(matched_instances) < len(instance_ids): │~ TypeError: object of type 'NoneType' has no len() │~ │~ fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~ ack (most recent call last):\n File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n main()\n File \"/tmp/│~ ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n (changed, instance_dict_array, new_instance_ids) = startstop_instances│~ (module, ec2, instance_ids, state, instance_tags)\n File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~ nces\n if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~ MODULE FAILURE", "parsed": false} ``` That's because the `instance_ids` variable is None if not supplied in the task. That means the instances that result from the instance_tags query aren't going to be included in the wait loop. To fix this, a list needs to be kept of instances with matching tags and that list needs to be added to `instance_ids` before the wait loop.	8 years ago
Dag Wieers	976d876e55	Ensure unicode characters in zip-compressed filenames work correctly (#4702) ... * Ensure unicode characters in zip-compressed filenames work correctly Another corner-case we are fixing hoping it doesn't break anything else. This fixes: - The correct encoding of unicode paths internally (so the filenames we scrape from the output and is returned by zipfile match) - Disable LANG=C for the unzip command (because it breaks the unicode output, unlike on gtar) * Fix for python3 and other suggestions from @abadger	8 years ago
Peter Sprygada	53bcf18eab	minor updates to junos_package module for 2.2 (#4761) ... * replaces get_module() with NetworkModule() * removes old call to package_version()	8 years ago
Peter Sprygada	09b8e220ca	update junos_facts module to remove get_module() factory function (#4760) ... Replaces get_module() with NetworkModule instance	8 years ago
Peter Sprygada	290a4b5fac	adds path kwarg when difference() is called from iosxr_config ... Adds the path kwarg to handle use cases with exact and strict matching	8 years ago
Matt Clay	e8f70f25df	Python 3 fixes for apt_* modules. (#4754)	8 years ago
Peter Sprygada	d339004437	minor bug fix to pass path to difference() in ios_config ... The ios_config module needs to pass the path kwarg to difference when specifying match=exact or strict.	8 years ago
afunix	f2c324facc	Updated get_url module to process FTP results correctly [#3661] (#4601)	8 years ago
Peter Sprygada	6cca2b06fe	fixes bug where nxos_config wasn't handling checkpoints correctly	8 years ago
Abhijit Menon-Sen	841ceb808d	Fix spot instance creation by ignoring instance_initiated_shutdown_behavior (#4741) ... Before this, all spot instance requests would fail because the code _always_ called module.fail_json when the parameter was set (which it always was, because the module parameter's default was set to 'stop'). As the comment said, this parameter doesn't make sense for spot instances at all, so the error message was also misleading.	8 years ago
Florian Dambrine	2adc325ef6	Fix ec2 module source_dest_check when running on non VPC instances (EC2 Classic) (#3243)	8 years ago
Peter Sprygada	d6e16ded3f	fix bug in ios_template when include_defaults is set to true ... Module was ignoring include_defaults argument. This fixes the issue such that the correct configuration is returned	8 years ago
Peter Sprygada	8a87d7ff11	adds path kwarg when performing config diff checks in ios_config	8 years ago
mlewe	afa9d30717	Fixes ansible/ansible#15922 (#3793)	8 years ago
Matt Ferrante	d88f5f6808	Properly support tag updates on CloudFormation stack-update actions (#3638)	8 years ago
@skg_net	eae69a154f	dnos10_template module	8 years ago
David J Peacock	14fb0e4136	description expanded for 112, AKA VRRP protocol) (#4645) ... * description expanded for 112, AKA VRRP protocol) * corrected syntax for description for IP protocols	8 years ago
Brian Coca	a42cb96b75	added backup_file to module returns (#4723) ... fixes #14502 also cleaned up some unused stuff and fixed imports	8 years ago
Peter Sprygada	bfdc5098cb	minor bug fixes in eos_template ... * fixes issue where configuration was not being loaded (#4704) * fixes issue where defaults were not included when argument was set to True tested on EOS 4.15.4F	8 years ago
Matt Davis	009ebf619b	fix async_wrapper start suspended race (#4718) ... Main thread in started-suspended process may not be immediately resumable on slow targets- poll for proper state for awhile before attempting resume	8 years ago
Matt Davis	6099e6d19e	Windows async module support (#4710) ... Powershell impls of async_wrapper, async_status- associated tests and async action changes are in https://github.com/ansible/ansible/pull/17400.	8 years ago
Brian Coca	909e62b25b	updated include_role docs	8 years ago
Dag Wieers	5995097e61	Support DOS file attributes (e.g. archive-bit or hidden-bit) (#4705) ... This fixes #4554	8 years ago
GGabriele	bc7b093089	Removed newline	8 years ago
GGabriele	dfa9904599	Added missing fullstop	8 years ago
Peter Sprygada	db49e1e436	fixes issue where the configobjs are not deserialized to a list ... When the configuration is compared and the results deserialized, the dumps() function returns a string. This cohereces the return to a list in case before and/or after needs to be applied fixes 4707	8 years ago
GGabriele	87b839e1f8	Adding missing fullstop	8 years ago
GGabriele	d2d1b18ef4	Fixed param value format in docstring	8 years ago
GGabriele	745b504aa1	Fixed module structure and added one new param	8 years ago
GGabriele	a71b84853c	Fixed config function	8 years ago
GGabriele	f577f46ccf	fix imports	8 years ago
Peter Sprygada	8eab599ade	removes state argument from ops_config module ... this removes the state argument from ops_config. The state argument should not have been there	8 years ago
Peter Sprygada	c071273fbf	removes argument from vyos_config module ... The state argument should not be in vyos_config. This commit removes the state argument	8 years ago
Peter Sprygada	807974f515	updates nxos_config to remove state argument ... The state argument should not be in the nxos_config module. This change removes the state argument for this release	8 years ago
Peter Sprygada	c38a90a2e9	removes state argument from ios_config ... The state argument should not be in ios_config. This change removes the state argument	8 years ago
Peter Sprygada	51613d4307	roll up of minor fixes in eos_config module ... * fixes save argument to be type bool * now properly sets the changed returned flag based on diff * updates docstring RETURNS to add backup_path * removes unneeded state argument tested on EOS 4.15.4F	8 years ago
GGabriele	7010a66638	Removed tabs	8 years ago
Peter Sprygada	7a234fc7cc	update junos_netconf module ... Updates the junos_netconf module with changes to load the NetworkModule instead of the get_module factory method. This update is part of the 2.2 refactor of network modules	8 years ago
Peter Sprygada	f5e62a0611	update junos_template module ... This updates the junos_template module implementing the changes for Ansible 2.2	8 years ago
GGabriele	174ffde2e9	Adding nxos_igmp_interface	8 years ago
GGabriele	93d816a183	Adding nxos_igmp	8 years ago
Matt Clay	1f6e3326db	Python 3 fixes for async_wrapper and async_status. (#4671)	8 years ago
GGabriele	693fc690d7	nxos_vrf_interface support for 2.1 and 2.2	8 years ago
Peter Sprygada	213c8e5a81	update junos_config module ... * adds src argument to load configuration from disk * adds src_format to set the source file format * adds update argument with choices merge or replace * deprecates the replace argument in favor of update=replace	8 years ago
GGabriele	0303c813c8	Updating nxos_vrf	8 years ago
GGabriele	7560c6dac2	nxos_vlan support 2.1 and 2.2	8 years ago
Matt Clay	cb30558a41	Make async_wrapper ignore '_' as an argsfile. (#4678) ... This provides support for passing additional positional parameters to async_wrapper. Additional parameters will be used by the upcoming async support for Windows.	8 years ago
GGabriele	7391b5ba63	nxos_ping support for 2.1 and 2.2	8 years ago
GGabriele	85e65a7873	nxos_ip_interface support for 2.1 and 2.2	8 years ago
GGabriele	631ee66ed9	Adding nxos_reboot	8 years ago