Commit Graph

960 Commits (f7e286cf345a97a9ca6b8587cc16fbc901047dc6)

Author SHA1 Message Date
Jayson Vantuyl ad6373430b add apt_key module
Pretty straightforward.  Give it a URL with an exported GPG key for signing an
Apt repository.  It downloads it and will install it using apt-key.  It's even
smart enough to tell if it's already there (i.e. actually tells you if it
changed or not).
12 years ago
root 471ee0c90d get_service_status() is now using self.service_control() to check status
Fixes a bug where init-scripts were not used
12 years ago
Stephen Fromm 4eaee3df0a Various cleanup to run_command
* Rename fail_on_rc_non_zero to check_rc, much more succinct.
* Simplify method defintion
* Fix command module and drop shell=shell option; whether to use
  shell is determined by if args is a list.
12 years ago
Stephen Fromm 3fb21a5281 Update modules to use run_command in module_common.py
This updates apt, apt_repository, command, cron, easy_install, facter,
fireball, git, group, mount, ohai, pip, service, setup, subversion,
supervisorctl, svr4pkg, user, and yum to take advantage of run_command
in module_common.py.
12 years ago
Daniel Hokka Zakrisson a19a13ffa7 Add check for multiple keys in one invocation 12 years ago
Gert Goet f4dcb33ccc Prevent permission denied when cloning
Without read permission to the current working directory, git-clone will
fail:
root@host:~$ sudo -u git -H git clone \
  git://github.com/ansible/ansible.git /home/git/ansible
fatal: Could not change back to '/root': Permission denied

This commit ensures that the working directory is changed to the
parent-folder of the destination before doing the clone.
12 years ago
Michael DeHaan 1cbc9569b3 Merge pull request #1853 from jure/more_info_from_ec2
EC2 module should report back the public_dns_name too
12 years ago
Daniel Hokka Zakrisson 060266e291 Python 2.4 fixes for modules 12 years ago
Daniel Hokka Zakrisson 3bc6228b97 Handle unreadable /proc/xen/capabilities
Fixes #1854.
12 years ago
Jure Triglav 3f43ede70c Fix indentation 12 years ago
Jure Triglav 2ee05f0c96 EC2 module should report back the public_dns_name too. 12 years ago
Daniel Hokka Zakrisson b57b1f4cbe Correct name is login_user
Fixes #1848.
12 years ago
Daniel Hokka Zakrisson 4955587d8c Merge pull request #1798 from dagwieers/raw-executable
Allow to change executable (shell/interpreter) when using raw
12 years ago
Michael DeHaan 713ce4c0cf Merge pull request #1832 from legrostdg/devel
add encoding documentation in postgresql_db
12 years ago
Félix Sipma 0ba7cf58e9 add encoding documentation in postgresql_db 12 years ago
willthames 4e50478a05 Fix behaviour when file handles a path with tilde
Two problems here
* unchecked exception handling and erroneous assumption as to why
  an exception might fire
* although the file module expands the path, when using file_args
  the unexpanded path is passed.

Expected result: ~/path/to/file should work fine
Actual result: exception is because it doesn't find file with a message
about not being able to get the selinux context
12 years ago
Daniel Hokka Zakrisson 1fa83fa584 Merge pull request #1813 from legrostdg/devel
postgresql_db fails with owner containing a "-"
12 years ago
Félix Sipma 02f531c609 remove quotes in has_table_privilege and has_database_privilege 12 years ago
Daniel Hokka Zakrisson 451868630d Merge pull request #1817 from chrisberkhout/devel
git module documentation: removed incorrect use of term 'remote branch' ...
12 years ago
davixx 8efa62b0ea new module: sysctl to handle sysctl entry
sysctl now capable to search for sys entry into /sys if not under /proc/sys

module/sysctl rolling back to 0.5

write sysctl.conf safely, tempfile first, atomic replace after.
See comments in  https://github.com/ansible/ansible/pull/1810

Patch to replace .format with % () to handle python-2.4 ,
See also https://github.com/ansible/ansible/pull/1810

using name instead key for default arg name. key putted as alias.
also, val become an alias of value arg name.
See also : https://github.com/ansible/ansible/pull/1810
12 years ago
Félix Sipma 8a262c2b20 add documentation for "template" parameter in postgresql_db 12 years ago
Félix Sipma cd7fe9875c use double-quotes in postgresql commands (fix bug with "-") 12 years ago
willthames 411b2bf7d9 Added additional template variables
Added two additional template variables
* template_fullpath - absolute path to the template
* template_run_date - date that the template was rendered
Documented these additional variables in the module documentation
12 years ago
Chris Berkhout c01bc23f63 git module documentation: removed incorrect use of term 'remote branch' (should just be 'remote'). 12 years ago
Dag Wieers eb36ff45b9 Make script module use raw module so it does not require python 12 years ago
Dag Wieers 846161a1a4 Allow to change executable (shell/interpreter) when using raw
This patch adds an optional 'executable=' option to the raw command line to override the default shell (/bin/sh), much like the shell module does.
12 years ago
Michael DeHaan 3d3deb9797 Merge pull request #1795 from dagwieers/raw-enhanced
Add return code and error output to raw module
12 years ago
Dag Wieers 988db558b3 Add return code and error output to raw module
Since we use 'raw' heavily on equipment where 'command' and 'shell' are not (yet) working (and python may need to be installed first using raw) these improvements are necessary in order to write more complex scripts (with return code handling and separated stdout/stderr).

This change includes the following changes:

 - exec_command() now returns the return code of the command
 - _low_level_exec_command() now returns a dict, including 'rc', 'stdout' and 'stderr'
 - all users of the above interfaces have been improved to make use of the above changes
 - all connection plugins have been modified to return rc and stderr
 - fix the newline problem (stdout and stderr would have excess newlines)

In a future commit I intend to add assertions or error handling code to verify the return code in those places where it wasn't done. Since only the output was available, the return code was ignored, even though we expect them to be 0.
12 years ago
Jan-Piet Mens 85e0017a85 fix cron DOCUMENTATION 12 years ago
jkleint d732b25828 Clarify that lineinfile uses Python regexes. 12 years ago
Daniel Hokka Zakrisson eb57c9c430 Indicate the reboot option was added in 1.0
Fixes #1787.
12 years ago
Michael DeHaan 6fc6c37401 Merge pull request #1785 from TutoringAustralasia/devel
Add support for @reboot to cron module
12 years ago
Chelsea Robb 96e2805b31 Change check for date/time parts being set 12 years ago
Chelsea Robb 6a02e3d918 Added error message when reboot and extra params are passed, and added better boolean parsing on reboot 12 years ago
Chelsea Robb fc4ac70342 Add support for @reboot to cron module 12 years ago
Gregory Duchatelet 29f985aa2e do not conditionalize this for older Python, fix indentation, better use
of hash iteration.
12 years ago
Gregory Duchatelet e64de2ff88 Bugfix: in hosts with python-2.5, hash keys needs flatten string. 12 years ago
afterburn a6f01dcd6f version 1.0 eruption 12 years ago
afterburn 0bdd17ff3a updated description and examples 12 years ago
Daniel Hokka Zakrisson d4b1874d44 Merge pull request #1773 from jpmens/scriptdoc
fix and clarify 'script' docs
12 years ago
Jan-Piet Mens 4f8abd981a fix and clarify 'script' docs 12 years ago
Stephen Fromm ccca5fcd1c Ensure files created by authorized_key have correct selinux context
Three changes:
* Add set_default_selinux_context() to module_common that sets
  a file's context according to the defaults in the policy
* In atomic_replace(), set the default context for the file if
  selinux is enabled and the destination file does not exist.
* In authorized_key, set the default context when creating
  $HOME/.ssh and $HOME/.ssh/authorized_keys.  If these already
  exist, this won't touch them.
12 years ago
Michael DeHaan f2893b6418 Merge pull request #1746 from njharman/subversion
Subverion module improvements
12 years ago
Michael DeHaan 5d31e8d1fc Merge pull request #1752 from jpmens/mail2
mail module: add MIME attachments, port and addresses with phrases
12 years ago
Norman J. Harman Jr ddc0507f65 Passing in module instead of just fail_json per upstream request. 12 years ago
Michael DeHaan ea5d79a712 Merge pull request #1755 from lorin/patch-1
Fix ppa syntax in apt_repository module doc
12 years ago
Norman J. Harman Jr 19b84d0527 pip module improvements
- Do not silently ignore malformed pip requirements files.
- Properly reports changed when removing packages.
- "latest" i.e. --upgrade is *not* incompatible with requirements files.
- Less branchy, simpler logic.
- Removed pointless variable "initializations", Python doesn't need that.
  Other code simplifications.
- Fun fact; pip install is (kind of) case insensitive, pip freeze is not.
  So, 'sqlalchemy' will be reported as installed by install, but missing
  by freeze.

The perhaps controversial change and the one that led to finding /
fixing above issues...

Instead of adding command parameters 'index', and 'find', and 'mirrors',
and etc.  Added 'extra_args' which are passed onto pip.

The use case for --index-url is having a private pypi repo, like
http://pypi.python.org/pypi/localshop, to which you publish private
packages.  I'm sure most every pip option has a use case for someone.
extra_args handles all those. Can reserve ansible command parameters for
the most common.

Tested with pip 1.1.
12 years ago
Seth Vidal 165861dd2f if user has manually installed an intermediate version - don't ignore it: issue 1754 12 years ago
Jan-Piet Mens f9755ca36d mail module: add MIME attachments, port and addresses with phrases
Add HTML-escaping to code examples in rST tempate of module-formatter
 Add support for specifying port, addresses with phrases and attaching files
 Add support for custom headers and document version_added for new options
 X-Mailer header added :)
 protect empty address lists & attachment list, and add bcc
12 years ago
Lorin Hochstein f8821fa3d9 Fix ppa syntax in apt_repository module doc
The example for using a ppa had the wrong syntax.

Ironically, the correct syntax is illustrated in a comment on line 23.
12 years ago
Norman J. Harman Jr 2e6999dab9 Subverion module improvements
- Added username, password arguments.
  - Documented existing revision argument.
  - Corrected documentation/docstrings; removed git references, use svn
    nomenclature, etc.
  - Refactored duplicate code, redundant shell calls, filter abuse,
    inconsistent formating, etc.
  - Shell quoting so it doesn't break for one guy who has spaces in
    pathnames.
  - svn called with '--non-interactive' and '--no-auth-cache'.
12 years ago
Michael DeHaan 637883164e Merge pull request #1720 from bladypirat/devel
added support for scheduling downtime for all services on host
12 years ago
Alexandre Bourget 0b9cbcb270 supervisorctl: document the 'present' option 12 years ago
Dag Wieers ac2f396379 Fix "NameError: global name 'name' is not defined" exception 12 years ago
Daniel Hokka Zakrisson 11b64314df Select all fields from the user, as some of them are version-dependent 12 years ago
Stephen Fromm 1bcfdd94f3 Further refine remote branch tracking in b1ec6e8
Move operations that are dependant on a remote branch under a if
is_remote_branch() conditional.  While at it, remove assignment to cmd
string in same block that wasn't used when calling _run().
12 years ago
Stephen Fromm b1ec6e8163 Fix git module to update branch to latest when using version=<branch>
The git module would not pull in updates to a branch when
version=<branch>.  This updates that block to checkout the branch
and then do a git reset --hard <remote>/<branch>.  This
should now track updates to a branch.
12 years ago
Piotr Kweclich 9c20eb089b added support for scheduling downtime for all services on host 12 years ago
Stephen Fromm 5b7c8fcc38 Further tweak how to find pip in virtualenv on centos/redhat/fedora
In a virtualenv, pip is called just pip.  This fixes the pip module to
search for the virtualenv pip first before trying the pip-python and
python-pip variants.  Without this, pip module would not install to the
virtualenv when that parameter is provided.
12 years ago
Stephen Fromm e33e02950d Make use of mirrors in pip module configurable with use_mirrors option
Older versions of pip (anything less than 1.0?) do not support
--use-mirrors flag.  This makes it configurable.  Default is yes.
12 years ago
Daniel Hokka Zakrisson d5a456fbcf Merge pull request #1697 from bcoca/mint
Implements multiple interpreter overrides
12 years ago
Stephen Fromm d277953a53 Fix pip module to check if requirements already installed
This updates _is_package_installed() to accept a requirements file
as an argument.  This is used later in main() to check if python libs
specified in a requirements file are already installed.  I updated
main() to consolidate the handling of install/uninstall in a single
block.  This should help if someone wants to remove packages specified
by a requirements file.
12 years ago
Igor Galić 1ba5c5ae97 : doesn't work in this documentation. 12 years ago
Igor Galić e031054934 Fix subversion module's documentation
Let our users determine what they want to do with a given module.
Particularily when the mdoule doesn't pose any such restrictions.
12 years ago
Brian Coca 8ef2807305 removed env as per project policy
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
12 years ago
Jan-Piet Mens 910f1c042e ini_file: prohibit section name 'default'
allow update of default section
add blurb re template to create base file
12 years ago
Patrik Lundin d4af9e4c5c Use shlex for rc.conf parsing.
This makes the line parsing a lot more robust (and easier to read).
Code supplied by @dhozac, thanks!

Remove re import because this is not used anywhere.
12 years ago
Patrik Lundin fde00327b0 Rework "enabled" implementation for FreeBSD.
When trying to perform enabled=yes followed by enabled=no
against FreeBSD the module would die with the following error:
TypeError: sub() takes at most 4 arguments (5 given)

The target FreeBSD client (8.2) is running python 2.6.6. It seems the
extra 'flags' argument was added to re.sub() in 2.7.

In fixing this issue I have attempted to create a general atomic method
for modifying a rc.conf file. Hopefully this will make it easier to add
other rc based platorms. The strip/split magic was inspired by the user
module.
12 years ago
Daniel Hokka Zakrisson 4679d8d6e5 Remove references to non-existant variable rc 12 years ago
Daniel Hokka Zakrisson 1ec2a59073 Merge pull request #1676 from dagwieers/service-action-fix
The vars stop/start were intended as strings
12 years ago
Dag Wieers 18b797f096 The vars stop/start were intended as strings
This is a typo that was reported on IRC, because of this people got: "NameError: global name 'stop' is not defined".
12 years ago
Ton Kersten 7bba04b176 Corrected for fallthrough 12 years ago
Ton Kersten ee4fe9ff55 Added pip-python to the search for CentOS 6 compatibility 12 years ago
afterburn 4192516582 fixed 12 years ago
Michael DeHaan ac09b47ec4 Merge pull request #1668 from eest/refactor_service_module
Repost: Refactor service module to use subclasses like user module.
12 years ago
Patrik Lundin 5b7aa494b2 Refactor module to use subclasses like user module.
* Basically the moving parts from the original service module arranged in
  subclasses.
* General structure and helper methods comes from the user module.
* Less forgiving to unsupported platforms: it requires a subclass per platform.
  (This makes it easier to work on one platform without having to think about.
  what other platform might be affected in unexpected ways).
* Now has basic OpenBSD support.
* Solaris support needs to be added.

Thanks to @dhozac for general advice and Linux testing.
Thanks to @bcoca for clearing up some FreeBSD questions.
12 years ago
Michael DeHaan ce487a8544 Merge pull request #1658 from jpmens/docs_2
module_formatter: re-instate code
12 years ago
Michael DeHaan 3981c72957 Streamline code 12 years ago
Michael DeHaan 17020d6a75 Merge pull request #1656 from dagwieers/setup-virtualization
Implemented more virtualization types
12 years ago
Jan-Piet Mens 3b83295581 DOCUMENTATION: yum (moved version to added) 12 years ago
Jan-Piet Mens 068ef0e979 module_formatter: re-instate code 12 years ago
Dag Wieers e528826dba Implemented more virtualization types
I added all known virtualization types from the virt-what project. However, the few virt types that rely on cpuid information have not been implemented lacking native python cpuid access. (hyperv)
12 years ago
Jan-Piet Mens caf003c813 DOCUMENTATION strings 12 years ago
Dag Wieers 118ccc68c9 Make the default an empty string
Seems a bit strange I have to set a default in two locations.
12 years ago
Michael DeHaan 663a8fef3f chmod -x for all module files in source checkout 12 years ago
Daniel Hokka Zakrisson b95bcf1b9d Use single-quotes to contain SSH keys as they may contain double-quotes
Fixes #1624.
12 years ago
Michael DeHaan 99a0ebcad0 Merge pull request #1642 from dagwieers/service-options
Allow adding additional arguments to service module
12 years ago
Dag Wieers 3852b9918a Allow adding additional arguments to service module
Some services allow additional arguments to be provided on the command line. This patch makes it possible.
12 years ago
Michael DeHaan bb2e5e12b8 Merge pull request #1638 from jpmens/ec2_userdata
Support for user_data in ec2 module
12 years ago
Michael DeHaan c9aef42ac4 Merge pull request #1636 from romeotheriault/add-sunos-subclass-to-group-mod
Add sunos subclass to group mod
12 years ago
Michael DeHaan e13d67bbf1 Merge pull request #1635 from romeotheriault/classify-group-module
convert group module to be platform sub-classable
12 years ago
Jan-Piet Mens e4606d500c Support for user_data in ec2 module
fix
12 years ago
Romeo Theriault bb976ddfe0 add solaris subclass to group module 12 years ago
Romeo Theriault a52faa841f convert group module to be platform sub-classable 12 years ago
Fabian Arrotin 269a0779b4 Added a requirement on euca2ools external package and ec2 url example 12 years ago
Michael DeHaan 0ab3bd0034 Fix for #1577 (python 2.4 compliance for mysql_user), tested only for syntax, please exercise MySQL fans! 12 years ago
Michael DeHaan 096607eea4 Allow fireball to transfer binary files, fixup fireball docs, make fetch work with fireball. 12 years ago
Michael DeHaan 613539810e Missing import 12 years ago
Romeo Theriault ae36fb1dc6 minor linux user module fixups 12 years ago
Michael DeHaan 001e2e564f Merge pull request #1590 from romeotheriault/minor-freebsd-user-module-fixes
minor freebsd user fixes
12 years ago