2 Commits (f5f3ba7ab5d5e3b0d462ed985f8b9d614f28583f)

Author	SHA1	Message	Date
David Shrewsbury	ff47d3f766	Make sure collection is a list if a str is given (#69081) ... * Make sure collection is a list if a str is given * Call field validation early on collections Because we are doing work on modifying the collections value before it is actually validated, we can validate it ourselves early to make sure the user supplies either a string or list. Dicts are not valid. The new validation allows us to simplify the _ensure_default_collection() function. And since the field is now static, we no longer need to specify a default for it, which also allows us to simplify the function. Since the default is now removed, we can also remove the sanity/ignore.txt entry for collectionsearch.py. New unit tests are added (and the existing one modified) that allow us to make sure that we throw a parser error if a user specifies something other than a string or list for the collections value everywhere it can be specified. * Revert removing the collection default The default is actually used, so restore it. * Fix unit tests in test_helpers.py affected by early collection validation	5 years ago
David Shrewsbury	18a66e291d	Force collections to be static (#68723) ... * Force collections to be static Templating of collection names does not work at all. Force them to be static so that a warning is generated for the user. * Add collectionsearch unit test and fix for reviews New unit test validates the new _load_collections() code and moves the new check to the end of the method. * Change unit test to pytest * Adjust unit test to use capsys instead of monkeypatch * Fix pep8 error * Add changelog fragment Closes #68704	5 years ago