Commit Graph

17697 Commits (f5f2a2fac2b251ead20192cc46c719b33ee4bbad)

Author SHA1 Message Date
mzizzi 587ab33415 [cloud] Add jittered backoff+retries to CloudFormation module (#27907) 7 years ago
Trishna Guha 4070a22c5b Tested against IOS version (#28559)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Trishna Guha 340f52ae96 tested against eos version (#28556)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Laurent Ribot f92ae0831b Fix : get proper snapshotVersion when no classifier (#27102) (#27103) 7 years ago
mikedlr f93515adb9 [MERGE] AWS module Guidelines - multiple changes to bring up to date and start on aws.core (#26871)
* aws module Guidelines - rewrite - add AWS WG - add fail_json_aws - more modern
practices and fix some spelling

* aws module Guidelines - minor further changes with agressive fill to 99 width

* aws module Guidelines - formatting fix as per gundalow request

* aws module Guidelines - mark more keywords and code with backquotes

* AWS module guidelines - fixes from ryansb review + minor other changes
7 years ago
Muhammad Panji 8ed0222eff fix sts_session_token parameter example (#28549) 7 years ago
Lukas Bednar 8c5b9d99ed ovirt_disks: added option to export disk to glance (#27959)
* ovirt_disks: added option to export disk to glance

* ovirt_disks: Moving exporting to separate branch

* ovirt_disks: removed redundant line obtaining disk obj
7 years ago
Yaniv Kaul 6b18a23385 [oVirt] Fix ovirt_disk.py example of adding a disk (#28496)
It was missing a required field - the storage_domain field.
7 years ago
Tareq Alayan abc5910d86 cloud/ovirt: set mac pools via ovirt_clusters (#28120)
MAC pools are set per cluster since ovirt 4.1. Before that it was set
per data center.
7 years ago
Nijin Ashok 3c1ee57155 [cloud] ovirt: Add VM lease option to the ovirt_vms module (#27710)
Ovirt 4.1 is having new feature of VM lease for high availability.
The commit add support for configuring this in ovirt_vms module.
7 years ago
maorlipchuk 07feec30d3 [oVirt] Update/Add functionalities for import storage domain (#26568)
* ovirt_templates: Update the argument spec of templates.

Add id of template since it is needed for register.

* ovirt_vms: Register unregistered VM.

Use register of VM with id instead of name since an
unregitered entity can be registered also without name attribute.

* ovirt_hosts: Add iscsidiscover to ovirt_hosts

Adding functionality of iscsidiscover to be used to discover iscsi
targets.

* ovirt_storage_domains: Add support for import block storage domain.

* Add functionality of partial import to unregistered VMs.

* Add functionality of partial import to unregistered Templates.

* ovirt_hosts: Add iscsilogin to ovirt hosts.

Add functionality of iscsi login to ovirt hosts to be used to connect to
iscsi targets and to be able to import iSCSI storage domain eventually.

* Add ovirt_storage_templates_facts

Adding fact module for storage templates.
The module should help with registering unregistered templates.

* Add ovirt_storage_vms_facts

Adding fact module for storage VMs.
The module should help with registering unregistered VMs.
7 years ago
Ryan S. Brown 2f3d9566f9 Remove exec bit on elb_application_lb module 7 years ago
René Moser fbcf6e23af yum: fix state=latest (#28547) 7 years ago
Jordan Borean 4382216e10 win_copy: changes that were missed (#28533) 7 years ago
Jordan Borean e631676546 fixed up win_robocopy return values (#28538)
* fixed up win_robocopy return values

* reduced lin size for validator
7 years ago
Sloane Hertel a48e0b5101 New Module to manage AWS direct connect link aggregation groups (#27250)
* Add module_utils/aws/direct_connect.py for frequently used functions

* new AWS Direct Connect link aggregation group module with tests and placebo recordings

* remove extra argument

* Remove use of undefined var

* Fix param name for extra exception codes for AWSRetry to use.

* Fix undefined var and line length and metadata version number

* Fix copyright headers
7 years ago
Eduard Iskandarov fe21dd272d Kubernetes PATCH operation (#19428)
* add patch_operation parameter for kubernetes module

* Fix test errors
7 years ago
Trishna Guha 4271f6e5e6 fix aggregate doc example (#28528)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Trishna Guha c2e41bf1ef remove net_command (#28525)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
7 years ago
Martin Krizek 711ae03845 yum: fix reporting group changes in check_mode (#28331) 7 years ago
Felipe Garcia Bulsoni 84005498bc Support Fibre Channel over Ethernet resource of HPE OneView (#28359)
* Added new oneview_fcoe_network module and unit tests

* Fixing metadata issues and importing unittest from ansible.compat.tests

* Fixing shebang and adding correct copyright header

* Renamed remote_management/hpe to remote_management/oneview

* Updated documentation and default state according to review comments

- Added present as the default state
- Added delegate_to: localhost in all examples
- Changed config path from a variable to illustrate a location
- Other documentation fixes
7 years ago
Martin Krizek c59f3f841e yum: remove duplicite code introduced in d1fa210be (#28511) 7 years ago
Sloane Hertel cbb94a75fe Enable deleting IAM users with associated MFA devices. (#27288)
Refactore delete_user() since most of the heavy lifting was being done in the exception handling, which is not at all necessary and resulted in changed=False being shown after changes were successfully made.
7 years ago
Sloane Hertel 7551e8c921 AWSRetry: allow retrying on additional ClientError exceptions (#28483)
* Added the ability to extend the exception list in CloudRetry

* AWSRetry boto and boto compatible

* Updated tests to reflect boto/boto3

* Added boto to shippable requirements

* Have base_class and added_exceptions default to None in CloudRetry

AWSRetry - only retry on boto3 exceptions and remove boto requirement from tests

* Make requested changes.
7 years ago
Jordan Borean 9b7dbc78c3 win_wait_for: added module (#26556)
* win_wait_for: added module

* Increased timeout on async task

* added more debug messages for test debug

* revert to using win_shell instead of win_command

* rebased from master and updated copyright string

* Updated metadata version

* Capitalised start of short_description

* disabled win_wait_for tests until async issues are solved
7 years ago
Guido Günther 398f643c58 Check existence of SSL certs in Foreman callback (#25796)
* Fix typo

* foreman callback: check existence off SSL certs

This leads to confusing error messages later on otherwise.
7 years ago
Nathaniel Case e1def05ba2 fix networking *_command check_mode (#28407)
* Fix check_mode in nxos_command

* Fix check_mode for ios_command

* fix check_mode for iosxr_command

* Fix check_mode in vyos_command

* Fix check_mode in eos_command

* Fix check_mode in junos_config
7 years ago
Nathaniel Case 96abfde189 Fix idempotence for nxos_vrf_af (#28419) 7 years ago
Yanis Guenane f7f3f4b62c crypto: Add new module openssl_certificate (#28263)
This commit aims to add the openssl_certificate module.

This module allows a user to manage openssl certificates.
This module implement the notion of backend provider, making this module
extensible to anyone wish as long as a provider is coded for it.

The current three providers are the following:

  * selfsigned: Allows a user to self signed a certificate
  * acme: Allow a user to generate acme-based CA challenges certificate.
          (As of this writing this targets letsencrypt)
  * assertonly: Allow a user to assert the characteristic of her SSL
                certificate

Co-Authored-By: Markus Teufelberger <mteufelberger+ansible@mgit.at>
7 years ago
Rastislav Barlik f0a6f1637b Update xattr.py (#28458)
Fix wrong default value in documentation
7 years ago
Simon Dodsley 1fe71eacab Fix typo created in PR28485 (#28509) 7 years ago
Sloane Hertel f7e67dc3b1 Rename s3 module to aws_s3. Update CHANGELOG.md. (#28398)
Use aws_s3 in examples.
7 years ago
Brandon Davidson 2ceff476bf [cloud] support tags in ec2_group module (#22472)
* Add tags support to cloud/amazon/ec2_group

* Finish making ec2_group tag support boto3 compatible.

Add integration tests to validate that tags are working as expected.
7 years ago
Romain Dartigues 050de6d6b5 bug: lvol fail when LV already exists (#23635) 7 years ago
Tomáš Karásek b3a90253fc Improvements in the packet_device module (#23127)
* Improvements and fixes in the packet_device module

* add version_added to new args

* remove default value from facility

* changed 'lock' from deprecated arg to alias of 'locked'
7 years ago
Karol Chrapek 0954fadff7 Correct mute function in datadog_monitor (#19662) 7 years ago
Rene Moser 4a2b4d07db exoscale: similar env vars as in cloudstack
* update docs
7 years ago
Rene Moser 58cd107166 exoscale: fix api_key param auth typo 7 years ago
Ganesh Nalawade 5d1d1a72c5 Fix junos integration test failure (#28491)
Pass ssh_config value to ncclient manager api as None
if it is not set.
7 years ago
Dag Wieers 96da0047ac Fix an issue causing win_copy to fail
It seems win_copy can fail because `will_change` was not returned in the dictionary when doing a query.
This is an easy fix to get it working again.
7 years ago
tmarlok88 982e322287 java_cert role pkcs12 import (#24616)
* java_cert pkcs12 import

* documentation and formatting

* update examples

* update examples #2

* integration tests

* integration tests #2

* added aliases.txt

* renamed aliases

* bugfix

* empty it alieses
7 years ago
Dag Wieers 6d015294c2 purestorage: Various changes, and one check-mode fix (#28485)
These were the changes I propose twice, a nullified PR edit, and then as
review comments when the PR was being merged.

I made those changes now to all purestorage modules.
7 years ago
Simon Dodsley b150f49187 purefa_volume: Add volume copy, aka clone (#28376) 7 years ago
Abhijeet Kasurde 69d03d26e5 Fix multiple issues in vmware_vswitch (#27969)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Brian Coca a897193bce Moar constructive (#28254)
* made composite vars and groups generic

now you can do both in every plugin that chooses to suport it
renamed constructed_groups as it now also constructs vars ... to constructed
moved most of constructed_groups logic into base class to easily share

* documented inventory_hostname

* typo fix
7 years ago
Mike Wiebe ec11cd2696 nxos_bgp_neighbor_af fix problem with advertise-map properties (#28413)
* Fix problem with advertise-map properties

* Change limit_to back to run all tests

* Fix unit tests

* Move advertise_map out of get_custom_value
7 years ago
Dag Wieers d902b9a36e Fix booleans in win_psexec documentation 7 years ago
bonuscheese 7c366f5cbd Fix 'format' method syntax to support Python 2.6 (Fixes #28198) (#28304)
Fixes #28198
Changed how string format method is used to support Python 2.6 syntax. By adding in positional arguments to braces in format method (e.g. {0}, {1}), Python 2.6 can support this module, without causing issues in newer versions of Python.

See ref for info on format differences w/ 2.6:
https://docs.python.org/2/library/string.html#format-string-syntax
7 years ago
Matt Clay 44f4294f5c Fix metadata in syslogger module. 7 years ago
Tim Rightnour c1e4702ff4 Add the syslogger module
Remove tabs from docs

Pass ansible sanity test
7 years ago
Yanis Guenane d4e7b045b7 Extend test coverage for openssl modules (#27548)
* openssl_privatekey: Extend test coverage

Extend the coverage of the integration test for the module
openssl_privatekey.

New tests have been added:

  * passphrase
  * idempotence
  * removal

Co-Authored-By: Pierre-Louis Bonicoli <pierre-louis.bonicoli@gmx.fr>

* openssl_publickey: Extend test coverage

Extend the coverage on the integration test for the module
openssl_publickey.

New tests have been added:

  * OpenSSH format
  * passphrase
  * idempotence
  * removal
7 years ago
Emma 4653f892c8 Documentation fix - subnet_name (#28462)
virtual_network was incorrectly stated as an alias for subnet_name. It should be 'subnet'.
7 years ago
nrwahl2 535ede4d15 Fixes #28444: Renamed function print_match to match_print due to variable name conflict (#28445)
* Fixes #28444: Renamed print_match function to match_print due to name conflict

* Rename `match_print` to `do_print_match`

I think this is less confusing.
7 years ago
Dag Wieers b9cee65756 Original author wishes not to be notified by ansibot (#28447)
And moving maintainers to BOTMETA.yml as well.
7 years ago
David Kretch beed59f303 Fix trailing space in ec2_vol example, fix 'the the' typos (#28440)
* Fix 'the the' typos, fix 'pahting' filename typo

* Change 'the the' typos to a single 'the'.
* Change `playbook_pahting.rst` to `playbook_pathing.rst`.

* Delete trailing space in ec2_vol example

Delete the trailing space in `instance: "{{ item.id }} "`, which makes the
example fail when run because it looks for instance "i-xxxx ".
7 years ago
Mike b5a00d05d3 fixed #28183 - user module shadowfile update on SunOS (#28276)
* fixed #28183 - user module shadowfile update on SunOS
7 years ago
Jordan Borean 8e40ac54dd win_copy: rewrite with new tests and functionality (#27678)
* win_copy rewrite with new tests and functionality

* minor pep fixes

* Handle UTF-8 filenames in zip

* fix for template

* when zip assemblies are not available in .net revert to old behaviour of copying one by one

* typo fix

* some more typos

* updated logic to correctly handle when new directories can be created

* removed testing file as it is not needed

* updated documentation based on PR
7 years ago
Matt Clay 7fc4e6b4af Fix PEP 8 issue. 7 years ago
Brian Coca 49c54024e6 added helper function to convert objects to dicts 7 years ago
Brian Coca de16ce42ef optimize reserved names warning 7 years ago
René Moser b3a57a4014 cloudstack: cs_host: add host_tag alias (#28417) 7 years ago
Drew Bomhof ea51567697 Allow a miq token as an argument passed into the ManageIQ Python API Client (#28088) 7 years ago
Nathaniel Case 33f342435a Attempt to detect and abort when 'fex-fabric' is present (#28342) 7 years ago
Ganesh Nalawade 4f54d6cea1 eos aggregate spec validation and doc changes (#28414)
*  Add aggregate validation for eos DI modules
*  Doc change to add aggregate examples
7 years ago
Rene Moser f6b7c1a6c1 cloudstack: cs_storage_pool: fix state handling, add tests
cs_storage_pool: rm CloudStackException dependency

cs_storage_pool: fix UnboundLocalError in check mode
local variable 'pool' referenced before assignment
7 years ago
John McEleney 7549b27544 Add new module cs_storage_pool
- Changed zone_name to name - Changed cluster_name to cluster - Changed pod_name to pod - Corrected tags type in docs - Remove unneeded returns - Other simplifications
7 years ago
Abhijeet Kasurde be86d77a70 Add check for correct parsing of sysctl (#24540)
* PEP8 fixes
* Refactoring of code
* Check to skip non-comment lines which doesn't
  contain = character

Fixes #24453

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Deyan Stoykov 2f732a621d haproxy: fix fail_on_not_found behaviour (#24790)
* haproxy: fix fail_on_not_found behaviour

* fix pep8 compliance
7 years ago
Dmitriy Khomutov 277b8bfaf0 Alternatives module: Add a check that the path to the executable exist (#24800)
* Add check that the path to the executable exists

* Corrected a typo
7 years ago
Sloane Hertel 29ab182537 elasticache_parameter_group: fix KeyError bug #24475 (#24509)
* Fix KeyError bug by appending None if key doesn't exist

ensure value is the expected type; if if expecting something parsed as truthy try to turn it back into the desired value - fixes result showing always changed since bool compared to str

use to_text

* use string_types instead of str, remove inline conditionals, abbreviate boolean logic
7 years ago
Guillaume Coré ccdea1c3b8 archive: allow ZIP64 by default (#24200)
allowZip64 is True by default since python 3.4,
see https://docs.python.org/3/library/zipfile.html#zipfile-objects

With python 2.7, when the file or folder to zip is >2G,
zipfile raises LargeZipFile.

This commit set allowZip64 to true.

Fixes #24125
7 years ago
Ganesh Nalawade c4b9dfe542 Remove default description in network DI modules (#28411) 7 years ago
Abhijeet Kasurde a572de626c Pep8 fixes for acl module (#24666)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Catatonic b146ba37da Update capabilities.py (#23879)
Fixes issue when using python3 interpreter: 'filter' object has no attribute 'append'
Ensure list type of data is used before appending data.
7 years ago
Konstantin Shalygin 343da35381 mail: Fix auth over starttls. (#24089) 7 years ago
Peter Sprygada 03b888052b fixes bugs in network filter for parsing ip address (#28404)
also adds parse_cli and parse_cli_textfsm to changelog
7 years ago
Gaige B Paulsen 54c50cc983 netconfig module updated to pay attention to .ssh/config (#23876) 7 years ago
Sloane Hertel b9762b52af s3_sync was setting HAS_BOTO3 by the existence of botocore alone. Fixes #28023 (#28339)
* s3_sync was setting HAS_BOTO3 by the existence of botocore alone. Fixed to import from module_utils.ec2 to ensure boto3 + botocore are present.

Also documented module requirements.

* Remove unused import
7 years ago
Bobby Watson 8e8a7c869a Changed string check to verify that EOS device is not in config mode. (#28332)
Changed string check to verify that EOS device is not in config mode. This was required in order to work with Arista 7500 series modular switches.
Resolves #2830
7 years ago
Chris Alfonso bd56e6c9ce Removing deprecated openswitch modules (#28397) 7 years ago
Doug Gorley 5e6984a34c Added support to GCE module for image families and external projects. (#26711)
* Added support to GCE module for image families and external projects.

* Added image_family and external_projects to gce_pd.

* Added version_added for new options.
7 years ago
Nathaniel Case db5d799122 Fix nxos_pim idempotence (#28348) 7 years ago
TaoBeier be6c4908a2 executor stats and task_executor pep8 error (#23651) 7 years ago
Abhijeet Kasurde 6fd579b9f5 Refactor DigitalOcean modules
Fix adds refactoring of DigitalOcean modules by adding
common functionality to module_utils.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
7 years ago
Ganesh Nalawade 9ab9945cf3 iosxr modules aggregate check and other minor refactor (#28360)
*  iosxr aggregate validation
*  vyos_user, junos_user minor changes
*  Aggregated documentation
7 years ago
Ganesh Nalawade ceef4f97ed Use merge operation for load configuration in junos modules (#28369)
*  Change load configuration operation from replace to merge
7 years ago
Mehran Kholdi ecfa7f696d Enforce `state='file'` in `copy` module
This was causing wrong behaviour when `prev_state` was `hard`-link,
since the `file` module tried to apply the same `state` on the new
file, causing unexpected errors.

Particularly, both `overlay` and `devicemapper` storage drivers in
docker use hardlinks to share files between layers. This causes
most ansible playbooks to fail when working with files from layers
below.
7 years ago
Dag Wieers 78dfbed2a5 openbsd_pkg: Fix when failed, PEP8-compliant (#26018)
This PR includes:
- PEP8 compliancy
- A fix to ensure the module fails when it failed for a package
- Various cosmetic changes to documentation
- Make `state: present` the default (and not required)
7 years ago
Sam Doran 9fe898add6 Make options match others in the file 7 years ago
Kurt Bomya 05fd51f77d Added "choices" true/false for user_install 7 years ago
Julien Stroheker 0b29162b97 Azure Availability Set module (azure_rm_availabilityset) (#28353)
* Adding the module and int. tests

* upgrading metadata to 1.1
7 years ago
Sergio Millan 400085aa5b return EXCL_STATE when color property is not in the response 7 years ago
Artem Loginov 6e8eb7612a Fixed issue with legacy jenkins instances 7 years ago
Filipe Azevedo 6868c892ed Fixes https://github.com/ansible/ansible-modules-extras/issues/2462 (#21891) 7 years ago
Adrian Likins 01c0b2f714 Handle errors in jmespath in json_query better (#22109)
* Handle errors in jmespath in json_query better

Catch any exceptions raised from jmespath and raise
an AnsibleFilterError instead.

Avoid a traceback.

Fixes #20379

* pep8
7 years ago
Lukas Beumer eebc0cea6e [cloud][gcp] Add region and versioning parameter to gc_storage (#27802) 7 years ago
John Bond 722579356d correct handeling of execute option (#23814) 7 years ago
Nihlaeth e5ff8e3407 Don't remove comment from public key, and improve error message for duplicate keys (github_key) (#22282)
* improve error message for duplicate public keys

* don't consider self when searching for duplicates

* don't strip comment from key
7 years ago
Antony Messerli e0d0446183 Updates lldp module example to use ifname instead of ifalias (#23064) 7 years ago
Anthony Arnaud 3da1036baa zfs bad volume block size #23090 (#23092) 7 years ago