Commit Graph

301 Commits (f5658f4e5048ae6f2cf1d8eb434be3602fc6bb3a)

Author SHA1 Message Date
Monty Taylor 9914626ce2 Add a few lines about testing (#5662) 9 years ago
Sam Doran a257f9cc9c Examples syntax batch6 (#5623)
* Change example syntax on os_auth module

* Change example syntax on os_client_config module

* Change example syntax on os_image_facts module

* Change example syntax on os_networks_facts module

* Change example syntax on os_nova_flavor module

* Change example syntax on os_object module

* Change example syntax on os_server module

* Change example syntax on os_subnet_facts module

* Change example syntax on rax_files module

* Change example syntax on rax_files_objects module

* Change example syntax on mysql_db module

* Change example syntax on file module

* Change example syntax on uri module

* Change example syntax on cl_bond module

* Change example syntax on cl_bridge module

* Change example syntax on cl_img_install module

* Change example syntax on cl_interface module

* Change example syntax on cl_license module

* Change example syntax on cl_ports module

* Remove trailing colon
9 years ago
Jesse Keating bb97885f91 Do not require password when deleting os_user (#5601)
I broke backwards compat with the addition to define when a password
should be updated. It was requiring that a password value be passed when
deleting a user, which seems silly.

This moves the argument logic out of the argument spec and into when it
would be needed, when state is present.
9 years ago
Sam Doran 52d376c88e Examples syntax batch5 (#5622)
* Change example syntax on supervisorctl module

* Change example syntax or _ec2_ami_search module

* Change example syntax on cloudformation module

* Change example syntax on ec2 module

* Change example syntax on ec2_facts module

* Change example syntax on ec2_eip module

* Change example syntax on rds module

* Change example syntax on route53 module

* Change example syntax on s3 module

* Change example syntax on digital_ocean module

* Change example syntax on docker_service module

* Change example syntax on cloudformation module

* Change example syntax on gc_storage module

* Change example syntax on gce module

* Change example syntax on gce_mig module

* Change example syntax on _glance_image module

* Change example syntax on _keystone_user module

* Change example syntax on _nova_keypair module

* Change example syntax on _quantum_floating module

* Change example syntax on _quantum_floating_ip_associate module

* Change example syntax on _quantum_network module

* Change example syntax on _quantum_router module

* Change example syntax on _quantum_router_gateway module

* Change example syntax on _quantum_router_interface module

* Change example syntax on _quantum_subnet module

* SQUASH _quantum_subnet

* Add missing quotes
9 years ago
Lars Van Casteren 00e64def78 Docs update for `os_security_group` (#5531)
The example used equal characters and not colon characters.
9 years ago
jctanner 2de97ac5bd replace type() with isinstance() (#5541)
Replace all use of type() with isintance()

Addresses https://github.com/ansible/ansible/issues/18310
9 years ago
Yair Fried c953397fde Expose internal_network in os_floating_ip (#5510)
* Expose internal_network in os_floating_ip

Shade project has finally exposed this argument so now this module
matches old quantum_floatingip module's capabilities.

Use "nat_destination" term instead of "internal_network" to match shade
terminology.

* Add (private|internal)_network aliases to os_floating_ip

* Fix typo in os_floating_ip
9 years ago
Abel Boldú 9d07911b03 Add uplink provider type (#5282) 9 years ago
Jesse Keating 4db6d47ef8 Add update_password argument to os_user (#5219)
There is a desire to not have this module always result in a change if a
password argument is supplied. The OpenStack API does not return a
password back when we get a user, so we've been assuming that if a
password argument was supplied, we should attempt to change the password
(even if nothing else is changing), and that results in a "changed"
state. Now we will only send along a password change attempt if the user
wants one (the default to match history).

Fixes #5217
9 years ago
Ricardo Carrillo Cruz 872a3822c2 Add rebuild support to os_server_actions (#4289)
Fixes #2714
9 years ago
Ricardo Carrillo Cruz 500736d301 Refactor domain/project handling on os_user module (#5212)
The keys returned by user objects for default domain and
default project are respectively default_domain_id and
default_project_id.
We need to gather those IDs in case the user passed names, so we
can then compare with the user object on the needs_update helper
function.
9 years ago
John R Barker 312f578f93 Bulk spelling improvement to modules-core (#5225)
* Correct spelling mistakes

* Correct more spelling issues

* merge conflict

* Revert typo in parms
9 years ago
David Shrewsbury 7994115bbc Fix os_network's create_network() call for older shade versions (#5058)
A value for the project_id parameter to shade's create_network()
call was always being sent, even if no value for 'project' was
supplied. This was breaking folks with older versions of shade
(< 1.6).

Fixes PR https://github.com/ansible/ansible-modules-core/issues/3567
9 years ago
David Shrewsbury 4bd2a409e6 Correct reuse_fips param to reuse_ips (#4939)
This new parameter was incorrectly named. Fixing to match the expected
name in the shade library.
9 years ago
indispeq 20e08b2cdf Fix openstack security group rule vrrp choice apostrophe error (#4750)
Fixes #4444 that was erroneously closed and thought fixed
9 years ago
Monty Taylor 4840d30589 Expose the reuse_fips flag on os_server (#4849)
* Expose the reuse_fips flag on os_server

* Remove useless line
9 years ago
David J Peacock 3bede24323 description expanded for 112, AKA VRRP protocol) (#4645)
* description expanded for 112, AKA VRRP protocol)

* corrected syntax for description for IP protocols
9 years ago
Arun prasath 0d98760b49 Fixes bug #4546 - Made password optional (#4574) 10 years ago
David J Peacock 8f963a7028 Fix #4412: os_security_group_rule support numbered protocols (#4444) 10 years ago
Karthik Suresh 64ded1bb5e Removing duplicate name: parameter possible typo (#4525)
Removed name:parameter in documentation. Possible typo.
10 years ago
Monty Taylor 0e8ce4ad52
Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
10 years ago
yfried-redhat 6b20645b40 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
10 years ago
Toshio Kuratomi 55e6703209 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
10 years ago
David Shrewsbury a606e9cd37 Fix bug in os_router.py when router is not actually updated. (#4107)
The shade update_router() call will return None if the router is
not actually updated. This will cause the module to fail if we
do not protect against that.
10 years ago
Rene Moser 45845e0bdc os_server, doc: add version added for delete_fip
Also see #3509
10 years ago
David Shrewsbury 3979faf3e5 Allow os_server to delete FIP (#3509)
The os_server module could automatically generate a floating IP for
the user with auto_ip=true, but we didn't allow for this FIP to be
automatically deleted when deleting the instance, which is a bug.
Add a new option called delete_fip that enables this.
10 years ago
Patrick Uiterwijk 414d3611cb nova_compute: indicate argument type (#4070)
Without this, ansible 2.1 will convert some arguments that are
meant to be dict or list type to their str representation.

Signed-off-by: Patrick Uiterwijk <puiterwijk@redhat.com>
10 years ago
Graham Goldstein 4f8f0cf66b Change documented options for os_networks_facts (#3970)
* Change documented options for os_networks_facts

os_network_facts currently lists 'network' as an available option, taking the Name or ID. In Ansible 2.0.2 to 2.2.0, this is not valid. Options 'name' and 'id' should be used instead.

* Update os_networks_facts.py

* Update os_networks_facts.py

Set version_added to the only accepted value

* Update os_networks_facts.py

Removed inappropriate 'ID' parameter
10 years ago
Mario David ae5ccf29ed add project to os_router (#3869)
* add project to os_router

* version_added fix

* correct place of version_added

* remove extraneous else

* * add shade version dependency check
* option project only on router creation

* * fix shade minimal version
* remove pop of option project

* * fix square brackets
* delete router by router_id
10 years ago
codemeup @ Work 18455b2e72 Fixing open stack compile time errors irt exception handling for Python 3 (#3848) 10 years ago
David Shrewsbury d952087557 Merge pull request #3732 from GheRivero/devel
Make add ip_floating_ip idempotent
10 years ago
Alvaro Aleman 7f7b9054fd Fix can_update test in os_subnet (#3664) 10 years ago
René Moser 215da19511 Add no_gateway_ip option to os_subnet module (#3736)
no_gateway_ip option can provide subnet that is not having a gateway.
fixes #1880
10 years ago
Ghe Rivero c5430d0f92 Make add ip_floating_ip idempotent
Closes issue #1858
10 years ago
John R Barker bb9572ca86 ansible-validate-modules part 4: Enable check on ansible-modules-core (#3526)
* Call ansible-validate-modules

* Correct quotes + add newline
10 years ago
tonyqui e6fb933c3c Fixing a typo, floating-ips has been used instead of floating_ips (#3540) 10 years ago
Donovan Jones 7c52ea58f1 Make remote_group handle name and id in cloud/openstack/os_security_group_rule.py
* Make remote_group handle name and id

* fix regression breaking os_security_group_rule with no remote_group
10 years ago
David Shrewsbury 25e75e66eb Merge pull request #3236 from rcarrillocruz/network_by_project
Add project parameter to os_network
10 years ago
Ricardo Carrillo Cruz 3e93204598 Add project parameter to os_network
A cloud/domain admin should be able to create a network on any project
it is granted to.
This changes adds the possibility to pass either a project ID or
project name.
10 years ago
David Shrewsbury cea5ceb644 Merge pull request #3237 from rcarrillocruz/os_subnet_by_project
Create subnet by project
10 years ago
Matt Davis 6d0e9327e3 Merge pull request #3342 from gundalow/docsfix
ansible-validate-modules part 1: Correct documentation
10 years ago
Ricardo Carrillo Cruz 8a03ae5287 Create subnet by domain
A cloud/domain admin should be able to create a subnet on any
project it is granted on.
This change adds the 'project' parameter that accepts either
a name (admin-only) or id.
10 years ago
Rene Moser 85c45d9fd1 openstack: doc fix, add version_added
see #3388
10 years ago
David Shrewsbury 99659036ca Merge pull request #3363 from rcarrillocruz/check_default_project_if_present
Only check default_project on resource creation
10 years ago
Monty Taylor 265c3fdfb5 Merge pull request #3388 from Shrews/os_network_provider
Add support for provider network options
10 years ago
David Shrewsbury 29bd86394e Add support for provider network options.
Adds new parameters for specifying options for provider network plugins.
10 years ago
David Shrewsbury 6970cc233f Wrap calls to main() with if check
A change was merged to the main Ansible core code that can cause

a potential hang if any libraries are called that use threading.

This change was:



  4b0aa1214c



This affected the os_object module by causing a hang on the shade

create_object() API call (which in turn calls swiftclient which

uses threading). The fix is to make sure all modules have a main()

that is wrapped with an "if __name__ == '__main__'" check.
10 years ago
John Barker 531eed80b3 Replace BOOLEANS with true/false 10 years ago
Ricardo Carrillo Cruz ee2d436aa5 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
10 years ago
Brian Coca 20e4ad0eef corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
10 years ago