ansible

Commit Graph

Author	SHA1	Message	Date
Toshio Kuratomi	5147e792d3	Enable the bare-except pylint and pep8 checking	6 years ago
Matt Clay	c24c19594e	Enable pylint rules and fix exposed bugs. (#47219 ) * Resolve invalid-unary-operand-type. * Resolve raising-format-tuple. * Resolve stop-iteration-return. * Use disable comment instead of fixing logic. The affected line in _find_address_range will only fail on Python 3.7 and later if the function is called with an empty address list. As an internal method it is never called in this way, making it a non-issue for use via public methods. Using a comment to disable the rule in favor of an ignore.txt entry since there are no plans to change the logic in the code itself. This will also prevent any potential future issues being added in other parts of the code when updating it based on upstream changes.	6 years ago
Matt Clay	37b013aca3	Enable additional pylint rules and resolve issues found. (#47221 ) * Resolve unneeded-not. * Resolve global-at-module-level. * Resolve useless-import-alias. * Resolve bad-whitespace. * Resolve global-variable-not-assigned. * Resolve logging-not-lazy. * Resolve comparison-with-itself.	6 years ago
Matt Clay	76bf861308	Upgrade pylint to version 2.1.1. (#47036 ) * Fix issues reported by the latest pylint. * Split pylint runs into more contexts. * Upgrade pylint.	6 years ago
Matt Martz	49eb53b44d	pylint plugin to catch due/past-due deprecated calls (#44143 ) * Start of work on pylint plugin to catch due/past-due deprecated calls * Improve deprecated pylint plugin * Catch call to AnsibleModule.deprecate also * Skip splatted kwargs, we can't infer that info * Add error for invalid version in deprecation * Skip version if it's a reference to a var * Disable ansible-deprecated-no-version for displaying deprecated module info * fix comments * is None * Force specifying a version, this can be disabled on a per case basis * Disable ansible-deprecated-version by default * Remove to look for 2.8 deprecated * Revert "Remove to look for 2.8 deprecated" This reverts commit `4e84034fd1`. * Add script and template used for creating issues for deprecated issues * Fix underscore var	6 years ago
Matt Clay	ac492476e5	Bug fixes and cleanup for ansible-test. (#45991 ) * Remove unused imports. * Clean up ConfigParser usage in ansible-test. * Fix bare except statements in ansible-test. * Miscellaneous cleanup from PyCharm inspections. * Enable pylint no-self-use for ansible-test. * Remove obsolete pylint ignores for Python 3.7. * Fix shellcheck issuers under newer shellcheck. * Use newer path for ansible-test. * Fix issues in code-smell tests.	6 years ago
Toshio Kuratomi	86242e6871	Enable wildcard import pylint (#35786 ) * Wildcard imports should be taken care of. Enable the pylint check for them * Remove wildcard import code-smell test as we're now checking via pylint * Add unused-wildcard-import as ignored in our compat code. These three files use wildcard imports so that they can export symbols in a compatible location. The real code lives elsewhere. So disable the pylint tests for the relevant sections of code.	7 years ago
Matt Clay	c6bb6c72cc	Fix anomalous backslashes and enable pylint test.	7 years ago
Matt Clay	cf1337ca9a	Update ansible-test sanity command. (#31958 ) * Use correct pip version in ansible-test. * Add git fallback for validate-modules. * Run sanity tests in a docker container. * Use correct python version for sanity tests. * Pin docker completion images and add default. * Split pylint execution into multiple contexts. * Only test .py files in use-argspec-type-path test. * Accept identical python interpeter name or binary. * Switch cloud tests to default container. * Remove unused extras from pip install. * Filter out empty pip commands. * Don't force running of pip list. * Support delegation for windows and network tests. * Fix ansible-test python version usage. * Fix ansible-test python version skipping. * Use absolute path for log in ansible-test. * Run vyos_command test on python 3. * Fix windows/network instance persistence. * Add `test/cache` dir to classification. * Enable more python versions for network tests. * Fix cs_router test.	7 years ago

9 Commits (f55481863d320e7ec5a8c2a0d273dfa0a07b8d7f)