Commit Graph

54 Commits (f3a2fb3dae36fbf03e899d616a5d947ffaf1ac55)

Author SHA1 Message Date
Nathaniel Case 9a0add286f Network module code cleanup (#5061)
* Fix imports in junos_template

* Python 3 compatibility in eos_command

* Python 3 compatibility for ios_command

* Clean up issues with ios_facts

* Python 3 compatibility for ios_facts

* Import shuffle in ios_template

* Python 3 compatibility for iosxr_command

* Clean up iosxr_facts.py

* Python 3 compatibility for iosxr_facts

* Python 3 compatibility for junos_command

* Python 3 compatibility for ops_command

* Cleanup issues with ops_facts

* Python 3 compatibility for ops_facts

* Cleanup issues with ops_template

* Python 3 compatibility for vyos_command

* Cleanup issues with vyos_facts

* Python 3 compatibility for vyos_facts
8 years ago
Nathaniel Case bdab56efa8 eos_facts cleanup (#5057)
* dict.iteritems does not exist in Python 3

Now just dict.items
six.iteritems handles the change

* Addresses point 1

Unsure if this is a good idea or not.

* Addresses point 2

This shouldn't have any particular change, just marks load_comments as abstract

* Remove unused import

Addresses point 3

* Clarify invalid subset error message

Addresses point 4
8 years ago
Peter Sprygada 1dd2b849dc fixes default value in docstring for http (#4985)
The docstring incorrectly stated the default value for http is yes when
indeed its no.  This fixes the docstring
8 years ago
Peter Sprygada 3714b30a9f bug fix that now catches FailedConditionalError when specifying conditionals
This is related to ansible/ansible#17638 and updates the eos_command module
to catch the exception and return a santatized error.
8 years ago
Peter Sprygada 4ff0fd3910 eos_eapi module allows independent configuration of protocol and port
The eos_eapi module would not configure the port if the protocol wasn't
configured as reported in #4905.  This changes the behavior to now allow
the port to be configured independently

fixes #4905
8 years ago
Peter Sprygada 0f8f47dcf1 fix up eos_eapi module
* fixes TypeError: load_config() got an unexpected keyword argument 'session'\n"
* removes qos argument

ref #4869
8 years ago
Peter Sprygada e927fa73d5 Merge pull request #4798 from gundalow/docs_backup
Document `backup` option in eos_config and nxos_config
8 years ago
John Barker f1ad1d0d64 RETURNS doesn't support markup, so remove it 8 years ago
John Barker 9c42d72375 Docs improvements to _config 8 years ago
Peter Sprygada cbcb90e112 fixes error when calling load_config() with session keyword
The session keyword is no longer needed or supported in the load_config()
method for eos.  This fixes an issue in eos_template where the session
keyword was still being sent.
8 years ago
John Barker b76b3de28e Document `backup` options
To make future diffing easier, use consistent ordering
8 years ago
Peter Sprygada 9df9a1dbd4 roll up of updates to eos_config module
* removes update argument
* adds `config` option to replace argument
* moves session management into shared module
* cleans up doc strings
* `before` and `after` args now only apply to lines
8 years ago
Andrew Gaffney 0c05f0dfa4 Fix missing colons in network module examples (#4778) 8 years ago
Peter Sprygada db18577df1 Merge pull request #4724 from privateip/eos_config
roll up of minor fixes in eos_config module
8 years ago
Peter Sprygada 87dc24b19e roll up of minor fixes in eos_config module
* fixes save argument to be type bool
* now properly sets the changed returned flag based on diff
* updates docstring RETURNS to add backup_path
* removes unneeded state argument

tested on EOS 4.15.4F
8 years ago
Peter Sprygada e464599632 minor bug fixes in eos_template
* fixes issue where configuration was not being loaded (#4704)
* fixes issue where defaults were not included when argument was set to True

tested on EOS 4.15.4F
8 years ago
John R Barker ceddebaf28 Consistent naming of Arista EOS device (#4616) 8 years ago
Peter Sprygada 6f9ab60f81 Merge pull request #4615 from ansible/gundalow-patch-2
Consistent naming of Arista EOS device
8 years ago
Peter Sprygada c215398e2f update eos_eapi module with new enhancements
* add support for vrf configurations
* add support for configing the qos value for eapi
* add config argument to specify the device running-config

Tested on EOS 4.15.4F
8 years ago
John R Barker ec1c490888 Consistent naming of Arista EOS device 8 years ago
Peter Sprygada 12122952db Merge pull request #3950 from grybak-arista/eos_exit_fix
Move call to filter_exit out of command execution block
8 years ago
Peter Sprygada 074273dbb4 update eos_template for network shared module
This updates the eos_template module to work with the changes introduced
in the network shared module in Ansible 2.2

Tested on EOS 4.15.4F
8 years ago
Peter Sprygada ef48b9188f add new eos_facts module for fact collect of EOS nodes
* adds support for std network facts
* adds support for default facts subset
* adds support for config facts subset
* adds support for interface facts subset
* adds support for hardware facts subset

Tested on EOS 4.15.4F
8 years ago
Peter Sprygada 5dad16e914 Merge pull request #4501 from privateip/eos_command
add new functionality to eos_command module
8 years ago
Peter Sprygada 356888a3a3 add new functionality to eos_command module
* commands argument now accepts a dict arguments[1]
* waitfor has been renamed to wait_for with an alias to waitfor
* only show commands are allowd when check mode is specified
* config mode is no longer allowed in the command stack
* add argument match with valid values any, all

[1] The commands argument will now accept a dict argument that can
specifiy the output format of the command.  To specify a dict argument
use the form of { command: <str>, output: <str>, prompt: <str>,
response: <str> }.  Command and output are required arguments. Output
accepts valid values text and json.
8 years ago
Peter Sprygada 577d34d163 update eos_config with new arguments
* add src argument to provide path to config file
* add new choice to match used to ignore current running config
* add update argument with choices merge, replace or check
* add backup argument to backup current running config to control host
* add defaults argument to control collection of config with or without defaults
* add save argument to save current running config to startup config
* add state argument to control state of config file
* deprecated force argument, use match=none instead
8 years ago
John Barker 79c55534fc General EOS documentation improvements
Typos, formatting, choices.
8 years ago
John R Barker 280522914c State runnng v running
Fix typo
8 years ago
Peter Sprygada 11efe33730 refactor the eos_command module to use the CommandRunner
* This adds support the CommandRunner to handle executing commands on
the remote device.
* It also changes the waitfor argument to wait_for to remain compatable
with other modules and adds an alias for waitfor.
* Restricts commands to show commands only when check mode is specified.
* add version_added to wait_for doc string
8 years ago
Gary Rybak dc21c211e3 Move call to filter_exit out of command execution block
to prevent setting 'changed' on a command list that is
completely filtered (empty).
9 years ago
Michael Scherer cc99fe24fc Convert the network subfolder to py3/py2.4 syntax (#3690) 9 years ago
Scott Butler 7d09339d31 Fixed typos 9 years ago
Peter Sprygada 6b8a92045f handles config replace properly in eos_template
fixes 3366
9 years ago
Peter Sprygada ad519c2f5c refactors eos_template to remove diff functions
replaces functions with netcfg shared library for handling configuration
diffs
9 years ago
Peter Sprygada 5d0ee49067 refactors eos_config to remove config diff functions
replaces with netcfg shared library for handling configuration diffs
9 years ago
James Cammarata d7422c02ad Merge pull request #3010 from grybak-arista/exit-filter
Filter exit commands when no other commands are included
9 years ago
Peter Sprygada d4e687f894 doc string fixes for eos_config
This updates eos_config with some fixes to the documentation string
9 years ago
Peter Sprygada 416dd73b09 bugfix in eos_template for backing up config
eos_template would connect to the remote device to get the running config
for backup even if backup is not needed.
9 years ago
Peter Sprygada cf3287b312 minor function clean ups in eos_command
This commit cleans up a couple of functions and removes the json
import to use the json methods from AnsibleModule
9 years ago
Peter Sprygada 11056c8ed2 bugfix for handling match=strict in eos_config
Resolves an issue where match=strict would act like match=exact when
evaluating the configuration
9 years ago
Matt Martz c7845456a6 Various simple linting type cleanups on modules 9 years ago
chouseknecht 573ba42b03 Moved Conditional class to netcfg. 9 years ago
Gary Rybak 373961da04 Add filter to eos_template to remove configuration mode command
followed immediately by an exit command indented one level.
9 years ago
Peter Sprygada e6460906fd update eos_config doc string and return values
This change update the return values from eos_config to be consistent with
all network config modules.  This will now return updates and responses
from the module
9 years ago
Peter Sprygada d66a0cbe3f update eos_template doc string and return values
This updates the return values form eos_template to be consistent
across all template modules.  This change now returns updates and
respones
9 years ago
Peter Sprygada 624d1e38b8 update eos_command doc strings and return values
This change updates the returns values from eos_command to be consistent
with network modules. It now returns stdout, stdout_lines and failed_conditionals
9 years ago
chouseknecht 4e614d36bc Adding eos_eapi module. 9 years ago
Peter Sprygada 6c486cd341 bug fix for eos_config module
This addresses a bug in the eos_config module that would prevent it
from running properly.  The module should now properly process the config
and the candidate
9 years ago
Peter Sprygada d64ae18307 bug fix on parameter in eos_config
The eos_config module has a bug where its trying to pass an argument
that doesn't exist.  This fixes that problem, removing the offending
keywork argment
9 years ago
Peter Sprygada 0df3a0e501 Merge pull request #2941 from privateip/module_eos_template
initial add of new module eos_template
9 years ago