Commit Graph

24027 Commits (f2b6c7b6a244451c39d5b3649b444fa06c0e611a)
 

Author SHA1 Message Date
John Barker 2b82389705 General EOS documentation improvements
Typos, formatting, choices.
8 years ago
Shawn Siefkas e9bf046c26 Check mode fixes for ec2_vpc_net module (#2179)
* Check mode fixes for ec2_vpc_net module

Returns VPC object information

Detects state change for VPC, DHCP options, and tags in check mode

* Early exit on VPC creation in check mode
8 years ago
Shawn Siefkas 0b95051039 Fix #2526 (#2527)
Fail on unhandled exception in ec2_asg rather than raise
8 years ago
Shawn Siefkas 66f1f6d537 Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
8 years ago
Michael Scherer 3c2110215c Do not hardcode default ssh key size for RSA (#4074)
By default, ssh-keygen will pick a suitable default for ssh keys
for all type of keys. By hardocing the number of bits to the
RSA default, we make life harder for people picking Elliptic
Curve keys, so this commit make ssh-keygen use its own default
unless specificed otherwise by the playbook
8 years ago
peter.jang b06f3bbb22 fix for rsync protocol (#4211) 8 years ago
John R Barker aa6a7d5789 State runnng v running
Fix typo
8 years ago
Matt Clay c2270a37ff Enable FreeBSD tests on Shippable. (#4296) 8 years ago
Rick Mendes be33879152 Fixes #4227: just changing messaging 8 years ago
Rick Mendes eae75cf727 Fix #3549, failure to reference `module` in `ec2_eip` module 8 years ago
David Chwalisz f979928ecc file module: add clarification on state=absent re files that do not exist. 8 years ago
Christian Schwarz e526b2ad3d system/service.py: fix false-positive service enablement on FreeBSD. (#4283)
sysrc(8) does not exit with non-zero status when encountering a
permission error.

By using service(8) `service <name> enabled`, we now check the actual
semantics expressed through calling sysrc(8), i.e. we check if the
service enablement worked from the rc(8) system's perspective.

Note that in case service(8) detects the wrong value is still set,
we still output the sysrc(8) output in the fail_json() call:
the user can derive the exact reason of failure from sysrc(8) output.
8 years ago
Lyle Mantooth f57ece661f Remove file extension from policy names (#3805)
Fixes #3804.

Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.
8 years ago
Julien Vey 7ba3ba2da9 Fix Typo in docker_image_facts module 8 years ago
Monty Taylor f441e2c1a9 Rename a confusing variable
I had to read the two lines in question twice. That might just make me
dumb, but if I'm dumb, someone else might be too.
8 years ago
Rick Mendes 4fad93561a please remove me as maintainer 8 years ago
Rick Mendes d6cc007380 Fixes #4227 8 years ago
Jasmine Hegman f5c3f4dd6b Update docs to indicate ec2_asg state defaults to present (#4046)
* Update docs to indicate ec2_asg state defaults to present

Hopefully fixes Issue #4016

* Forgot to flip required to false
8 years ago
Matt Clay df5869df4a Enable Windows tests on Shippable. (#4278) 8 years ago
Shaun Brady 7b8d625546 Make ec2_elb_lb respect VPCs when resolving groups
AWS security groups are unique by name only by VPC (Restated, the VPC
and group name form a unique key).

When attaching security groups to an ELB, the ec2_elb_lb module would
erroneously find security groups of the same name in other VPCs thus
causing an error stating as such.

To eliminate the error, we check that we are attaching subnets (implying
that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering
the list of security groups on this VPC.  In other cases, no such filter
is applied (filters=None).
8 years ago
Shaun Brady 3b32b60338 Remove trailing white space 8 years ago
Shaun Brady 04199140c5 Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
8 years ago
Rob Phoenix 6339398e7c various typo corrections to ios network modules 8 years ago
John Baublitz fe09641476 Doc update 8 years ago
John Baublitz c8dc0bf5c9 Fix exception handling to be compatible with Python 3 8 years ago
John Baublitz 4b11312737 Additional error handling for corner cases like deleting networks with active subnetworks 8 years ago
John Baublitz e4697c3780 Documentation 8 years ago
John Baublitz 96599a5963 Logic to allow subnet creation 8 years ago
John Baublitz 5591e6bb0b Add error handling for specifying 'mode' with insufficiently recent libcloud 8 years ago
John Baublitz 9c9b22dc8f Changes to allow 'auto' mode which does not allow IP address specification 8 years ago
John Baublitz 839871d87b Support for newer networking modes in GCE 8 years ago
Brian Coca 7f1e6ca005 updated docs to reflect new feature 8 years ago
Ryan 8b582cceaa fix typo in azure_rm_storageaccount (#4236) 8 years ago
Brian Coca d579dab0a0 deprecated accelerate 8 years ago
chrisweaver 531954e2f6 Enforce boolean type for dup_ok
Stop "choices" from being interpreted as strings.
8 years ago
Toshio Kuratomi 879afebf77 Remove git and synchronize modules from list of commands we want users to use the module for instead. (#4233) 8 years ago
Matthew Martin 4d952d6e6e Add CAPABILITY_NAMED_IAM to cloudformation capabilities
While from the documentation[1] one would assume that replacing
CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown
to not be the case.

1: "If you have IAM resources, you can specify either capability. If you
have IAM resources with custom names, you must specify
CAPABILITY_NAMED_IAM."
http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html
8 years ago
Michael Baydoun 3818cc2b95 fixes issues where iam_policy incorrected reported changed 8 years ago
John Baublitz 906b457bf1 Collapse boilerplate code into change_instance_state function 8 years ago
John Baublitz eb97165acc Add states for stopping and starting machines 8 years ago
Tom Melendez 067bb6ec01 Added helper function and logic to sort attributes before comparing. 8 years ago
Kai Kousa 4a8a052e2e Improve documentation on security_groups-option 8 years ago
Tom Melendez 8becd9a14d Allow GCE firewall rules to be updated when attributes changes. Fixes #2111.
Previously, when the attributes of a GCE firewall change, they were ignored.  This PR changes that behavior and now updates them.

Note that the "update" also removes attributes that are not specified.

An overview of the firewall rule behavior is as follows:

1. firewall name in GCP, state=absent in PLAYBOOK: Delete from GCP
2. firewall name in PLAYBOOK, not in GCP: Add to GCP.
3. firewall name in GCP, name not in PLAYBOOK: No change.
4. firewall names exist in both GCP and PLAYBOOK, attributes differ: Update GCP to match attributes from PLAYBOOK.
8 years ago
yfried-redhat b1ee47f358 Make os_floating_ip module idempotent
Current module fails when tries to assign floating-ips to server that
already have them and either fails or reports "changed=True" when no
ip was added

Removing floating-ip doesn't require address

Server name/id is enough to remove a floating ip.
8 years ago
Andrei Lukovenko 436ff356e7 Bug: repeatable invocation with state=present leads to (#3052)
[localhost]: FAILED! => {"changed": false, "failed": true, "msg":
"'Domain' object has no attribute 'id'"}

How to reproduce:

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

- name: create domain
  digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP

Problem: DigitalOcean API changed API
(https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)
8 years ago
Brian Coca 544b044129 stop trying to set permissions in check mode
fixes #4195
8 years ago
Brian Coca 498dc61154 documenting behaviour as clear as possible 8 years ago
Toshio Kuratomi 0364831c22 Remove version-added on name field.
This parameter was actually added in 2.0.  It's just that the
documentation in previous versions of the module were wrong (it said the
name was  "network" rather than "name.)  I've renamed the parameter in
the documentation of prior versions so ansible-module-validate should no
longer think that this is a new parameter.
8 years ago
Peter Sprygada 42da47813b adds update_config argument to ios_config
New argument controls whether or not configuration is applied to the
remote device.
8 years ago
Peter Sprygada 4611e2b9ad initial add of new module vyos_config
New module for sending configuration commands to remote devices running
the VyOS operating system.
8 years ago