2838 Commits (f040d63403f6c459a278918fa48fa8cb87754506)

Author	SHA1	Message	Date
Chris Houseknecht	cac4e68090	Default restart_retries to None rather than 0. Fixes #4534.	8 years ago
Ryan Brown	819fe45864	Fix failure when powering on/off EC2 instances by tag only. (#4767) ... If you apply `wait=yes` and use `instance_tags` as your filter for stopping/starting EC2 instances, this stack trace happens: ``` An exception occurred during task execution. The full traceback is: │~ Traceback (most recent call last): │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1540, in <module> │~ main() │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1514, in main │~ (changed, instance_dict_array, new_instance_ids) = startstop_instances(module, ec2, instance_ids, state, instance_tags) │~ File "/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py", line 1343, in startstop_instances │~ if len(matched_instances) < len(instance_ids): │~ TypeError: object of type 'NoneType' has no len() │~ │~ fatal: [localhost -> localhost]: FAILED! => {"changed": false, "failed": true, "invocation": {"module_name": "ec2"}, "module_stderr": "Traceb│~ ack (most recent call last):\n File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1540, in <module>\n main()\n File \"/tmp/│~ ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1514, in main\n (changed, instance_dict_array, new_instance_ids) = startstop_instances│~ (module, ec2, instance_ids, state, instance_tags)\n File \"/tmp/ryansb/ansible_FwE8VR/ansible_module_ec2.py\", line 1343, in startstop_insta│~ nces\n if len(matched_instances) < len(instance_ids):\nTypeError: object of type 'NoneType' has no len()\n", "module_stdout": "", "msg": "│~ MODULE FAILURE", "parsed": false} ``` That's because the `instance_ids` variable is None if not supplied in the task. That means the instances that result from the instance_tags query aren't going to be included in the wait loop. To fix this, a list needs to be kept of instances with matching tags and that list needs to be added to `instance_ids` before the wait loop.	8 years ago
Abhijit Menon-Sen	55d51b3946	Fix spot instance creation by ignoring instance_initiated_shutdown_behavior (#4741) ... Before this, all spot instance requests would fail because the code _always_ called module.fail_json when the parameter was set (which it always was, because the module parameter's default was set to 'stop'). As the comment said, this parameter doesn't make sense for spot instances at all, so the error message was also misleading.	8 years ago
Florian Dambrine	aac55fcc62	Fix ec2 module source_dest_check when running on non VPC instances (EC2 Classic) (#3243)	8 years ago
Matt Ferrante	624f813f60	Properly support tag updates on CloudFormation stack-update actions (#3638)	8 years ago
David J Peacock	3bede24323	description expanded for 112, AKA VRRP protocol) (#4645) ... * description expanded for 112, AKA VRRP protocol) * corrected syntax for description for IP protocols	8 years ago
Kenny Woodson	269c06a4c9	Fix for validate rule. Ensure rule is a dict. (#4640)	8 years ago
Kenny Woodson	9b37dcb593	Getting rid of a None type error when no resource tags are defined. (#4638)	8 years ago
John R Barker	0c25e968ee	digital_ocean_tag name is a required field ... Spotted during final review of https://github.com/ansible/ansible-modules-core/pull/4218/files Simple to change, so fixing post merge	8 years ago
Victor Volle	c170107eef	Digitalocean tags (replaces #4209) (#4218) ... * Fixes #4117: Add DigitalOcean Tag support * Add GPLv3 license header and RETURN documentation * ansible.module_utils.urls instead of "requests"	8 years ago
Arun prasath	0d98760b49	Fixes bug #4546 - Made password optional (#4574)	8 years ago
David J Peacock	8f963a7028	Fix #4412: os_security_group_rule support numbered protocols (#4444)	8 years ago
Ryan Brown	0c37949941	Remove spurious `changed` state on iam_policy module (#4381) ... Due to a mixup of the group/role/user and policy names, policies with the same name as the group/role/user they are attached to would never be updated after creation. To fix that, we needed two changes to the logic of policy comparison: - Compare the new policy name to *all* matching policies, not just the first in lexicographical order - Compare the new policy name to the matching ones, not to the IAM object the policy is attached to	8 years ago
Rick Mendes	02c47f5b0c	Fixes #3144 (#4305)	8 years ago
Matías Pizarro	521c9a2e20	Use named parameters in new_droplet method call (#4483) ... This mirrors the original method signature and guards against any change in order parameter	8 years ago
Ilja Bauer	acb7d873f8	Replaced use of bare variables with full variable syntax (#4149)	8 years ago
chouseknecht	48941291c1	Fix container labels expected vs actual comparison.	8 years ago
Patrick Marques	f3c0c09fb6	ssh_public_keys on Azure virtual machine is a list (#4350) ... The ssh_public_keys must be a list otherwise will give the error: "argument ssh_public_keys is of type <type 'dict'> and we were unable to convert to list"	8 years ago
Richard Adams	c8ca1a6211	Add parameter to `ec2` module to control instance shutdown behavior (stop|terminate)	8 years ago
Karthik Suresh	64ded1bb5e	Removing duplicate name: parameter possible typo (#4525) ... Removed name:parameter in documentation. Possible typo.	8 years ago
chouseknecht	42540ae510	Fix doc strings. Use of > was breaking HTML generation on docs site module page.	8 years ago
nishiokay	a24398d025	Add ipv6 paramater to digital_ocean module (#4447)	8 years ago
Linus Arver	74c8954d86	docker_service: fix files/project_files typo ... The original decision to rename from `project_files' to `files' was in 3a5dd00076.	8 years ago
chouseknecht	95f69c55fa	Exposing tcp and udp for same port fails. Fixes issue #4354.	8 years ago
Ryan Brown	8da5e2cb88	Merge pull request #4275 from shaunbrady/ec2_elb_lb_respect_vpc ... Make ec2_elb_lb respect VPCs when resolving groups	8 years ago
PikachuEXE	997fa3b2b7	Allow specifying human readable value for option `memory_limit` again (#4049)	8 years ago
Ryan Brown	a2a6b5247f	Merge pull request #4286 from rickmendes/fix-issue-4227 ... Clarify docs that led to #4227	8 years ago
chouseknecht	e7abbbf134	Fix network alias and network link comparison. ... - Using set based comparison was not working consistently - With != operator worked locally but consistently failed on Travis - With 'not in' operator failed locally and on Travis	8 years ago
chouseknecht	4c3bf24ebf	If debug true, include actions and differences in output.	8 years ago
Chris Houseknecht	70806fcfe4	Some post merge clean up: (#4406) ... - Removed required_if. - Fixed doc strings. - Removed debug output being appended to actions. - Put import of basics at bottom to be consistent with other docker modules - Added 'containers' alias to 'connected' param - Put facts in ansible_facts.ansible_docker_network	8 years ago
Brian Coca	decb2ec9fa	doc fix	8 years ago
Chris Houseknecht	fdfdfe9017	Adding docker_network module. (#4404)	8 years ago
muxator	24fa1ab426	typo in the documentation of the "state" parameter (#4353)	8 years ago
Chris Houseknecht	0358dee095	Add buildargs parameter to support Dockerfile ARG directive. (#4349) ... * Add buildargs parameter to support Dockerfile ARG directive. * Fix doc_strings. Doc string for load_path was completely missing.	8 years ago
chouseknecht	cc101164a8	Default repository tag value to tag parameter value or 'latest'.	8 years ago
chouseknecht	d36f04e7f2	Always returns changed when state present and name includes :tag.	8 years ago
Chris Houseknecht	c0d373f258	Add *build* to state parameter choices. Updated deprecation message. Will be deprecated in release 2.3. Removed (#4342) ... mention of *tagged* state in the force parameter doc strings. There is no *tagged* state.	8 years ago
chouseknecht	c27054090a	Fix image tag operation. Allows repository in form of repo:tag. If no tag value, defaults to 'latest'.	8 years ago
Ryan Brown	95a7ee271a	Merge pull request #3773 from jbaublitz/gce_net_nwmode ... gce_net: Add ability to create new-style networks on Google Cloud	8 years ago
chouseknecht	af177834af	Added implementation of ignore_image, which prevents recreation of containers on image change.	8 years ago
Chris Houseknecht	ccd8cd014b	Merge pull request #4313 from chouseknecht/devel ... Bind published ports to specific host IP when one is available	8 years ago
chouseknecht	74dbb61b8d	Fix #3670 host IP defaults to 0.0.0.0 ignoriing bridge Host IP option.	8 years ago
Chris Houseknecht	db66758125	Merge pull request #4308 from chouseknecht/devel ... Add explicit image build	8 years ago
chouseknecht	18343c4e5a	Improved documentation for returned actions.	8 years ago
chouseknecht	b9696a349f	When build true call docker-compose build, and add nocache option.	8 years ago
Chris Houseknecht	3b268eff79	Merge pull request #4307 from chouseknecht/devel ... Adding pull option	8 years ago
chouseknecht	81b3022eb5	Set version_added	8 years ago
chouseknecht	7e93dbb264	Add pull option to pull images prior to evaluating service state.	8 years ago
Shawn Siefkas	ec87c517c1	Check mode fixes for ec2_vpc_net module (#2179) ... * Check mode fixes for ec2_vpc_net module Returns VPC object information Detects state change for VPC, DHCP options, and tags in check mode * Early exit on VPC creation in check mode	8 years ago
Shawn Siefkas	380dbd4369	Fix #2526 (#2527) ... Fail on unhandled exception in ec2_asg rather than raise	8 years ago
Shawn Siefkas	528f9a1d0b	Check mode fix for ec2_group module (#2184) ... The default VPC egress rules was being left in the egress rules for purging in check mode. This ensures that the module returns the correct change state during check mode.	8 years ago
Rick Mendes	8287002f14	Fixes #4227: just changing messaging	8 years ago
Rick Mendes	72655fe4c8	Fix #3549, failure to reference `module` in `ec2_eip` module	8 years ago
Ryan Brown	cb2a47753a	Merge pull request #4292 from julienvey/patch-1 ... Fix typo in docker_image_facts module	8 years ago
Ryan Brown	81c663ff71	Merge pull request #4288 from rickmendes/rm-me ... please remove me as maintainer	8 years ago
Lyle Mantooth	50abfd5e27	Remove file extension from policy names (#3805) ... Fixes #3804. Prevents `__file__` from contributing ".", which is an illegal character in ELB policy names.	8 years ago
Julien Vey	0bf24f2ae1	Fix Typo in docker_image_facts module	8 years ago
Monty Taylor	d38c24d0ed	Merge pull request #3407 from yfried-redhat/idempotent_os_floating_ip	8 years ago
Monty Taylor	0e8ce4ad52	Rename a confusing variable ... I had to read the two lines in question twice. That might just make me dumb, but if I'm dumb, someone else might be too.	8 years ago
Rick Mendes	203b332cdb	please remove me as maintainer	8 years ago
Rick Mendes	9cf83ab764	Fixes #4227	8 years ago
Jasmine Hegman	a3bae3e6ce	Update docs to indicate ec2_asg state defaults to present (#4046) ... * Update docs to indicate ec2_asg state defaults to present Hopefully fixes Issue #4016 * Forgot to flip required to false	8 years ago
Shaun Brady	de29bafc1e	Make ec2_elb_lb respect VPCs when resolving groups ... AWS security groups are unique by name only by VPC (Restated, the VPC and group name form a unique key). When attaching security groups to an ELB, the ec2_elb_lb module would erroneously find security groups of the same name in other VPCs thus causing an error stating as such. To eliminate the error, we check that we are attaching subnets (implying that we are in a VPC), grab the vpc_id of the 0th subnet, and filtering the list of security groups on this VPC. In other cases, no such filter is applied (filters=None).	8 years ago
Shaun Brady	8fa56c16ee	Remove trailing white space	8 years ago
Shaun Brady	890bba6a0e	Make group_name resolution VPC aware ... EC2 Security Group names are unique given a VPC. When a group_name value is specified in a rule, if the group_name does not exist in the provided vpc_id it should create the group as per the documentation. The groups dictionary uses group_names as keys, so it is possible to find a group in another VPC with the name that is desired. This causes an error as the security group being acted on, and the security group referenced in the rule are in two different VPCs. To prevent this issue, we check to see if vpc_id is defined and if so check that VPCs match, else we treat the group as new.	8 years ago
John Baublitz	2de9fe0e67	Doc update	8 years ago
John Baublitz	4d9b872c3e	Fix exception handling to be compatible with Python 3	8 years ago
John Baublitz	b8569ae38b	Additional error handling for corner cases like deleting networks with active subnetworks	8 years ago
John Baublitz	a7702c1f67	Documentation	8 years ago
John Baublitz	1ea678e4ac	Logic to allow subnet creation	8 years ago
John Baublitz	afe17834ce	Add error handling for specifying 'mode' with insufficiently recent libcloud	8 years ago
John Baublitz	4b5a459fc1	Changes to allow 'auto' mode which does not allow IP address specification	8 years ago
John Baublitz	d8147f6226	Support for newer networking modes in GCE	8 years ago
Ryan Brown	24db4de245	Merge pull request #4156 from supertom/ansible-2111-fix ... Support updating GCE firewall rules when attributes change Fixes #2111	8 years ago
Ryan Brown	d288ef2abc	Merge pull request #4163 from kaikousa/improve-ec2_lc-documentation ... Improve `ec2_lc` documentation on security_groups option	8 years ago
Ryan Brown	a960f01bf3	Merge pull request #4234 from chrisweaver/patch-1 ... Enforce `bool` type for dup_ok option on AWS `iam_cert` module	8 years ago
Ryan Brown	95c67dc72a	Merge pull request #4231 from phy1729/cfn-iam-capabilities ... Support CAPABILITY_NAMED_IAM in AWS CloudFormation module	8 years ago
Ryan Brown	92a17c61f4	Merge pull request #4190 from jbaublitz/gce_suspend_node ... Add states for stopping and starting GCE ☁️ instances	8 years ago
Ryan Brown	1e6d93cc52	Merge pull request #4203 from MichaelBaydoun/iam_policy_fix ... Stop iam_policy from always reporting `changed` status	8 years ago
yfried-redhat	6b20645b40	Make os_floating_ip module idempotent ... Current module fails when tries to assign floating-ips to server that already have them and either fails or reports "changed=True" when no ip was added Removing floating-ip doesn't require address Server name/id is enough to remove a floating ip.	8 years ago
Ryan	810b40aee9	fix typo in azure_rm_storageaccount (#4236)	8 years ago
chrisweaver	8879931f0c	Enforce boolean type for dup_ok ... Stop "choices" from being interpreted as strings.	8 years ago
Matthew Martin	34d48eb89b	Add CAPABILITY_NAMED_IAM to cloudformation capabilities ... While from the documentation[1] one would assume that replacing CAPABILITY_IAM with CAPABILITY_NAMED_IAM; this as empirically been shown to not be the case. 1: "If you have IAM resources, you can specify either capability. If you have IAM resources with custom names, you must specify CAPABILITY_NAMED_IAM." http://docs.aws.amazon.com/AWSCloudFormation/latest/APIReference/API_CreateStack.html	8 years ago
Michael Baydoun	07383c40d7	fixes issues where iam_policy incorrected reported changed	8 years ago
Andrei Lukovenko	3945794704	Bug: repeatable invocation with state=present leads to (#3052) ... [localhost]: FAILED! => {"changed": false, "failed": true, "msg": "'Domain' object has no attribute 'id'"} How to reproduce: - name: create domain digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP - name: create domain digital_ocean_domain: state=present name=DOMAIN_NAME ip=DROPLET_IP Problem: DigitalOcean API changed API (https://developers.digitalocean.com/documentation/v2/#list-all-domain-records)	8 years ago
John Baublitz	e85c2f8253	Collapse boilerplate code into change_instance_state function	8 years ago
Toshio Kuratomi	55e6703209	Remove version-added on name field. ... This parameter was actually added in 2.0. It's just that the documentation in previous versions of the module were wrong (it said the name was "network" rather than "name.) I've renamed the parameter in the documentation of prior versions so ansible-module-validate should no longer think that this is a new parameter.	8 years ago
John Baublitz	b5da9d190d	Add states for stopping and starting machines	8 years ago
Ryan Brown	f61ddbc8a9	Merge pull request #3863 from ryansb/iam-pass-module ... Bugfix: IAM group modules need `module` passed	8 years ago
Tom Melendez	7c8d972d8f	Added helper function and logic to sort attributes before comparing.	8 years ago
Tom Melendez	0f1c083d25	Allow GCE firewall rules to be updated when attributes changes. Fixes #2111. ... Previously, when the attributes of a GCE firewall change, they were ignored. This PR changes that behavior and now updates them. Note that the "update" also removes attributes that are not specified. An overview of the firewall rule behavior is as follows: 1. firewall name in GCP, state=absent in PLAYBOOK: Delete from GCP 2. firewall name in PLAYBOOK, not in GCP: Add to GCP. 3. firewall name in GCP, name not in PLAYBOOK: No change. 4. firewall names exist in both GCP and PLAYBOOK, attributes differ: Update GCP to match attributes from PLAYBOOK.	8 years ago
Chris Houseknecht	eab6bb8794	Merge pull request #4176 from h-hirokawa/fix4174 ... Fix azure_rm_virtualmachine to create a storage account with name contains lower-case only (#4174).	8 years ago
Chris Houseknecht	77db7011f0	Merge pull request #4173 from chouseknecht/fix_entrypoint ... Fix entrypoint. Should behave the same as command.	8 years ago
h-hirokawa	977a6a8b28	Fix azure_rm_virtualmachine (#4174).	8 years ago
Chris Houseknecht	a75ee76aa3	Entrypoint fails with 'command not found' error.	8 years ago
Chris Houseknecht	58b551774c	Add push parameter. Let API handle registry authentication check.	8 years ago
Chris Houseknecht	1058094b64	Fix module failing when no ports are exposed	8 years ago
jjshoe	90b8281a51	Fixed a typo (#4168)	8 years ago
Chris Houseknecht	73dbb744b5	Merge pull request #3887 from Jorge-Rodriguez/docker-image-no-push-on-load ... Don't forcibly push loaded images to registry.	8 years ago
Kai Kousa	7632bc1ecb	Improve documentation on security_groups-option	8 years ago