Commit Graph

362 Commits (ea56151a67537907e80947f2c8b1104377efdfd8)

Author SHA1 Message Date
Carlos E. Garcia 4dcaa9d9fb multiple spelling error changes 11 years ago
Skyler Leigh Amador 6eb8759ec5 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
11 years ago
Joel Schuweiler aed596088b Finish reverting #b73cddc 11 years ago
jjshoe 6f0808b23b Ensure the validation string has %s in it 11 years ago
Brian Coca 1e3860c47b now when making multiple dirs in path to make dir, same permissions are assigned (but only for NEW dirs)
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Erika Heidi 40e7c6eddc Possible docs error: 'path' instead of 'src'
I came to this example today (line 50), and when I tried it, I got an error:

`msg: src and dest are required for creating links`

So, I changed **path** to **src** and it worked fine. Looks like the example is wrong, since the docs say "dest" is already an alias for "path", in which case we would have 2 "path" definitions.
11 years ago
Michael Heca 6618c1e8b5 module replace - report changed only if contents is changed 11 years ago
James Cammarata 39356bd83b Get the bin path for commands in the unarchive module
Fixes #6927
11 years ago
James Tanner 0f82a2b53c Addresses #6702 Remove version_added from description string 11 years ago
James Tanner f2c9c2c141 Addresses #6702 set version_added for rsync_opts 11 years ago
jctanner 7a6267690e Merge pull request #6702 from jjshoe/devel
Allow you to pass in arbitrary rsync options
11 years ago
James Tanner fec4c797d9 Fixes #6929 remote file module doc fragments from copy and template 11 years ago
James Tanner 199992adb6 Fixes #6894 create docs fragment for files 11 years ago
James Cammarata 8f325afe38 Fixing newline escapes in lineinfile
Fixes #5679
11 years ago
James Cammarata 7a03cc69e1 Revert "Fix #5679 again after recent changes in core"
This reverts commit 2bfaacd170.

Fixes #6821
11 years ago
Richard C Isaacson 465b97be7e assemble module: fix insertion of newlines when not needed.
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
11 years ago
Peter Gehres 53c1d25c70 Fix for #6353 adding a newline between assembled files 11 years ago
Michael DeHaan 63a1330263 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.
11 years ago
James Tanner 7b72004eb4 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
11 years ago
cgtx bb3fed67aa backreferences should be double escaped 11 years ago
Michael DeHaan a8b345ad38 Repairs for documentation build. 11 years ago
Michael DeHaan f596ee8850 Slight docs tweak, split lines according to code standards 11 years ago
Andrea.Mandolo 2a66f356b1 correct documentation comment and version_added in "synchronize" module 11 years ago
Andrea.Mandolo 7cd21a47ef Add STDOUT lines in response of "synchronize" module 11 years ago
Andrea.Mandolo 33b440ac9f Add "checksum" option support to 'synchronize' module 11 years ago
Michael DeHaan d1975c906f Merge branch 'update_docs_validate_cmd_not_passed_via_shell' of git://github.com/rwehner/ansible into devel
Conflicts:
	library/files/template
11 years ago
Michael DeHaan 38c3332b8a Merge pull request #6597 from tarka/handle-uncreated-symlink-tmpfile
Handle missing symlink tempfile
11 years ago
jjshoe a5794f5d8c Allow you to pass in arbitrary rsync options. I also added help for it, and what version it was added in. 11 years ago
Jeff Geerling 177bf3eb20 Fixed template validation docs and example. 11 years ago
jjshoe e62b38c250 Show argument dependency
failed: [192.168.1.2] => {"cmd": "rsync --delay-updates -FF --compress --timeout=10 --delete-after --rsh 'ssh -i /home/jjshoe/.vagrant.d/insecure_private_key -o StrictHostKeyChecking=no' --rsync-path 'sudo rsync' --out-format='<<CHANGED>>%i %n%L' /tmp/app vagrant@192.168.1.2:/home/ubuntu/app", "failed": true, "item": "", "rc": 1}
msg: rsync: --delete does not work without --recursive (-r) or --dirs (-d).
rsync error: syntax or usage error (code 1) at main.c(1453) [client=3.0.9]
11 years ago
James Cammarata 68327fa172 Cleanup from merge of replace module and CHANGELOG update 11 years ago
James Cammarata 2c05e337cb Merge branch 'devel' of https://github.com/EvanK/ansible into EvanK-devel 11 years ago
James Cammarata d6a2befb0d Merge branch 'file_fixes_agg' of https://github.com/bcoca/ansible into bcoca-file_fixes_agg 11 years ago
Robert Wehner 406317371b Update 'validate=' parameter documentation to make clear that the command
passed via this paramter is not passed via shell and so all shell features
will not work.
11 years ago
James Tanner 7c263fcdad Fixes #6590 add set_remote_user parameter to synchronize
This allows usage of custom ssh configs for remote hosts where
the inventory user does not match the configured user.
11 years ago
Steve Smith 5b5af14921 Only unlink the symlink tempfile on error if it was created in the
previous operation.
11 years ago
Brian Coca a395eb3aba fixed issue with tmp file (path can include filename) and added missing
else which made it try to link x2
11 years ago
Brian Coca 4fd957620a now correctly checks absolute path for src= existance for links
also updated docs to be a bit clearer on symlink behaviour
11 years ago
Brian Coca 402cd11c52 fixed issue with directory permissions on copy #6552 11 years ago
James Cammarata d60ac967b9 Merge branch 'file_fixes_clean' of https://github.com/bcoca/ansible into bcoca-file_fixes_clean 11 years ago
Michael DeHaan 4ec2a79aae Merge pull request #6515 from lotia/fix-acl-doc-and-error
Fix acl doc and error
11 years ago
Ali Asad Lotia fc5aa9ac28 Whitespace fixes in incompatible param check
- Remove extra whitespace in conditional that checks if etype, entity or
  permissions are also set when entry is set.
11 years ago
Michael DeHaan ec14b25e23 Merge pull request #6448 from jirutka/fix-5679-2
Fix #5679 again after recent changes in core
11 years ago
Cristian Ciupitu 7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
Ali Asad Lotia 77e6dded62 Fix acl module doc and error messages
- Fix typos in module doc
- Provide clearer error message when entry and etype are both missing
11 years ago
Brian Coca 7ca6343ca3 Fixes and cleanup to file functions and module
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
11 years ago
Michael DeHaan 4f1ccfd66f Merge pull request #6504 from follower/patch-2
Fix typo
11 years ago
follower 5beee66d1d Fix typo
"resort" -> "result"
11 years ago
Brian Coca 5dd041ae7e fixed bad detection of change on default and premature break 11 years ago
Jakub Jirutka f39b8cae95 Fix #5679 again after recent changes in core 11 years ago
Brian Coca 3b98ed15bc now stat skips md5 if file isn't readable 11 years ago
James Tanner fc33860e5d Force command action to not be executed by the shell unless specifically enabled 11 years ago
Dolph Mathews 289f8f7ed9 spelling correction for "separate"
s/seperate/separate/

http://en.wiktionary.org/wiki/separate
11 years ago
Richard C Isaacson 7fff5abd5b unarchive module: Add creates functionality.
Closes GH-5354.

Forklift copy logic into unarchive. Provides integration unit tests.
11 years ago
Michael DeHaan 87677c96c6 Merge pull request #6308 from muffl0n/file_fix_documentation
Module "file": Fix link to "path" in documentation
11 years ago
James Cammarata bdd3ccec65 Un-escape newlines in delimiters for assemble module 11 years ago
Sven Schliesing b55f99b803 Fix link in documentation
c(dest) -> c(path)
11 years ago
Michael DeHaan 2f12c6ddf6 Simplify file module parameter description. 11 years ago
Richard C Isaacson 7263148156 Typo fix. 11 years ago
Richard C Isaacson 1e2eb88926 Replace mode with octal renaming to mode.
Closes GH-6176

This way for mode we return in an octal format which is immediately usable compared to transforming it later.
11 years ago
Richard Isaacson 6ffeaa7ddd Merge pull request #1 from bcoca/stat_updaates
added octal representation of mode and made md5 checksumming optional
11 years ago
Richard C Isaacson a707e858cd Minor cleanup. 11 years ago
Richard C Isaacson 3ca9fc64d5 copy module: cleanup and if directory_mode not set default to umask 11 years ago
Richard C Isaacson 326ed4eeeb Copy Module: Add the ability to set directory attributes on recursive copy.
Closes GH-6194.

These changes pass attribute modifications through to new directories during a recursive copy with an addition allowing for the directory mode to be set independantly.
11 years ago
James Cammarata b667e1d404 Add expanduser calls on src/dest in the module too 11 years ago
James Cammarata 1762557ff4 Merge branch 'devel' of https://github.com/muffl0n/ansible into muffl0n-devel 11 years ago
Brian Coca 21854d54d4 added octal representation of mode and made md5 checksumming optional
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
James Cammarata 6283754340 Fixing several bugs in assemble and updating tests
Bugfixes:
* the remote_src param was not being converted to a boolean correctly,
  resulting in it never being used by the module as the default behavior
  was remote_src=True (issue #5581)
* the remote_src param was not listed in the generic file params, leading
  to a failure when the above bug regarding remote_src was fixed
* the delimiter should always end with a newline to ensure that the file
  fragments do not run together on one line

Fixes #5581
11 years ago
James Cammarata 33d9a662ee Adding new tests for assemble role 11 years ago
James Cammarata d80b9ac137 Adding the backup destination to the resut dictionary for lineinfile 11 years ago
muffl0n 68bef304c8 already call expanduser in action_plugin 11 years ago
Michael DeHaan 62f8ebe51e Merge pull request #6036 from mxxcon/patch-1
docs_pull_request: Add parameters highlighting
11 years ago
James Cammarata f1ba67e547 Merge branch 'fix-5679' of https://github.com/jirutka/ansible into jirutka-fix-5679 11 years ago
mxxcon 544c08a211 docs_pull_request: Add parameters highlighting
Added highlighting to parameter references in docs so that they standout a bit better.
11 years ago
Michael DeHaan 77ac23cc26 Document ansible_managed changing the template. 11 years ago
Michael DeHaan b1e442639f Some minor docs corrections. 11 years ago
Richard C Isaacson 54c799d3fb Cleanup per notes.
Some small changes to per notes from @mpdehann.
11 years ago
Richard C Isaacson 9795eec24b Updates for the unarchive module and action_plugin.
There is a bit going on with the changes here. Most of the changes are cleanup of files so that they line up with the standard files.

PR #5136 was merged into the current devel and brought up to working order. A few bug fixes had to be done to get the code to test correctly. Thanks out to @pib!

Issue #5431 was not able to be confirmed as it behaved as expected with a sudo user.

Tests were added via a playbook with archive files to verify functionality.

All tests fire clean including custom playbooks across multiple linux and solaris systems.
11 years ago
Richard C Isaacson a3be027909 Merge remote-tracking branch 'pib/unarchive_remote' into pull_5136 11 years ago
Mike Grozak 3f74dd6592 Updated the force parameter description; added one example how to create the symlinks pointing to non-absolute paths 11 years ago
Mike Grozak ecd8b5d064 Found a way how to have symlinks towards files without absolute paths in prefixes; fixed incorrect force setting on the hard links, which can not point to non-existing files 11 years ago
Mike Grozak 4f262779cd Started the development of the 'chdir' functionality for file module - creation symlinks without the base directory prefix 11 years ago
jctanner 5a6fc3d940 Merge pull request #5363 from bcoca/acl_improved
acl module: acl now supports 'default'
11 years ago
Brian Coca 3aa3a42c45 fixed docstring and changed type to etype avoiding python builtin
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
jctanner 552ce8b68c Merge pull request #5051 from deontologician/patch-1
Added -FF flag to rsync invocation in synchronize
11 years ago
jctanner e13a10def7 Merge pull request #5127 from ovcharenko/patches
synchronize module: Added existing_only options to skip creating new files on receiver
11 years ago
jctanner 27362ebbf1 Merge pull request #5187 from 42wim/devel
Add support for --copy-links in synchronize
11 years ago
Michael DeHaan f16f2f23f5 Update copy
Update copy documentation to reference synchronize module
11 years ago
Wim 7b8918d37c Add support for --copy-links 11 years ago
Jan-Piet Mens 95c826a533 documentation typos 11 years ago
Jakub Jirutka ec80066cee Fixes #5679: lineinfile ignores newline in line argument 11 years ago
Laurent Defert 9fb39ce4aa Mark stat module as supporting check_mode 11 years ago
jctanner 95131937df Merge pull request #5282 from rhaido/hard_link_fix
file module: Added to the file module the functionality to force conversion hard link...
11 years ago
jctanner 87b58666f9 Merge pull request #5264 from drewlll2ll/file-fix
file module: Fixed missing prev_state == 'directory' in file
11 years ago
Aleksey Ovcharenko d8b160d385 Downgraded module version_added. 11 years ago
Michael DeHaan a11e5d609e Basic docsite formatting fixups 11 years ago
Michael DeHaan 0a3293cf53 add a note about raw/endraw 11 years ago
Michael DeHaan 0ad0f795f3 Merge pull request #5427 from bcoca/template_docs2
added more usefull example for jinja2 overrides
11 years ago
Brian Coca 9affb6ed37 added more usefull example for jinja2 overrides (this one is actually
used)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Maykel Moya 8f766bdcdd Missing "is" in file module description 11 years ago
Brian Coca bdd6eaa62a now handles default and allaows for either shorthand entry or specific
fields per entry section

the default option works both when added to entry or as stand alone.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Peter Salvatore 4c168abccc fix typo in synchronize module 11 years ago
Aleksey Ovcharenko 1b2d359a69 Added version_added 11 years ago
Jens Rantil 38d0df65d8 module(file): Fail instead of exit on exception 11 years ago
Jens Rantil 4262e76aec module(file): state what went wrong on exception 11 years ago
Mike Grozak 5a66a95bf3 Added to the file module the functionality to force conversion hard link and symlink when the force attribute is set to 'yes' 11 years ago
drewlll2ll 8fe3b05262 Added prev_state for directory 11 years ago
Jens Rantil b8347a3144 `file` module: Don't catch `SystemExit`
This fixes issue #5159.
11 years ago
James Tanner f210e0c862 Fixes #5109 synchronize module ssh port
Added a parameter for dest_port and also check ansible_ssh_port inventory variable.
11 years ago
Paul Bonser 4df9dd9232 Optionally unarchive a file already on the remote machine 11 years ago
James Tanner 4f9aadcc07 Addresses #5023 Fix import comments 11 years ago
James Tanner 38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Aleksey Ovcharenko 8413552642 Fixed a typo. 11 years ago
Michael DeHaan 4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan 9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
Josh Kuhn c2a59a97c4 Added note about .rsync-filter files, with example 11 years ago
Josh Kuhn eccaf457af Added -FF flag to rsync invocation in synchronize
The `-FF` option causes rsync to look for files in the source directory named `.rsync-filter` and uses them to filter directories underneath them. If no `.rsync-filter` files are found, the behavior is identical to the command run without the -FF option. This flag does not sync the .rsync-filter files themselves.

This change should be backwards compatible and not produce surprising behavior for users, since they are unlikely to create `.rsync-filter` files unintentionally.
11 years ago
greenbrian 74a2bf4369 Update unarchive
Modified argument order provided to unzip command as the -o was being interpreted as a file.
11 years ago
Aleksey Ovcharenko bb3a23d40a Added existing_only options to skip creating new files on receiver 11 years ago
Michael Scherer b3758f6ea4 Do not use construct not compatible with python 2.4, fix #5006 11 years ago
Joshua Lund 4b9227a673 Fixed a typo in the 'unarchive' module documentation 11 years ago
James Tanner aa0af14734 Fix pep8 errors in unarchive module 11 years ago
Michael DeHaan 08996d78d6 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
11 years ago
Evan Kaufman 2c8b761a65 Added replace module
Heavily based on existing lineinfile module, but where it literally tests a regexp against
*each individual line* of a file, this replace module is more analogous to common uses of
a `sed` or `perl` match + replacement of all instances of a pattern anywhere in the file.

Was debating adding `all` boolean or `count` numeric options to control how many
replacements to make in the destfile (vs currently replacing all instances)

Noted use of MULTILINE mode in docs, per suggestion from @jarv
11 years ago
James Tanner b982a3d353 Clean up erroneous lineinfile.orig file 11 years ago
James Tanner a3631638e5 Set required = True for src in unarchive module. 11 years ago
jctanner 4e76e6047d Merge pull request #4625 from pileofrogs/devel
unarchive module & action plugin
11 years ago
James Tanner 0f806cfdfa Merge pull request #4525 from ko-zu/ansible
Add a regexp parameter to assemble module to match or exclude filenames.
11 years ago
James Tanner 0f3093516d Merge pull request #4375 from pfalcon/ansible
copy: Implement recursive copying if src is a directory.
11 years ago
James Tanner 53ba890312 Fixes #4884 Do not prematurely exit from file module if src not defined 11 years ago
James Tanner 2e916df20f Add default for remote_src to assemble dostrings to avoid confusion 11 years ago
jctanner 28de7dab2f Merge pull request #4738 from bcoca/assemble_action_plugin
assemble can now use src from master/origin
11 years ago
James Tanner 1ad4f6e325 Fixes #4522 Document that comments in ini files will be discarded with the ini module 11 years ago
James Tanner 2c57b999fc Addresses #4801 Update file module docs to indicate behavior for relative src paths 11 years ago
jctanner f340f916b4 Merge pull request #4801 from sspans/devel
Add support for relative symlinks
11 years ago
James Tanner 39fdb934be Add doc example for lineinfile without a regexp parameter 11 years ago
James Tanner f8eea4e155 Merge pull request #4660 from kolbyjack/lineinfile_no_regexp 11 years ago
James Tanner 3ae95c8953 Fix merge conflict 11 years ago
James Tanner 7b3fbeee16 Addresses #4676 Add module notes about the behavior of sudo and the destination paths within the synchronize module. 11 years ago
James Tanner 403469bf19 Update synchronize docstrings for rsync_timeout parameter 11 years ago
James Tanner ae1248dee6 Add a timeout to the synchronize module to prevent infinite hangs while waiting on passwords for misconfigured users 11 years ago
sspans 9f322a5178 skip absolute path creation for old_src, not needed with the new relative links 11 years ago
sspans 4957115e51 only require absolute paths for hardlinks 11 years ago
James Tanner c3159fefab Fixes #4516 file module: check prev_state earlier and use that if state is not specified 11 years ago
Brian Coca 46b67e9b1f now assemble module is also action plugin and can use local source for
files
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Daniel Koch fc8b88995a Clean up temp file left behind by assemble module 11 years ago
Michael DeHaan 772bd33a0f Revert "fix conversion from file to hardlink when force=yes"
This reverts commit 4d4518ed52.
11 years ago
Michael DeHaan c44aceb986 Merge pull request #4380 from joshkehn/lineinfile_validate
Added validate option to lineinfile
11 years ago
Michael DeHaan 0f18ac92b4 Merge pull request #4632 from simonsd/devel
refusing to convert between file and hard when force=yes
11 years ago
jctanner 3c3392a2d9 Merge pull request #4167 from tima/rsync3
synchronization module take 3
11 years ago