Commit Graph

1256 Commits (e93b8f054e73c2997bf9037ef768dc0dfd20c4ef)

Author SHA1 Message Date
Sloane Hertel e93b8f054e [stable-2.8] aws_s3 - wait for the bucket before setting ACLs (#61735)
* Wait for the bucket to become available if possible before setting ACLs
(cherry picked from commit 91ccb03552)

Co-authored-by: Sloane Hertel <shertel@redhat.com>
6 years ago
kucharskim c087030e5c [stable-2.8] Allow 13 asterisk characters in password field without warning (#54893)
On OpenBSD, 13 asterisk characters as a password hash, marks the
account as disabled. Otherwise daily(8) script which executes
security(8) will email operator about not properly locked accounts.

Before the diff, we see following warning:

> [WARNING]: The input password appears not to have been hashed. The 'password' argument must be encrypted for this module to work properly.

After the diff, warning is gone..
(cherry picked from commit 1dea661ce8)

Co-authored-by: kucharskim <mikolaj@kucharski.name>
6 years ago
Mark Chesney 48e22639ee Fix creation of DigitalOcean droplets using digital_ocean_droplet module (#61655)
* Omit disallowed 'id' attribute in request body to create a droplet

* Add changelog fragment for PR #61655
6 years ago
Strahinja Kustudic aec6dc3b26 systemd module will now wait on deactivating state (#59471) (#60939)
* systemd module will now wait on deactivating state (#59471)

If a service is in the 'deactivating' state running systemctl stop foo,
would wait for the foo service to actually stop before it exits. The
module didn't behave like that and it considered the deactivating state
as if the service wasn't running. This change will align the module with
the systemctl behaviour.

(cherry picked from commit 54d9d7805d)

* Fix systemd start state with deactivating service state

(cherry picked from commit ee4b3b8854)
6 years ago
Klaus Frank 0af0a7f8bb Add exception handling to win_domain_controller (#58234)
* Add exception handling to win_domain_controller

* Add changelog

* Fix PSUseDeclaredVarsMoreThanAssignments

* Remove dns domain cannot be resolved error message

As requested by PR review in https://github.com/ansible/ansible/pull/58234#discussion_r300509880
6 years ago
Kevin Breit 6310e96034 [stable-2.8] - meraki_syslog - Properly handle net_id (#61744)
* meraki_syslog - Module properly handles net_id parameter (#57286)

(cherry picked from commit a50b3d7695)

* Add changelog fragment and clean up commented tests
6 years ago
yanzhangi bc0ea200d2 Update ce_bfd_global to fix bugs (#60477)
* Update ce_bfd_global to fix bugs

(cherry picked from commit c742ce8ee3)

* Update ce_bfd_global modified information
6 years ago
Paul Belanger d71d111c3a Fix nxos_install_os test cases typo (#58825)
This should be ansible_connection, not connection_type. We can also
update local testing logic.

Remove nxos_install_os/tasks/network_local.yaml as it is nolonger used.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
(cherry picked from commit 9e1b19e364)
6 years ago
Jordan Webb cc1bc400dd [stable-2.8] Fix pipelining in buildah connection plugin 6 years ago
Felix Fontein ccd0b5bede acme_certificate: make compatible to Buypass' ACME v2 testing endpoint (#60727)
* Don't unnecessarily use location from header.

* Add changelog.

(cherry picked from commit 7f4f2506a0)
6 years ago
Dmitriy Rabotyagov 9218856617 Search project in domain when it's defined
Since there might be several projects with the same name in different
domains, it's required to define domain_id during project search.
Otherwise openstacksdk will raise "Multiple matches found" error

(cherry picked from commit 33ab7ca162)
6 years ago
Martin Nečas 6468dcc4be Ovirt template search by datacenter backport (#60478)
* add changelog

* ovirt_vm update template search backport
6 years ago
pguermo c2f6576fbe proxmox_kvm: While a VM is beeing created, vm has no name item (#58196)
* While a VM is beeing created, vm as no name attribute

* Add changelogs fragment

(cherry picked from commit 8923d13537)
6 years ago
Martin Nečas a0ebf60dea ovirt_vm add linux boot param warning backport (#60581)
* ovirt_vm add linux boot param warning (#60474)

* ovirt_vm add kernel param check

* update check

* update docs phrase

* use douple quotes

* add changelog
6 years ago
Martin Nečas 1ff1e2d9a6 ovirt vm update kernel docs backport (#60582)
* ovirt vm update kernel docs (#60407)

* ovirt vm update kernel docs

* update doc phrase

* update docs

* add changelog
6 years ago
Felix Fontein b66433f47d docker_logout: report change on successful logout (#60381)
* Mark logout as changed when docker logout does not return 'Not logged in to '.

* Add changelog.

* Improve logout detection.

* Also return output of 'docker logout'.

(cherry picked from commit 99fb0fcb2f)
6 years ago
rob8714 9fe0971004 Backport/2.8/57418 (#60683)
* Backport to stable-2.8: Fix #56640: Map k8s ansible keys to api keys (#57418)

* Fix #56643: Map ansible keys to api keys

* Remove errant print line

* Fix pep8 issue

* Fix doc line

* Added test for validate_certs -> verify_ssl translation for k8s module

(cherry picked from commit 6e94b472e8)

* Removed proxy from AUTH_ARG_MAP and added fragment for backport

* Rename backport-57418.yaml to 60683-backport-57418.yaml

* Update 60683-backport-57418.yaml
6 years ago
Mitsuru Nakakawaji db9cb0682d fix: docker_swarm_service does not publish both tcp and udp ports (#60616)
* fix: docker_swarm_service does not publish both tcp and udp ports for same published port

* fix the linting problems and add the changelog fragment.

* add test

* modify test to ensure result rather than return value

(cherry picked from commit 064cd63f3d)
6 years ago
Felix Fontein 06623fb79a openssl_certificate: fix idempotency (#60745)
* Fix openssl_certificate idempotency.

* Add changelog.

* Add integration test.

(cherry picked from commit 0d88ec241f)
6 years ago
Klaus Frank ec50e1191f Backport: win_domain reboot required exception incorrectly reported (#60496) (#60809)
* win_domain reboot required exception incorrectly reported (#60496)

* Set reboot required dependent on exception message.

* Use exception id instead of it's message

* Add changelog fragment
6 years ago
Sloane Hertel b77abd0491 Warn when transforming constructed groups (#60912)
* Warn when transforming constructed groups

The `keyed_groups` field has used sanitization since 2.6, but `groups` only started doing so in 2.8.
This adds a warning for the change in behavior.

* changelog

(cherry picked from commit 3247626ac7)
6 years ago
Sam Doran 0bc1285987 [stable-2.8] fixes issue with recieve parameter idempotency (#59999) (#60541)
* [stable-2.8] fixes issue with recieve parameter idempotency (#59999)

fixes assert statements in unit tests
(cherry picked from commit c9a9621a02)

Co-authored-by: Wojciech Wypior <w.wypior@f5.com>

* Add changelog
6 years ago
Swartz, Nathan 6fc1f3ab1c Add changelog fragment for backporting PR #57096 to stable-2.8 branch 6 years ago
Toshio Kuratomi c4902421d9 New release v2.8.4 6 years ago
Martin Nečas 768e515a3e Ovirt host update force docs backport (#60475)
* add changelog

* Ovirt host update force docs (#60202)

* update docs

* update pep8 syntax

* update pep8 syntax
6 years ago
Gonéri Le Bouder 51a849c89f vmware_datastore_facts: don't modify dict in iter
With Python3, we cannot iterate on a dict and modify it at the same time.

Fixes #54869

(cherry picked from commit 339a0f4a8c)
6 years ago
Maxim Babushkin 282ab4cb72 openssh_keypair - Add public key and key comment validation (#57993)
- Split the key validation to separate private and public.
- In case public key does not exist, recreate it.
- Validate comment of the key.
- In case comment changed, update the private and public keys.

(cherry picked from commit 27e414200f)
6 years ago
Shachaf92 4bac987591 Backport/2.8/58943 - win_domain_group_membership extar_vars forests env fix 6 years ago
yanzhangi d350269da1 update ce_acl to fix bugs (#60357)
* update ce_acl to fix bugs (#60274)

(cherry picked from commit 66c3e9bb9b)

* Update ce_acl modified information
6 years ago
yanzhangi 34d3a80fb5 update ce_aaa_server_host to fix bugs (#60356)
* update ce_aaa_server_host to fix bugs (#60272)

(cherry picked from commit 9aabe70452)

* Update ce_aaa_server_host modified information
6 years ago
yanzhangi f4aaf4d148 update ce_aaa_server to fix bugs (#60355)
* update ce_aaa_server to fix bugs (#60270)

* update ce_aaa_server to fix bugs

* update ce_aaa_server to fix bugs

(cherry picked from commit c2e7683926)

* Update ce_aaa_server modified information
6 years ago
Yaakov Selkowitz 5d3f0fe02c facts: fix double-counting of CPUs on POWER systems (#58360)
On POWER systems, /proc/cpuinfo provides a 'processor' entry as a
counter, and a 'cpu' entry with a description (similar to 'model name'
on x86). Support for POWER in get_cpu_facts was added via the 'cpu'
entry in commit 8746e692c1.  Subsequent
support for ARM64 in commit ce4ada93f9
used the 'processor' entry, resulting in double-counting of cores on
POWER systems.

When unit tests were later written for this code in
commit 55306906cf, the erroneous values
were just accepted in the test instead of being diagnosed.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
(cherry picked from commit 93d9d64038)
6 years ago
Manu Lange 8e56708e22 prevent recursive logging csharp stackoverflow. (#59503)
* prevent recursive logging situation.

* Add changelog

(cherry picked from commit 6a5cd9a820)
6 years ago
silverwizard 1eb11edb14 Removed breaking type check from nagios module (#49568)
* Removed extraneous type check from nagios module, in order to allow python 3.x

* Removed now useless import types

* Added changelog fragment

* Update changelog.

* Rebased and removed check due to module adding earlier guardrails

* Updated changelog to mention earlier fix adding now completely removed guardrails

* Remove superfluous type checks. Fix docs type.

* Update ignore.txt.

(cherry picked from commit 5d8302120b)
6 years ago
Jill R 08e23a2a93 Don't truncate cidr_ipv6 addresses in ec2_group.py (#59106)
* Better cidr_ipv6 validation in ec2_group.py

* Improve warning/error handling, add changelog

* Update unit test for ipv6 validation

* Fix logic that was causing non /128 cidrs with host bits to not be handled

(cherry picked from commit 4308b87d72)
6 years ago
Martin Nečas b4b76c924c Ovirt vnic profile fix backport (#60198)
* update vnic profile docs

* vnic profile fix

* merge updates

* add changelog
6 years ago
Toshio Kuratomi 0bcfb05bad Fix changelog entry for playbook_dir fix
The final version of the fix makes the addition in two places instead of
moving the single addition from one place to another

(cherry picked from commit 84e3c0ef1d)
6 years ago
Matt Martz f44eb33000 [stable-2.8] Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI (#59557)
* Move plugin loader playbook dir additions back to Playbook instead of PlaybookCLI. Fixes #59548

* Restore cli additions
(cherry picked from commit 923e218)

Co-authored-by: Matt Martz <matt@sivel.net>
6 years ago
Toshio Kuratomi 3b987ae53d Add CVE number to changelog 6 years ago
Alex Stephen b0e2d90dcf cherrypick 6 years ago
Alex Stephen 2d14c0ce70 no logging for service account contents (#60149)
* no logging for service account contents

* changelog

* fixes
6 years ago
Jordan Borean a02c5c4683 win_user - use proper error code when failing to validate creds (#60181)
(cherry picked from commit 45d0e5994a)
6 years ago
Xu Yuandong d497d5865b Backport/2.8/60075 ce_rollback: set mmi-mode enable to run commands and unset after running. (#60075) (#60084)
* set mmi-mode enable to run commands nad unset after running. (#60075)


(cherry picked from commit 16e237e095)

* add a changelog fragment.
6 years ago
James Cassell 56639d0f68 TRANSFORM_INVALID_GROUP_CHARS: document "ignore" option (#57318) (#60289)
Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>
(cherry picked from commit c954c07271)
6 years ago
Xu Yuandong 4e94423e41 Backport/2.8/60071 ce_config : It is necessary to undo mmi-mode enable after running commands. (#60071) (#60085)
* It is necessary to undo mmi-mode enable after running commands. (#60071)


(cherry picked from commit 13c8f7b00c)

* add a changelog fragment.
7 years ago
Andrey Klychkov 81a5183428 Backport/2.8/60105: turn off the default db warning where it doesn't make sense (#60107)
* Bugfix 60043: turn off the default db warning where it doesn't make sense (#60105)

(cherry picked from commit d2cc9f5f06)

* Backport of 60105: turn off the default db warning where it doesn't make sense
7 years ago
Matt Martz 978dd9f541 [stable-2.8] Fix async output with adhoc callbacks. Fixes #15988 (#59935)
(cherry picked from commit df6b8d2)

Co-authored-by: Matt Martz <matt@sivel.net>
7 years ago
yanzhangi 215aa73843 update ce_bgp_af to fix bugs (#60032)
* update ce_bgp_af to fix bugs (#59678)

* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs

* update ce_vrrp to fix bugs

* update ce_bgp_af to fix bugs

* update ce_bgp_af to fix bugs

(cherry picked from commit d6fd4eb8e6)

* Update ce_bgp_af modified information

* Update ce_bgp_af modified information
7 years ago
yanzhangi f75fbf94f8 update ce_vrrp to fix bugs (#60034)
* update ce_vrrp to resolve conflicts

* Update ce_vrrp modified information

* Update ce_vrrp modified information
7 years ago
Xu Yuandong 777395ec18 Backport/2.8/59690 ce_netstream_template: update to fix a bug. (#59690) (#60033)
* ce_netstream_template: update to fix a bug. (#59690)

* update to fix a bug.

* Update ce_netstream_template.py

* Update ce_netstream_template.py

* Update ce_netstream_template.py

(cherry picked from commit adfbd04b3a)

* add  a changelog fragment.
7 years ago