Commit Graph

538 Commits (e7eab93243962e3f5b8de38f0d84d85c7e07fb47)

Author SHA1 Message Date
Michael DeHaan 565f336182 lineinfile should use 'search' everywhere 12 years ago
Michael DeHaan 14a9c3ab9e Line in file regexep should match a portion of the line, not the whole line! 12 years ago
Michael DeHaan 5b57011152 Merge pull request #1027 from mcodd/setup_bug_python24
setup not python24 compatible in 0.7
12 years ago
Michael DeHaan 335f136e71 Merge pull request #1023 from lorin/postgres-user-fix
Fix postgresql_user bug
12 years ago
Matt Coddington c0638842d8 make this python24 compatible 12 years ago
Lorin Hochstein b3b01bb7a3 Fix postgresql_user bug
If I create a database from scratch and assign permissions by doing:

      - name: ensure database is created
        action: postgresql_db db=$dbname

      - name: ensure django user has access
        action: postgresql_user db=$dbname user=$dbuser priv=ALL password=$dbpassword

Then it fails with the error:

  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 565, in <module>
    main()
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 273, in main
    changed = grant_privileges(cursor, user, privs) or changed
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 174, in grant_privileges
    changed = grant_func(cursor, user, name, privilege)\
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 132, in grant_database_privilege
    prev_priv = get_database_privileges(cursor, user, db)
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 118, in get_database_privileges
    r = re.search('%s=(C?T?c?)/[a-z]+\,?' % user, datacl)
  File "/usr/lib/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or buffer

This fix fixes the problem by not executing the regex if the
db query on pg_database returns None.
12 years ago
Seth Vidal 9d88b3eedd add import sys to virt module b/c it needs it if the libvirt python
module is missing
12 years ago
Michael DeHaan 4280e00d56 Merge pull request #1000 from mavimo/patch-1
Add support to removes control param
12 years ago
Michael DeHaan 7ef3e7dccb Merge pull request #1003 from bladypirat/devel
added support for custom port definition for postgresql_* modules
12 years ago
Michael DeHaan 49bef3f6c2 Merge pull request #1005 from dagwieers/cmdline
Add /proc/cmdline information to the default facts
12 years ago
Jan-Piet Mens b36aa61237 Add support for RSA/DSA SSH host key detection in setup module for OS/X
s/<8spaces>/<4spaces>/g
12 years ago
Dag Wieers d158218c3f Add /proc/cmdline information to the default facts
The use-case here is that based on information in the /proc/cmdline certain actions can be taken.

A practical example in our case is that we have a play at the end of the provisioning phase that reboots the system. Since we don't want to accidentally reboot a system (or restart the network) on a production machine, having a way to separate an Anaconda post-install (sshd in chroot) with a normal system is a good way to make that distinction.

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "not '${ansible_cmdline.BOOT_IMAGE}'.startswith('$')"

A practical problem here is the fact that we cannot simply check whether it is set or empty:

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "'${ansible_cmdline.BOOT_IMAGE}'"

If ansible_cmdline was a string, a simple only_if: "'${ansible_cmdline}'.find(' BOOT_IMAGE=')" was an option, but still not very "beautiful" :-/

This implementation uses shlex.split() and uses split(sep, maxsplit=1).
12 years ago
Piotr Kweclich 8360f9f46c added support for custom port definition 12 years ago
Marco Vito Moscaritolo 2dd430d9c0 Add support to removes control param
Execute action only if specified file using param removes exist (execute reverse control of creates).

Some usage eg.:

```yaml
- name: enable apache2 default websites
  action: command /usr/sbin/a2ensite $item
creates=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl

- name: disable apache2 default websites
  action: command /usr/sbin/a2dissite $item
removes=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl
```
12 years ago
Michael DeHaan eed031cd82 Check for ipv6 12 years ago
Michael DeHaan aa704a6111 backuplocal => backup_local for API standardization reasons 12 years ago
Michael DeHaan b97e2a6f5a Merge branch 'backup-common' of https://github.com/dhozac/ansible into devel 12 years ago
Michael DeHaan c69c3d6e18 Merge pull request #995 from mattupstate/devel
Use `get_bin_path` properly for supervisorctl module
12 years ago
Daniel Hokka Zakrisson a5d63532d3 Add backup to assemble 12 years ago
Daniel Hokka Zakrisson 2a8b92954f Add backups to lineinfile 12 years ago
Daniel Hokka Zakrisson dfcb9d3c2d Move backup to module_common 12 years ago
willthames 8b8eae7d82 Allow ~ expansion in chdir argument of command module
This allows the use of ~ in the chdir argument of the command module
I know the later change is absolutely necessary as the first change
was not sufficient. It may be that the first change fixes shell and
the second fixes command.
12 years ago
willthames d4c4a51866 Subversion dest should allow ~ expansion
Used os.path.expanduser on dest to allow e.g. ~/svn/repo as
a destination
12 years ago
Michael DeHaan 8f220a4f77 Always pipe stderr in the setup module to avoid JSON interference. 12 years ago
Matt Wright d52f1d969b Use `get_bin_path` properly 12 years ago
Matt Wright a092eadbbb Fix supervisorctl module after merge issue 12 years ago
Michael DeHaan 8e02b165f1 chmod +x 12 years ago
Michael DeHaan b0ac7e07b0 Merge branch 'binpath' of https://github.com/sfromm/ansible into devel
Conflicts:
	library/supervisorctl
12 years ago
Michael DeHaan a454db5345 Merge pull request #970 from mattupstate/devel
Improve apt_repository and supervisorctl
12 years ago
Michael DeHaan 90f051f818 Merge pull request #971 from sfromm/seboolean
Add seboolean module
12 years ago
Michael DeHaan 092bd8e3da make parameter required 12 years ago
Michael DeHaan 4da4c31dfb Merge pull request #974 from goozbach/add_selinux_module
add selinux module
12 years ago
Derek Carter 2aa760a3fc add selinux module 12 years ago
Stephen Fromm 6742e9c3f4 Add option required=(True|False) to get_bin_path and update modules
Added required as optional argument to get_bin_path(). It defaults to
false.  Updated following modules to use required=True when calling
get_bin_path():  apt_repository, easy_install, group, pip,
supervisorctl, and user.
Also removed _find_supervisorctl() from supervisorctl module and updated
_is_running() to not need it.
12 years ago
Matt Wright b93df1fc60 Update handling of state changes 12 years ago
Matt Wright bdfccbfb34 Move conditional that accounts for variances in distros/versions to work when removing and adding. 12 years ago
Stephen Fromm 97c2e58081 Add seboolean module
Will manage values of seboolean on a host.  Options are name (name of
boolean), state (on or off), and persistent (on or off).  Persistent
defaults to no.
12 years ago
Stephen Fromm e5a635672c Migrate remaining modules to use get_bin_path in module_common.py
* Migraed easy_install, pip, service, setup, and user.
* Updated fail_json message in apt_repository
* Fixed easy_install to not hardcode location of virtualenv in
  /usr/local/bin/.
* Made handling of virtualenv more consistent between easy_install and
  pip.
12 years ago
Stephen Fromm bdb39058ae Migrate apt_repository, group, and supervisorctl to use module.get_bin_path 12 years ago
Daniel Hokka Zakrisson ed8e31d618 Add a lineinfile module 12 years ago
Michael DeHaan d0994cd169 Merge branch 'setup-no-dash-facts' of https://github.com/tima/ansible into devel
Conflicts:
	library/setup
12 years ago
Matt Wright a82928e7dc fix bug in supervisorctl module 12 years ago
Timothy Appnel 8c32aefc80 Replace - with _ in setup module key names to avoid variable access problems reported in #954 12 years ago
Michael DeHaan f9e9753141 Remove obsolete comment 12 years ago
Michael DeHaan d7eed66a06 Merge pull request #951 from gottwald/devel-git-sudo-fix
Added cwd to tempdir in git clone method. Fixes usage with sudo.
12 years ago
Ingo Gottwald 30fdd56560 Added cwd to tempdir in git clone method. Fixes usage with sudo. 12 years ago
Tim Bielawa 6b73907811 Change from a module config file to brute force locating the nagios configs so we can find the command file. 12 years ago
Tim Bielawa 98d3e2bfc8 Nagios is executable now 12 years ago
Tim Bielawa 8b8aaa7f76 Fix copying that special character 12 years ago
Tim Bielawa da2665bcd2 In-line docs. 12 years ago