Commit Graph

21551 Commits (e4ac7166634535801f285759cefc1fd75382a67d)
 

Author SHA1 Message Date
James Cammarata ca5b361ad8 Reworking iterator logic regarding failed states during always
Previous changes addressed a corner case, which unfortunately introduced
another bug. This patch adds a new flag to the host state (did_rescue) which
is set to true when the rescue portion of a block completes. This flag is
then checked in _check_failed_state() when the fail_state != FAILED_NONE.

This lead to the discovery of another bug - current strategies are not advancing
hosts to ITERATING_COMPLETE after doing a peek at the next task, leaving the
host state in the run_state of the final task. To address this, before gathering
the list of failed hosts in StrategyBase.run(), a final pass through the iterator
for all hosts is done to ensure each host is in its final state. This way, no
strategy derived from StrategyBase has to worry about it and it's handled.

Fixes #17983
8 years ago
Brian Coca afaec3da82 corrected service filtered option to singular 8 years ago
William L. Thomson Jr fe95d71fbd docsite/rst/playbooks_tags.rst: Added section on tag reuse (#17729)
* docsite/rst/playbooks_tags.rst: Added section on tag reuse

* Update playbooks_tags.rst

Minor grammatical clarification.
8 years ago
Brian Coca 387ad9a980 updated changelog with configurable strategy 8 years ago
Gael Pasgrimaud f94100aa87 make default strategy configurable (#18394) 8 years ago
Brian Coca bd70397e24 always template when called from template (#18490)
* Have template action plugin call do_template

Avoids all the magic done for 'inline templating' for ansible plays.
renamed _do_template to do_template in templar to make externally accessible.
fixes #18192

* added backwards compat as per feedback
8 years ago
James Cammarata fcb033b9e4 Add `name` field for Blocks
Fixes #18420
8 years ago
James Cammarata 57cf5e431c Catch loop eval errors and only raise them again if the task is not skipped
This should help on issues like #16222.
8 years ago
Matt Clay 4981feee99 Update submodule refs. 8 years ago
Toshio Kuratomi c22dde615d Add a tool to work with module metadata (#18488)
* Add a tool to work with module metadata

* Don't hardcode async_wrapper
8 years ago
Brian Coca aab80ac353 removed package from squash in examples 8 years ago
Brian Coca c005ae3cd9 removed package from squash actions
fixes https://github.com/ansible/ansible-modules-core/issues/5595
8 years ago
James Cammarata 435ca620b2 Add option to prepend inherited attributes when extending values
Fixes #18483
8 years ago
Brian Coca 11465134fa added alias to argumetns 'args' to blacklist (#18485)
this should fix https://github.com/ansible/ansible-modules-core/issues/5584
8 years ago
Brian Coca f4391d34e4 added alias to argumetns 'args' to blacklist
this should fix https://github.com/ansible/ansible-modules-core/issues/5584
8 years ago
Adrian Likins 0690a67926 Include missing _text.to_text import
Fixes "global name 'to_text' is not defined" error on
openbsd clients.

Fixes #18473
8 years ago
René Moser b08ef44da0 cloudstack: extend support for VPC (#18434) 8 years ago
Chris Church 534bd12ae9 Increment changed stat for a failed task if changed. (#18014) 8 years ago
James Cammarata 4f06a86161 Alternately track listening handlers by uuid if no name is set
Fixes #17846
8 years ago
Adrien Vergé 527d8307c1 Lint YAML files under test/
This commit extends YAML linting by enabling standard rules from the
`yamllint` tool [1]. Since syntax errors and key duplicates are already
checked since 4d48711, this change only adds detection for cosmetic
problems. It also narrows checks to the test/ dir only.

The main goal is to prevent future problems to enter the code base
without being noticed. While it would be a huge effort to be PEP8
compliant, it is relatively easy to have correct YAML style *now* and
prevent future errors by enabling linting.

Note: for those (like me) caring about code attribution: use `git blame
-w` to ignore whitespace-only changes.

Note: I disabled some linting checks (such as indentation), they can be
enforced in the future if needed. Similarly, current checks can also be
disabled. See the `.yamllint` file.

[1]: https://yamllint.readthedocs.io/
8 years ago
Adrien Vergé 0e834fc9e4 Fix cosmetic problems in YAML source
This change corrects problems reported by the `yamllint` linter.

Since key duplication problems were removed in 4d48711, this commit
mainly fixes trailing spaces and extra empty lines at beginning/end of
files.
8 years ago
Trond Hindenes 8874c1dc39 Improved Get-PendingRebootStatus 8 years ago
John R Barker de13f91a50 Update docker-setup-rht.yml 8 years ago
Matt Davis 39dcafe23f bump submodule refs 8 years ago
James Cammarata bd4f7fca27 Fixing incorrect use of version_compare in docker integration test 8 years ago
Tom Melendez b9e07c8dd7 [GCE] updates to gce integration test (#18097)
* Added test for sequenced-name instance generation (num_instances)
* Added param-check tags to tests that only do argument checking
Should be merged AFTER ansible/ansible-modules-core#4276
8 years ago
Brian Coca 3fd03b764b removed core import template 8 years ago
John R Barker 3d428da445 ROADMAP updates (#18435)
* ROADMAP updates

* Formatting - Especially the first section
* Reno Release notes is out of scope (I believe?)
* Change "Speed up make webdocs to stretched Goal - As I don't believe we currently know *how* we can achieve this
* Removed the word `Hardening` as it implies security, which isn't something we are actively working on in 2.3
8 years ago
James Cammarata 5b87951d6c Don't copy the parent block of TaskIncludes when loading statically
When loading an include statically, we previously were simply doing a
copy() of the TaskInclude object, which recurses up the parents creating
a new lineage of objects. This caused problems when used inside load_list_of_blocks
as the new parent Block of the new TaskInclude was not actually in the list
of blocks being operated on. In most circumstances, this did not cause a
problem as the new parent block was a proper copy, however when used in
combination with PlaybookInclude (which copies conditionals to the list of
blocks loaded) this untracked parent was not being properly updated, leading
to tasks being run improperly.

Fixes #18206
8 years ago
Samuel Boucher b17149f3bf Update ansible.1.asciidoc.in (#18464)
* Update ansible.1.asciidoc.in

fix typo to match ansible --help
--su-user and not --se-user

* Update ansible.1.asciidoc.in
8 years ago
René Moser 80af461178 cloudstack: add additional CLOUDSTACK_VPC env var (#18467) 8 years ago
Matt Clay 3f785ee173 Remove unnecessary file. 8 years ago
Matt Clay c955688772 Move ansible ad-hoc tests to integration targets. 8 years ago
Brian Coca c880c1a78d added sysv functions 8 years ago
Matt Clay ac8842eee8 Fix unit test dirs to match code under test. 8 years ago
jctanner 05f02371ce Add a check for type() instead of isinstance() (#18439) 8 years ago
Jason McKerr e9b193d6ae Update ROADMAP_2_3.rst 8 years ago
Matt Clay 2ab2e709b0 Update submodule refs. 8 years ago
Abhijit Menon-Sen be8dd049ee Merge pull request #18455 from agaffney/bare_variable_docs
Fix bare variable references in docs
8 years ago
Andrew Gaffney a625bfc8db Fix bare variable references in docs 8 years ago
John R Barker 947e0f264e Network Tests - Extend examples (#18451) 8 years ago
scottb abc9133cb6 Merge pull request #12712 from ananyacleetus/patch-1
Update DOCUMENTATION.yml
8 years ago
scottb d3c44fa98f Merge pull request #17988 from samdoran/docs-fix
Change ie to i.e. and add a bit more clarity
8 years ago
scottb 73a5fa2ddd Update playbooks_roles.rst
Minor edit.
8 years ago
scottb 8681ae4224 Merge pull request #15673 from wenottingham/patch-11
Update faq.rst
8 years ago
scottb 1d8bb62c9f Merge pull request #18134 from gmella/devel
fix hosts.yml filename for inventory
8 years ago
scottb ba757dc480 Merge pull request #18424 from dmsimard/patch-1
Update the link to the os-client-config repository
8 years ago
Abhijit Menon-Sen 3072d75bcc Fix doc typos and one entirely incorrect assertion 8 years ago
Rene Moser 1327230ebf changelog: add FreeIPA modules 8 years ago
Matt Clay 8552ad6bf1 Fix docker connection unit tests.
- Use assertRaisesRegexp to make sure correct exceptions are raised.
- Set docker_command to avoid docker dependency (skips find_executable).
- Use a fake path for docker_command to make sure mock.patch is working.
8 years ago