10 Commits (e3ea89801bae73921b298e7b4628860a272e942c)

Author	SHA1	Message	Date
Matt Martz	adb886e4ce	Speed up units using time.sleep by mocking or shortening sleep time (#61064) ... * Speed up units using time.sleep by mocking or shortening sleep time * Only use durations when not a collection	5 years ago
Andrey Klychkov	21863d48f3	unit tests: remove unused imports (#60462)	5 years ago
Andrey Klychkov	32de51adac	Unit tests: remove unused imports (#59740)	5 years ago
Toshio Kuratomi	3fba006207	Update bare exceptions to specify Exception. ... This will keep us from accidentally catching program-exiting exceptions like KeyboardInterupt and SystemExit.	6 years ago
Matt Clay	3033fd96b0	Move unit test compat code out of `lib/ansible/`. (#46996) ... * Move ansible.compat.tests to test/units/compat/. * Fix unit test references to ansible.compat.tests. * Move builtins compat to separate file. * Fix classification of test/units/compat/ dir.	6 years ago
Toshio Kuratomi	52449cc01a	AnsiballZ improvements ... Now that we don't need to worry about python-2.4 and 2.5, we can make some improvements to the way AnsiballZ handles modules. * Change AnsiballZ wrapper to use import to invoke the module We need the module to think of itself as a script because it could be coded as: main() or as: if __name__ == '__main__': main() Or even as: if __name__ == '__main__': random_function_name() A script will invoke all of those. Prior to this change, we invoked a second Python interpreter on the module so that it really was a script. However, this means that we have to run python twice (once for the AnsiballZ wrapper and once for the module). This change makes the module think that it is a script (because __name__ in the module == '__main__') but it's actually being invoked by us importing the module code. There's three ways we've come up to do this. * The most elegant is to use zipimporter and tell the import mechanism that the module being loaded is __main__: * 5959f11c9d/lib/ansible/executor/module_common.py (L175) * zipimporter is nice because we do not have to extract the module from the zip file and save it to the disk when we do that. The import machinery does it all for us. * The drawback is that modules do not have a __file__ which points to a real file when they do this. Modules could be using __file__ to for a variety of reasons, most of those probably have replacements (the most common one is to find a writable directory for temporary files. AnsibleModule.tmpdir should be used instead) We can monkeypatch __file__ in fom AnsibleModule initialization but that's kind of gross. There's no way I can see to do this from the wrapper. * Next, there's imp.load_module(): * https://github.com/abadger/ansible/blob/340edf7489/lib/ansible/executor/module_common.py#L151 * imp has the nice property of allowing us to set __name__ to __main__ without changing the name of the file itself * We also don't have to do anything special to set __file__ for backwards compatibility (although the reason for that is the drawback): * Its drawback is that it requires the file to exist on disk so we have to explicitly extract it from the zipfile and save it to a temporary file * The last choice is to use exec to execute the module: * https://github.com/abadger/ansible/blob/f47a4ccc76/lib/ansible/executor/module_common.py#L175 * The code we would have to maintain for this looks pretty clean. In the wrapper we create a ModuleType, set __file__ on it, read the module's contents in from the zip file and then exec it. * Drawbacks: We still have to explicitly extract the file's contents from the zip archive instead of letting python's import mechanism handle it. * Exec also has hidden performance issues and breaks certain assumptions that modules could be making about their own code: http://lucumr.pocoo.org/2011/2/1/exec-in-python/ Our plan is to use imp.load_module() for now, deprecate the use of __file__ in modules, and switch to zipimport once the deprecation period for __file__ is over (without monkeypatching a fake __file__ in via AnsibleModule). * Rename the name of the AnsiBallZ wrapped module This makes it obvious that the wrapped module isn't the module file that we distribute. It's part of trying to mitigate the fact that the module is now named __main)).py in tracebacks. * Shield all wrapper symbols inside of a function With the new import code, all symbols in the wrapper become visible in the module. To mitigate the chance of collisions, move most symbols into a toplevel function. The only symbols left in the global namespace are now _ANSIBALLZ_WRAPPER and _ansiballz_main. revised porting guide entry Integrate code coverage collection into AnsiballZ. ci_coverage ci_complete	6 years ago
Anil Kumar Muraleedharan	bada3afee9	Adding module enos_config and its UT files (#33081) ... * Adding module enos_config and its UT files * Removing trailing line * Removing trailing lines * Editing enos_module.py to fix build errors * Removing blank lines in end * Updating enos_config.py based on review comments * Adding one more blank line * Removing training white space * Removing test_enos_config_force method from UT * Updating documentation * Comments by John, Remove version_added: "2.5"	7 years ago
Pilou	a5c9726502	Unit tests: share common code (#31456) ... * move set_module_args to units.modules.utils * unit tests: reuse set_module_args * unit tests: mock exit/fail_json in module.utils.ModuleTestCase * unit tests: use module.utils.ModuleTestCase * unit tests: fix 'import shadowed by loop variable'	7 years ago
Anil Kumar Muraleedharan	177a4fb3ec	Adding enos_command module and unit test (#32782) ... * Adding git_command module and its UT file * Changing Author Name and removing 2 blank lines * Removing blank lines * Adding enos_config and its UT files * Removing config module as I am allowed to have only module per PR * Work on Ganesh's Review comments * John Review Comments on enos_command.py * Review comments of John	7 years ago
Anil Kumar Muraleedharan	9d98452032	New enos_facts, + module_utils/enos.py. modifying copyright year in rest all (#31696) ... * Squashing all commits to one as suggested by John * Adding Unit test method for the module enos_facts.py * Pep8 and Ylint issues addressed * Trying again to remove blank line. Some scripts are required for this. * Bug Fixing for interfaces * Editing for over indenting issue * E203 whitespace before ',' * Update enos.py Added warnings argument as to check_args method * Update enos_facts.py Added warnings to check_args method	7 years ago