Commit Graph

27 Commits (e3b7bf0bf942536206e5a73907b8053945618721)

Author SHA1 Message Date
Shawn Siefkas 528f9a1d0b Check mode fix for ec2_group module (#2184)
The default VPC egress rules was being left in the egress rules for
purging in check mode.  This ensures that the module returns the correct
change state during check mode.
8 years ago
Shaun Brady 890bba6a0e Make group_name resolution VPC aware
EC2 Security Group names are unique given a VPC.  When a group_name
value is specified in a rule, if the group_name does not exist in the
provided vpc_id it should create the group as per the documentation.

The groups dictionary uses group_names as keys, so it is possible to
find a group in another VPC with the name that is desired.  This causes
an error as the security group being acted on, and the security group
referenced in the rule are in two different VPCs.

To prevent this issue, we check to see if vpc_id is defined and if so
check that VPCs match, else we treat the group as new.
8 years ago
Michael Pappas d26bb2eb41 Prevent ec2group from deleting sgs during check_mode runs 8 years ago
codemeup @ Work 7314cc3867 Fixing error exception handling for python3. Does not need to be compa… (#3840)
* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing error exception handling for python. Does not need to be compatible with Python2.4 b/c boto is Python 2.6 and above.

* Fixing compile time errors IRT error exception handling for Python 3.5.
This does not need to be compatible with Python2.4 b/c Boto is Python 2.6 and above.
8 years ago
Neil Saunders 6aa0cd4457 Fix for issue #3109: Executing ec2_group with rules fails with "Invalid rule parameter '['" 9 years ago
Brian Coca c4f64d822c changed modules to use common ec2 docs for region 9 years ago
Selivanov Pavel ec24a86f69 ec2_group.py: added ICMP rule example 9 years ago
Toshio Kuratomi 42d3d02855 Merge pull request #51 from cewood/ec2-group/cidr-ip-list
Support specifying cidr_ip as a list
9 years ago
Cameron Wood (@cewood) 4241d940b7 Support specifying cidr_ip as a list
Update/fix to Support specifying cidr_ip as a list

Unicode isn't compatible with python2, so we needed some other
solution to this problem. The simplest approach is if the ip item
isn't already a list, simply convert it to one, and we're done.
Thanks to @mspiegle for this suggestion.
9 years ago
Mike Putnam 6c0e264806 Add missing GPLv3 License header
Fixes #1643
9 years ago
Greg DeKoenigsberg 28a869a030 Updating cloud modules with proper github author information 9 years ago
Robert Estelle 9b7de40922 EC2 Security Group - Validate parameters. 9 years ago
Brian Coca 32102f7e69 Merge pull request #1472 from bennojoy/fix_11177
fix for 11177 where module readds rule even if the rules exists
9 years ago
Brian Coca f5ff5ba348 reverting pep changes that were breaking documentation 9 years ago
Benno Joy 6b9e9fe05d fix for 11177 where module readds rule even if the rules exists 9 years ago
marko 5f5be7bc2a Added support for foreign security groups (Fixes: #373) 9 years ago
zimbatm 34378b6c6a ec2_group: prioritise current VPC group names over others 10 years ago
zimbatm 8a4d5856ce ec2_group: select own group if the name matches
This fixes an issue where multiple VPC have the same group name and
the one from the other VPC is selected.
10 years ago
steenzout d960dc1584 issue #994: use HAS_BOTO to determine if import was successful:
- removed import of sys module.
- HAS_BOTO constant to check if import was successful.
- trigger a failure when import fails.
- removed unnecessary imports.
10 years ago
Brian Coca adfcfa4b58 Merge pull request #318 from preo/ec2-group-empty-rules
Allow empty EC2 Security Group rules.
10 years ago
Joel Thompson 01c4ff922f Fixes issue 697 -- only purge the grants that need to be purged 10 years ago
Kale Franz 73172fae47 #531 correction
correct list comprehension for older versions of python (back to python 2.4)
10 years ago
Kale Franz e174c9b474 fixes #529 ec2_group module bug 10 years ago
Michael DeHaan e7c92a6bc6 More EC2 doc tweaks 10 years ago
Robert Estelle 5e694c490c ec2_group allow empty rules. 10 years ago
follower a6e0d9d613 Fix typo of "rules_egress"
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.

Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
10 years ago
Brian Coca 0c4adcb2c6 made subcategories for cloud modules for better organization 10 years ago