ansible

Commit Graph

Author	SHA1	Message	Date
Felix Fontein	7a957ba64a	openssl_certificate: fix passphrase handling for cryptography backend (#56155 ) * Make sure passphrase is bytes string. * Fix typo. * Add more passphrase tests. * Fix test names. * Add changelog.	6 years ago
Felix Fontein	cb5c57bcd5	openssl_csr: fix idempotency problems (#55142 ) * Add test for generating a CSR with everything, and testing idempotency. * Proper SAN normalization before comparison. * Fix check in cryptography backend. * Convert SANs to text. Update comments. * Add changelog.	6 years ago
Felix Fontein	188903448a	openssl_*: add backup option (#54294 )	6 years ago
Felix Fontein	90c067e947	openssl_* modules: private key errors (#54088 ) * Improve error handling, in particular with respect to private key loading problems. * Add tests to validate that modules regenerate invalid input and don't crash. * Don't crash when input is invalid. * Create 'better' broken input. * Fix paths. * Simplifying pyOpenSSL error handling.	6 years ago
Felix Fontein	caf7fd2245	openssl_: improve passphrase handling for private keys in PyOpenSSL (#53489 ) Raise OpenSSLBadPassphraseError if passphrase is wrong. * Improve handling of passphrase errors. Current behavior for modules is: if passphrase is wrong (or wrongly specified), fail. Current behavior for openssl_privatekey is: if passphrase is worng (or wrongly specified), regenerate. * Add changelog. * Add tests. * Adjustments for some versions of PyOpenSSL. * Update lib/ansible/modules/crypto/openssl_certificate.py Improve text. Co-Authored-By: felixfontein <felix@fontein.de>	6 years ago
Felix Fontein	b2e992cecd	openssl_csr: improve subject validation (#53198 ) * Improve subject field validation. * Add country name idempotency test. * Add failed country name test. * Add changelog.	6 years ago
Felix Fontein	628326b879	openssl_csr: improve invalid SAN error messages (#53201 ) * Improve invalid SAN error messages. * Add changelog.	6 years ago
Felix Fontein	9b1cbcf3a4	openssl_csr: ignore empty strings in altnames (#51473 ) * Ignore empty strings in altnames. * Add changelog. * Add idempotence check without SAN. * Fix bug in cryptography backend.	6 years ago
Felix Fontein	345011e024	openssl_csr cryptography backend, try II (#50894 ) * Revert "Revert "openssl_csr: Allow to use cryptography as backend (#50324)"" This reverts commit `bbd2e31e9f`. * Remove more complicated selection copy'n'pasted from openssl_privatekey. * Add tests for backend selection. * Add openssl_csr test for arbitrary string commonName. * Allow to disable commonName -> SAN copying (fixes #36690).	6 years ago
Felix Fontein	bbd2e31e9f	Revert "openssl_csr: Allow to use cryptography as backend (#50324 )" This reverts commit `409f8a15bd`.	6 years ago
Felix Fontein	409f8a15bd	openssl_csr: Allow to use cryptography as backend (#50324 ) * Allow to use cryptography as backend for openssl_csr. * Use different curve. * Adding changelog. Includes changelog fragment for #49416, which didn't include one.	6 years ago
Felix Fontein	a5bf71ac6a	openssl_csr: idempotency doesn't work correctly for keyUsage (#50361 ) * Fix key usage idempotency bug. * Extend tests. * Add changelog.	6 years ago
Felix Fontein	e1218ca10f	Elliptic curve tests for crypto modules (#50109 ) * Add openssl_csr ECC test. * Add openssl_publickey ECC test. * Add openssl_certificate ECC test.	6 years ago
Felix Fontein	d1f19125a5	openssl_csr: added support for the OCSP Must Staple extension (#35082 ) * Added support for the OCSP Must Staple extension. * Trying to clean up magic constants a bit.	7 years ago
MarkusTeufelberger	9ea1b18ff7	Allow multiple values per key in name fields in openssl_certificate/csr (#30338 ) * allow multiple values per key in name fields in openssl_certificate * check correct side of comparison * trigger only on lists * add subject parameter to openssl_csr * fix key: value mapping not skipping None elements * temporary fix for undefined "subject" field * fix iteration over subject entries * fix docs * quote sample string * allow csr with only subject defined * fix integration test * look up NIDs before comparing, add hidden _strict params * deal with empty issuer/subject fields * adapt integration tests * also normalize output from pyopenssl * fix issue with _sanitize_inputs * don't convert empty lists * workaround for pyopenssl limitations * properly encode the input to the txt2nid function * another to_bytes fix * make subject, commonname and subjecAltName completely optional * don't compare hashes of keys in openssl_csr integration tests * add integration test for old API in openssl_csr * compare keys directly in certificate and publickey integration tests * fix typo	7 years ago
Matt Martz	4fe08441be	Deprecate tests used as filters (#32361 ) * Warn on tests used as filters * Update docs, add aliases for tests that fit more gramatically with test syntax * Fix rst formatting * Add successful filter, alias of success * Remove renamed_deprecation, it was overkill * Make directory alias for is_dir * Update tests to use proper jinja test syntax * Update additional documentation, living outside of YAML files, to reflect proper jinja test syntax * Add conversion script, porting guide updates, and changelog updates * Update newly added uses of tests as filters * No underscore variable * Convert recent tests as filter changes to win_stat * Fix some changes related to rebasing a few integration tests * Make tests_as_filters_warning explicitly accept the name of the test, instead of inferring the name * Add test for tests_as_filters_warning * Update tests as filters in newly added/modified tests * Address recent changes to several integration tests * Address recent changes in cs_vpc	7 years ago
Yanis Guenane	0648e339a7	openssl: remove static dict for keyUsage (#30339 ) keyUsage and extendedKeyUsage are currently statically limited via a static dict defined in modules_utils/crypto.py. If one specify a value that isn't in there, idempotency won't work. Instead of having static dict, we uses keyUsage and extendedKyeUsage values OpenSSL NID and compare those rather than comparing strings. Fixes: https://github.com/ansible/ansible/issues/30316	7 years ago
MarkusTeufelberger	2186b04934	Add simple integration test for openssl_certificate (#29038 ) * openssl_certificate: Fix parameter assertion in Python3 Parameter assertion in Python3 is broken. pyOpenSSL get_X() functions returns b'' type string and tries to compare it with '' string, leading to failure. The error mentionned above has been fixed by sanitizing the inputs from a user to the assert only backend. Also, this error was hidden by the fact that the improper check method was called in the generate() functions. * Add simple integration test for openssl_certificate * remove subject == issuer assertion * run integration tests only on supported hosts * change min supported version to 0.15.x * Add test for more CSR fields * also convert dict members to bytes * fix version_compare * openssl_{csr, certificate}: Fail if pyOpenSSL <= 0.15 Previous 0.13 pyOpenSSL was a C-binding, and required the parameter passed to add_extention to be in ASN.1. This has changed with the move to 0.14 and it is now all pythong and string based. Previous the 0.15 release, the `get_extensions()` method didn't exist, since the modules rely heavily on it we ensure pyOpenSSL version is at last 0.15.0. * check pyopenssl version in openssl_csr integration test	7 years ago
Yanis Guenane	8b22c45a45	Enable integration tests for the crypto/ namespace (#26684 ) Crypto namespace contains the openssl modules. It has no integration testing as of now. This commits aims to add integration tests for the crypto namespace. This will make it easier to spot breaking changes in the future. This tests currently apply to: * openssl_privatekey * openssl_publickey * openssl_csr	7 years ago

19 Commits (e32d60bbcd44ccc7761268c6d6f00db036db962b)