2 Commits (e0558ac1938e7df5e3070d01567ef80bc4046b1e)

Author	SHA1	Message	Date
Rick Elrod	2ad10ffe43	hostname: Make strategies consistent, drop py2.4 ... Change: - Make strategies behave consistently and return the empty string instead of "UNKNOWN" (or "temporarystub") for the "before" value if the permanent hostname file does not exist or could not be read. - Switch to `with open()` instead of annoying exception handling code (which was wrong and leaked file handles in several places). This drops Python 2.4 support for this module. - Updated porting guide since users could be relying on these former, inconsistent values. Signed-off-by: Rick Elrod <rick@elrod.me>	4 years ago
Rick Elrod	8a0abed1ba	[hostname] don't write in get_*() methods ... Change: - Hostname strategies' get_*() methods should never write to the filesystem. They are used in check_mode by default to determine if there is any work to be done. Test Plan: - New unit tests to ensure that (at least when in check_mode) the get methods don't ever call write. Tickets: - Fixes #66432 Signed-off-by: Rick Elrod <rick@elrod.me>	4 years ago