Commit Graph

22 Commits (deb532c367f0beb41553e028a03def50f05a2ff9)

Author SHA1 Message Date
Cristian Ciupitu 0749112286 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
11 years ago
David Busby b4f86abafd Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 11 years ago
James Tanner ad837709bd Addresses #5023 Fix import comments 11 years ago
James Tanner 6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
Michael DeHaan 36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
James Tanner 3c4dd618e4 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 11 years ago
Michael DeHaan ce79efc34a Add missing version_added doc to mysql login port parameter. 11 years ago
Jeroen Hoekx 08b0773da5 Add append_privs parameter to MySQL user module.
This adds the privileges given to the existing list of privileges
instead of overwriting any existing ones.
11 years ago
James Cammarata 30a1560d67 Merge branch 'devel' of https://github.com/tomdymond/ansible into tomdymond-devel 11 years ago
James Cammarata 441062f061 Cleaning up whitspace issues in the mysql_user module 11 years ago
John Hamelink 892c594319 Fixed #3767 - mysql_user command fails with dots (and underscores) in
database names.
11 years ago
Tom Dymond 11c2378259 Add option to specify the MySQL server port 11 years ago
Michael DeHaan 20f7e2ef71 Merge pull request #3691 from stoned/mysql_user-doc-fix
module mysql_user: fix 'state' parameter description
11 years ago
Stoned Elipot 3d97c11509 module mysql_user: fix 'state' parameter description 11 years ago
Stijn Tintel 9d0fc0fd67 Only revoke GRANT OPTION when user actually has it
When revoking privileges from a user, the GRANT OPTION is always
revoked, even if the user doesn't have it. If the user exists, this
doesn't give an error, but if the user doesn't exist, it does:

mysql> GRANT ALL ON test.* TO 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE ALL ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
ERROR 1141 (42000): There is no such grant defined for user 'test' on
host 'localhost'

Additionally, in MySQL 5.6 this breaks replication because of
http://bugs.mysql.com/bug.php?id=68892.

Rather than revoking the GRANT OPTION and catching the error, check if
the user actually has it and only revoke it when he does.
11 years ago
Michael DeHaan 10b967374d Add version_added information to module parameter. 11 years ago
Andrew de Quincey 4cb48f0dcc Check if mysql allows login as root/nopassword before trying supplied credentials. 12 years ago
Michael DeHaan 294230d529 Merge pull request #3177 from stintel/mysql56-compat
Fix MySQL 5.6 compatibility
12 years ago
Jan-Piet Mens 5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
12 years ago
Stijn Tintel 767c208e6c Fix MySQL 5.6 compatibility
In MySQL 5.6, the root account created by default during MySQL
installation has the PROXY ... WITH GRANT OPTION privilege for ''@'',
that is, for all users.

The mysql_user module tries to revoke this privilege, but this fails:
_mysql_exceptions.ProgrammingError: (1064, "You have an error in your
SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '''@'' FROM 'root'@'localhost''
at line 1")

Quick fix: don't revoke privilege if user is root and the privilege to
revoke contains PROXY.
12 years ago
Michael DeHaan 391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 12 years ago