Commit Graph

10373 Commits (dc4f198bad6d15c20e4972980f7a230c74c2c25a)
 

Author SHA1 Message Date
James Cammarata d88ac5e24d Merge pull request #7076 from mscherer/better_message_service
Add a better error message for service
11 years ago
Michael Scherer 43d0fbd342 Add a better error message for service
While migrating my playbook to a newer ansible version, I faced
the error message "unknown init system, cannot enable service". It turned
out to be caused by a wrong service name that was not expanded anymore.

So by giving the name of the service that cannot be enabled and a more precise
reason, i think people will be able to diagnose their issue more easily.
11 years ago
James Cammarata c115c34a1f Set the default LANG to en_US.UTF-8 and also set LC_CTYPE
Fixes #6737
11 years ago
Michael DeHaan 491a00af21 Merge pull request #7108 from bcoca/freebsd_mtu_fix
should now work with versions older than 8.4
11 years ago
James Martin 8a21f226b5 ec2_eip integration tests. 11 years ago
Brian Coca c3e559b914 should now work with versions older than 8.4 11 years ago
Richard Hoop 06c64785fb Large cleanups. Reintegrating all modules together for a guest 11 years ago
James Cammarata f1ce9abe0d Merge pull request #7099 from faust64/patch-2
Update facts.py
11 years ago
faust64 78b9a11ccf Update facts.py
Fixes #7093 --devel
11 years ago
James Cammarata 149339f620 Merge pull request #7089 from dagwieers/debug-docs
Add an example to show all hostvars using debug
11 years ago
James Cammarata 53754357f7 Merge pull request #7096 from CaptTofu/docker
Small bug - 'acts' should be 'facts'
11 years ago
James Cammarata afee14173e Merge pull request #7095 from radeksimko/pokemon-exc-fix
Prevent catching unrelated exceptions
11 years ago
James Cammarata 568b4a801c Merge pull request #7094 from radeksimko/apt-autoinstall-fix
Add check of return code for autoinstallation of python-apt
11 years ago
James Cammarata 68c30548e0 Properly catch and decode unicode strings in module _log_invocation()
Fixes #7084
11 years ago
James Cammarata 4f673b9497 Merge pull request #7083 from mscherer/better_message_multiple_action
Improve error message when multiple action are given
11 years ago
James Cammarata 39c6141b4a Merge pull request #7082 from bcoca/freebsd_mtu_fix
fixed issue with FreeBSD network facts
11 years ago
James Cammarata 086b877719 Merge pull request #7079 from mscherer/fix_error_whitespace_in_config
Clean a bit more the ssh_args configuration
11 years ago
James Cammarata 54f86099e4 Merge pull request #7078 from mscherer/fix_error_message_controlpersist
Enhance error message about missing ControlPersist
11 years ago
CaptTofu 2990db728a Small bug - 'acts' should be 'facts' 11 years ago
Radek Simko 1513d2bd64 Prevention for catching unrelated exceptions added 11 years ago
Michael DeHaan f09c0c7c64 Merge pull request #7081 from bcoca/freebsd_fact_fix
fixed ETIME issue on FreeBSD 8 through 10, which broke fact gather
11 years ago
Radek Simko 8bdd96b273 Explicit check of return code for autoinstallation of python-apt added
This will allow easier debugging through more meaningful error message.
11 years ago
Dag Wieers 3c15d64655 Add an example to show all hostvars using debug
This is a useful example to help debug how facts and vars are being collated.
11 years ago
Michael Scherer 1e34e95ba0 Improve error message when multiple action are given
This can be illustrated using this playbook:

    - command: id
      delegate_to: "{{ remote_server }}"
      user: "{{ remote_user }}"

The error is to use 'user' instead of 'remote_user', but the error message
do not really mention it, so it can be a bit hard to spot.
11 years ago
Brian Coca e5f297697a ifconfig changed on FreeBSD, tested this on 8,9 and 10 latest stable
versions and it now works
11 years ago
Brian Coca bc23926f42 fixed ETIME issue on FreeBSD 8 through 10, which broke all fact
gathering
11 years ago
Michael Scherer c87afc1109 Clean a bit more the ssh_args configuration
If someone add ssh_args = " " to his .ansible.cfg, it will result into
strange failure later :

    <server.example.org> ESTABLISH CONNECTION FOR USER: misc
    <server.example.org> REMOTE_MODULE ping
    <server.example.org> EXEC ['ssh', '-C', '-tt', '-q', ' ', '-o', 'KbdInteractiveAuthentication=no',
    '-o', 'PreferredAuthentications=gssapi-with-mic,gssapi-keyex,hostbased,publickey', '-o', 'PasswordAuthentication=no',
    '-o', 'ConnectTimeout=10', 'server.example.org', "/bin/sh -c 'mkdir -p /tmp/ansible-tmp-1397947711.21-5932460998838
    && chmod a+rx /tmp/ansible-tmp-1397947711.21-5932460998838 && echo /tmp/ansible-tmp-1397947711.21-5932460998838'"]
    server.example.org | FAILED => SSH encountered an unknown error during the connection. We recommend you re-run the
    command using -vvvv, which will enable SSH debugging output to help diagnose the issue

The root cause is the empty string between -q and -o, who kinda break mkdir.
11 years ago
Michael Scherer 3a09c99811 Enhance error message about missing ControlPersist
ansible_ssh_args is good for playbook, but in the ~/.ansible.cfg
file, it should be ssh_args in a specific section.
11 years ago
James Cammarata ae29e43f93 Merge branch 'issue_7009_nfs_selinux' into devel 11 years ago
Michael DeHaan bec0e596e8 Fix date in changelog for RPM builds off devel branch. 11 years ago
James Cammarata a32dd34359 Make sure HostVars object is instantiated before assigning it
Fixes #7006
11 years ago
James Cammarata cc6d213d72 Updating changelog/releases/packaging for 1.5.5 release 11 years ago
James Cammarata 75e0b7a5cf Make sure umask is set restrictively before creating any vault files 11 years ago
James Cammarata 3715482d7c Determine selinux context for NFS mount points correctly
Fixes #7009
11 years ago
Sébastien Gross 22d6572270 Honor ansible_private_key_file for delegated hosts
If a delegated host is not found in the inventory specified
private_key_file for primary host was not used.

This allows running playbooks without having to define any inventory at
all and to use the same ssh private key for both primary host and
delegated one.
11 years ago
Joshua Conner 4defd9a15a docker: exclude 'entrypoint' from comparing 'command' param with containers
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.

Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
11 years ago
Joshua Conner 10171dc42b docker: send 1.10 params if docker-py is new enough version 11 years ago
Michael DeHaan 632eb18333 Merge pull request #7044 from 42wim/devel
hint to install python-ssl on redhat systems
11 years ago
Wim 6ed4ca97a8 hint to install python-ssl on redhat systems 11 years ago
James Cammarata 1ef0402f03 Make sure a default allow out rule exists if no other egress rules do
Fixes #7027
11 years ago
Michael DeHaan 09e0d1c51f Merge pull request #7029 from mattjbray/docker-api-error
docker.client.APIError has moved to docker.errors.APIError
11 years ago
Andreas Fleig 337a0059d9 apt_key: fix key lookup for 64 bit key ids
Fixes #7018 by extending `all_keys` to work with either short or long keys.

Also removes the ununsed method `key_present`.
11 years ago
Matt Bray 3948dc2d1d docker.client.APIError has moved to docker.errors.APIError
see 18d4db09ec
11 years ago
James Cammarata a37a84243b Check resource_tags value before using it in ec2_vpc
Fixes #7024
11 years ago
Paul Durivage f0bb3aeeea Add Docker inventory plugin 11 years ago
James Cammarata 36b9bc4d40 Merge pull request #7021 from smoothify/skipped-items
skipped callback in loop does not display 'item'.
11 years ago
James Cammarata f9eb0ba4ad Merge branch 'devel' of https://github.com/evanccopengeo/ansible into evanccopengeo-devel 11 years ago
jjshoe 5258f75789 apt_key lists all keys in uppercase
allow for a little user error
11 years ago
smoothify 48bf7a000d Try to pass in item to on_skippped callback. 11 years ago
James Cammarata c5e9a06c2a Merge pull request #7011 from hernandesbsousa/devel
Add missing info for the append option for user module
11 years ago