Commit Graph

17104 Commits (db83c0e7cdac8e86026eeae5314185c667e6da1c)
 

Author SHA1 Message Date
Abhijit Menon-Sen 838e71edb7 Add more exhaustive tests for various IPv6 address notations 9 years ago
Abhijit Menon-Sen 50d75f8d6d Bring groups handling in ini.py up-to-date
Since c8f2483d, ini.py expects to always be passed in a pre-created list
of groups, and can no longer deal sensibly with an empty list; this just
makes that expectation clear.
9 years ago
Nathan Sowatskey e7029a90e6 #12454 changing to footnote. 9 years ago
Jeff Geerling 76bd9e9239 Releases are now named after Led Zeppelin songs as of 2.0.0. 9 years ago
James Cammarata a89412ecb1 Fail all hosts if a run_once task fails
Fixes #12563
9 years ago
James Cammarata 7173f587ed Allow delegate_to on a role again
Fixes #12560
9 years ago
James Cammarata a3e913da62 Don't assume handlers exist in the same role (if any)
Fixes #12536
9 years ago
Brian Coca 8095b027bf Merge pull request #12562 from halostatue/patch-1
Describe the units for fact_caching_timeout
9 years ago
Serge van Ginderachter 7461ba9998 Inject existing groups at InventoryDir initialization
This fixes a corner case where ini files live in a subdir
of the main inventory directory.

Reproducing the original error:

mkdir -p inventory/ini
cat > inventory/ini/hosts << EOF
[www]
www1
EOF

$ ansible -i inventory/ all -m ping
ERROR! 'all'

(or without the [www] group, it would complain about 'ungrouped')
9 years ago
Austin Ziegler 67a980c9ef Describe the units for fact_caching_timeout 9 years ago
James Cammarata 79e364d98b Properly template role dependency names
Fixes #12505
9 years ago
James Cammarata f42f5e6740 Merge pull request #12552 from mgedmin/py3k
Python 3: there's no basestring
9 years ago
Nathan Sowatskey 68a927466e Updating Mac OSX guidance comment to make it a note for issue #12454. 9 years ago
Nathan Sowatskey 420589c715 Adding Mac OSX guidance comment for issue #12454. 9 years ago
Marius Gedminas 5edd6d9be4 Python 3: there's no basestring
Fixes another failing test.

(I don't want to do a global search/replace for 'basestring' because I
want to have unit tests covering each occurrence.  When I run out of
existing failing tests, I'll try to write new ones.)
9 years ago
Toshio Kuratomi 95ede22a1e Add a comment about the docker connection and usage by non-root users 9 years ago
Toshio Kuratomi 0e110d23f8 Misc cleanups and some fixes for docker connection plugin
* Remove extraneous imports
* Fix some error handling
* Enable pipelining
* Disable su since it doesn't work
* Add error message when installed docker is not recent enough to
  support this plugin
* Move nested functions to class level
* Make transport a class attribute
* Make exec_command, put_file and fetch_file more robust
9 years ago
Toshio Kuratomi 1d119a1f46 Cleanup some extraneous imports 9 years ago
James Cammarata ffdba96668 Save the included directory for playbook includes for use as the basedir
Fixes #12524
9 years ago
Konstantin Manna 4226e49bc6 bugfix: statement had no effect => statement now has assumed effect 9 years ago
Konstantin Manna 1ccfeafa76 bugfix: use correct close calls 9 years ago
Brian Coca c1ad96e5cf removed fixme as it is already implemented below. 9 years ago
RedRampage 922b5c8109 Removed deletion of salt by 'password' lookup
Removed deletion of salt param from lookup file by 'password' lookup_filter.
Old behaviour leads to constant changed status when two tasks uses same lookup,
one with 'encrypt' parameter, and other without.

For example:

    tasks:
      - name: Create user
        user:
          password: "{{ lookup('password', inventory_dir + '/creds/user/pass' ncrypt=sha512_crypt) }}"
          ...
    # Lookup file 'creds/user/pass' now contain password with salt
      - name: Create htpasswd
        htpasswd:
          password: "{{ lookup('password', inventory_dir + '/creds/user/pass') }}"
          ...
    # Salt gets deleted from lookup file 'creds/user/pass'
    # Next run of "Create user" task will create it again and will have 'changed' status
9 years ago
Toshio Kuratomi 12a2585e84 chroot plugin minor touchups:
* Disable su as it's not currently working 100% (and was disabled in v1).
* Move BUFSIZE out of the class to match other conenction plugins
* _connect shouldn't return self.
9 years ago
Toshio Kuratomi 7a4266e9c5 One more try -- the error message should reference the become method
requested via play context
9 years ago
Toshio Kuratomi 696cf32d63 Correct name of variable 9 years ago
Brian Coca 8d024c3747 Merge pull request #12472 from resmo/for_ansible
cloudstack: improvements and tests
9 years ago
Toshio Kuratomi 0dfa1fb43a Correct call to method typo 9 years ago
Toshio Kuratomi 4225c0677d Merge pull request #12548 from amenonsen/pr-9130-rebase
#9130 rebase: EC2 Inventory Boto Profile Support
9 years ago
Toshio Kuratomi d827325644 Re-order the methods in ssh.py so that methods needed for implementation are near and just above the relevant public methods.
Standard with the rest of the code base.
9 years ago
Toshio Kuratomi 37844a5c1b Update submodule refs 9 years ago
Toshio Kuratomi c811668a4d Merge pull request #12546 from amenonsen/ssh-cleanups
A couple of ssh cleanups
9 years ago
Will Thames b0133d9c8f Move connection handling failure to connect_to_aws
Make use of better error handling mechanism
9 years ago
Jameel Al-Aziz c08137a3d2 Update ec2 inventory documentation to refer to AWS_PROFILE 9 years ago
Jameel Al-Aziz 57754b5a71 Fix security_token typo in ec2 inventory 9 years ago
Jameel Al-Aziz e7890e66f3 Combine ansible/ansible#5987 and ansible/ansible#8582
Fixes merge conflicts and standardizes option naming
9 years ago
Jeff '2 bits' Bachtel 8c11ea5666 Add an ec2 inventory option "boto_profile" that allows
the use of boto profiles for separating credentials as
specified in

http://boto.readthedocs.org/en/latest/boto_config_tut.html
9 years ago
willthames 9c967dd054 Allow ec2 inventory to use a boto profile
This allows the EC2 inventory plugin to be used with
the same configuration against different EC2 accounts

Profile can be passed using --profile variable or using
EC2_PROFILE environment variable e.g.

```
EC2_PROFILE=prod ansible-playbook -i ec2.py playbook.yml
```

Added documentation on profiles to EC2 dynamic inventory doc

Only tries to use profiles if --profile argument is given
or EC2_PROFILE is set to maintain compatibility will boto < 2.24.

Works around a minor bug in boto where if you try and use
a security token with a profile it fails (boto/boto#2100)
9 years ago
Toshio Kuratomi 05af4c8e91 Merge pull request #12471 from amenonsen/pipelining
Make pipelining a connection variable
9 years ago
Abhijit Menon-Sen 38c7422da5 Move ControlPersist/Path checking into a separate method
This is also peripheral to what _build_command needs, can be improved
and tested independently, and so makes more sense in a separate method.

This commit doesn't change any functionality (and I've verified that it
works with the various combinations: control_path set in ansible.cfg,
ssh_args adding or not adding ControlMaster/ControlPersist, etc.).
9 years ago
Toshio Kuratomi c3a05b1181 Update to fix one more doc error 9 years ago
Abhijit Menon-Sen f33d541964 Move sshpass checking into a separate method
Checking for sshpass is peripheral to the calling code, so it's easier
to follow when the details are moved into a method.
9 years ago
Abhijit Menon-Sen d4af7d256b Mention ansible_ssh_pipelining in intro_inventory 9 years ago
Abhijit Menon-Sen 565c6f1ae7 Make ansible_pipelining a connection variable
SSH pipelining can be a significant performance improvement, but it will
not work if sudoers is configured to requiretty. With this change, one
could have pipelining enabled in ansible.cfg, but use sudo to turn off
requiretty in a separate play (or task) where pipelining is disabled:

    - hosts: foo
      vars:
          ansible_pipelining: no
      tasks:
        - lineinfile: dest=/etc/sudoers line='Defaults requiretty' state=absent
          sudo_user: root

(Note that sudoers has a complicated syntax, so the above lineinfile
invocation may be too simplistic for production use; but the point is
that a separate play can do something to disable requiretty.)
9 years ago
Toshio Kuratomi fd267989fb Fix docs build 9 years ago
Toshio Kuratomi 69ebb899a7 Update submodule refs 9 years ago
James Cammarata c860775b5d Another fix for --limit in adhoc 9 years ago
Nathan Sowatskey ee6317ca07 Adding Mac OSX guidance comment for issue #12454. 9 years ago
Nathan Sowatskey c8835b873b Adding Mac OSX guidance comment for issue #12454. 9 years ago
Nathan Sowatskey f5c453f2b2 Adding Mac OSX guidance comment for issue #12454. 9 years ago