Commit Graph

432 Commits (db3d2e1042c2ac60a899ccc745f579c364ff578a)

Author SHA1 Message Date
James Cammarata 6fe369fca0 Merge branch 'usermod_fix' of https://github.com/tknguyen79/ansible into tknguyen79-usermod_fix
Conflicts:
	library/system/user
11 years ago
Stefan J. Betz 789ae4697c Require force for LVM shrink and remove operations in lvol. Fixes #5774
Conflicts:
	library/system/lvol
11 years ago
Richard C Isaacson bf30707670 If you try to resize a lvol to the current size return a changed=False and don't fail.
This addresses GH-5165 and adds the ability to check if a lvol exists.

The tests for this don't fit nicely into the current integration tests so they are below.

```
---

- name: remove any existing lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: remove any existing lv=two of vg=main
  lvol: lv=two vg=main state=absent

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  ignore_errors: true
  register: lvol_result0

- name: Assert that we will get a "No size given."
  assert:
    that:
      - "'No size given.' in lvol_result0.msg"

- name: create lv=one of vg=main sized 30g
  lvol: lv=one size=30g vg=main state=present
  register: lvol_result1

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result1.changed == True"

- name: check to see if lv=one of vg=main exists
  lvol: lv=one vg=main state=present
  register: lvol_result2

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result2.changed == False"

- name: remove lv=one of vg=main
  lvol: lv=one vg=main state=absent

- name: create lv=two of vg=main sized 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result3

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result3.changed == True"

- name: reduce lv=two of vg=main to 15G
  lvol: lv=two size=15G vg=main state=present
  register: lvol_result4

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result4.changed == True"

- name: increase lv=two of vg=main to 30G
  lvol: lv=two size=30G vg=main state=present
  register: lvol_result5

- name: Assert that we made changes."
  assert:
    that:
      - "lvol_result5.changed == True"

- name: create lv=two of vg=main sized 30G when already exists at 30G
  lvol: lv=two size=30g vg=main state=present
  register: lvol_result6

- name: Assert that we did not make changes."
  assert:
    that:
      - "lvol_result6.changed == False"

- name: remove lv=two of vg=main
  lvol: lv=two vg=main state=absent
```
11 years ago
Matt Jeffery 8131feaade Normalise the module name when comparing against the module names in /proc/modules. 11 years ago
Nils Pascal Illenseer 858004984b Fix zfs create command for properties with spaces
If a property value contains one or more spaces, the zfs command will fail.
With value quoted this behavior is fixed.
11 years ago
Richard C Isaacson 7d670f8308 Merge remote-tracking branch 'berendt/fixing_permissions' into pull_4703 11 years ago
Peter Gehres c427a829a0 Adding better failure output for chkconfig failures rather than
just saying that the service name is unknown
11 years ago
Sean Chittenden 5e0cf6663a Fix broken behavior when removing all auxiliary groups from a user
(e.g. 'groups=' in the user module).
11 years ago
Brian Coca f475de2316 hopefully last batch of fixes
- removed previous 'typification' of input as it needs it is typed by
  module as strings and needs to be output as strings, making it
  useless.
- now checks for vtype and value against None when question is specified
- simplified set_selections as vtype and value should have a string
  value going in.
- added example of querying questions for a package
- added module requirement of question,vtype and value being required
  together.
11 years ago
Brian Coca a1de284dba made changes as per feedback:
- field names are more consistent with debconf
- values are now 'booleanized' or accepted as list/set objects when
  pertinent
- updated docs to reflect all of the above and debconf cli tools
  required
11 years ago
Brian Coca 0233584343 fixed main() issue created in prev fix, now values are empty string if they were None
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Brian Coca de956c57fe changes names to name in example 11 years ago
Brian Coca 453d473728 fixes as per feedback 11 years ago
Tom Dymond 486d14cb2d Reworked PR to avoid repeating the command 11 years ago
jctanner 5967b463c9 Merge pull request #5554 from ttarabul/devel
Use /etc/rc.conf.local for sevice configuration on FreeBSD
11 years ago
Tom Dymond cf80f9b68b Add option to enable the sysctl -e option 11 years ago
kustodian a7839208c7 Updated authorized_key module documentation regarding manage_dir
Added a warning in the documentation about manage_dir when selecting an alternate directory for authorized_keys
11 years ago
Aaron Lindsay 59ac969d2b Add move_home option to user module 11 years ago
Richard C Isaacson 7a2df2733f Tested implementation adding action option for (add, delete, unique). 11 years ago
Richard C Isaacson c198217900 Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson cd871384de Rough cut implementation based on @resmo's comments. 11 years ago
Richard C Isaacson b00939acff Change to dynamically pick up the command from the PATH. 11 years ago
Richard C Isaacson 9650c118cf Formating and syntax fixes that were pointed out during code review. 11 years ago
Richard C Isaacson ec04e30186 Added user option. 11 years ago
Richard C Isaacson 3a7e579bc2 First commit of the at module being very basic. 11 years ago
Brian Coca 46dfe07181 be permissive with BSD with service enabled upper/lower/mixed cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
11 years ago
Jakub Jirutka 8c9a63bcd0 sysctl: parse bool value as 0/1 and refactor a little bit 11 years ago
Thoai Nguyen 5c4bb5730e reorder usermod options 11 years ago
jctanner 7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2
Correctly compare values returned by 'sysctl -e -n'
11 years ago
Augustus Kling c3f182bc9b Fix error reporting in case locale-gen fails on non-Ubuntu systems. 11 years ago
Augustus Kling 1fb830fba6 Merge remote-tracking branch 'upstream/devel' into locale 11 years ago
Augustus Kling 6b75e75161 Handle install/uninstall of locales for Ubuntu, too. 11 years ago
Simon Zimmermann 3db808c840 correctly compare the values, better func name 11 years ago
Simon Zimmermann 055b404f13 Correctly compare values as returned from 'sysctl -e -n' 11 years ago
Simon Zimmermann 7495095496 fix str format error due to missing '%' in sysctl module 11 years ago
James Tanner 3bd99903a4 Fixes #5661 Handle null values for sysctl parameters 11 years ago
Michael DeHaan 2a46022bc7 Merge pull request #5658 from rishid/devel
Add support for Scientific Linux for hostname module
11 years ago
jctanner 450bb37c8c Merge pull request #5655 from scottgilbert/devel
Allow keystring passed to authorized_key to contain blank lines and comments
11 years ago
James Tanner 19cb22b6df Fixes #5656 quote values with multiple columns before calling
the sysctl command. Calling sysctl should also not be true by default
11 years ago
rishid 34f9349b5e Add support for Scientific Linux for hostname module
hostname module was lacking support for Scientific Linux, this commit adds it.
11 years ago
Scott Gilbert 0aedd0c0b2 Allow keystring passed to authorized_key to contain blank lines and comments 11 years ago
James Tanner 2c39576e80 Remove unused variable from authorized_key 11 years ago
James Tanner e22af253bb Fixes #5486 Keep authorized key options in tact and ordered 11 years ago
James Tanner c627358c37 sysctl module: append newline character to lines in the file 11 years ago
Michael DeHaan 6f49642286 All modules should be using /usr/bin/python in the shebang as ansible_python_interpreter processes this (see FAQ).
Fixing for standardization purposes.
11 years ago
jctanner 332d3d6a0e Merge pull request #5490 from rgbj/devel
user module/OpenBSD: using login_class always makes status 'changed'
11 years ago
jctanner 6e39adb89e Merge pull request #5426 from lichesser/debian_release_4565
setup module: Partial fix for #4565, reporting Debian release version. Works only for Debian 7 and later
11 years ago
James Tanner 17c50cc81e sysctl module: fail if reloading the file did not succeed 11 years ago
James Tanner ca05584495 Fixes #5469 Refactor sysctl module into object oriented code,
and add a sysctl_set parameter to manage the values in /proc
11 years ago
Tyler 2f813f7660 keep /usr/local/etc/rc.conf for backwards compatibility 11 years ago
Tyler 1a655b2dd7 Use /etc/rc.conf.local for sevice configuration on FreeBSD
/etc/rc.conf.local is the preferred location for system-specific
startup configuration, and /usr/local/etc/rc.conf generally isn’t used.

see:
http://www.freebsd.org/doc/handbook/configtuning-core-configuration.html
11 years ago
Joshua Lund 3b4f3f8ca3 Improved the documentation for password generation 11 years ago
James Tanner dee960716b Fixes #5353 create etc/hostname file in debian if it does not exist 11 years ago
Michael DeHaan 1e6926b9ab Merge pull request #5528 from dverhelst/devel
Adding support for detecting RHEV Hypervisor in ansible_virtualization_type
11 years ago
Paul Beattie e96377685e Fixed typo in example documentation 11 years ago
rgbj f2150b101e On OpenBSD, make user module status 'changed' only if necessary when using 'login_class' parameter 11 years ago
jctanner 89abc35e59 Merge pull request #5167 from jaspernbrouwer/devel
service_module: Fixed false positive on initctl as enable_cmd
11 years ago
James Tanner 86719ce77f Fixes #5040 setup module: do not add primary interface info to the secondary interface data 11 years ago
lichesser b49cb2e540 Partial fix for #4565. Works only for Debian 7 and later 11 years ago
Michael DeHaan aa8beadec3 Fix a documentation item. 11 years ago
Augustus Kling 6d1c2a92de Basic handling of locales. 11 years ago
Brian Coca 35980ef329 making pylint happier
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca c2c0d9bcd7 corrected my grammar (again Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 555f12c59a did some minor refactoring on docs and fixed spelling mistakes (thanks
Mikhail)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Jasper N. Brouwer a52ca73167 Swapped conditions of the changed if statements 11 years ago
Brian Coca 821aa432a6 corrected indentation and now handles non existing previous key (not
just changed existing)

Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 307ab1f561 and it was supposed to be a dict
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca fd78916a73 fixed typo for showing diff
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
Brian Coca 175d6346a2 debconf package
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
11 years ago
jctanner 91f903eabe Merge pull request #4886 from sergeyhush/devel
fix when the system does not have lsb_release script, but has /etc/lsb_release file
11 years ago
jctanner dc41912158 Merge pull request #5213 from dalevizo/devel
Add get_dmi_facts in setup for FreeBSD systems using dmidecode
11 years ago
Dimos Alevizos 8c73aa13e4 Minor changes to simplify code 11 years ago
David Hummel cc3678730c Fix issue #5214: hostname persistence on RedHat/CentOS 11 years ago
Dimos Alevizos de4e4c54b9 Add get_dmi_facts in setup for FreeBSD systems using dmidecode 11 years ago
jeromew 1916e8ec90 user module: force= and remove= should not be mutually exclusive 11 years ago
jctanner 5e336d7caf Merge pull request #5075 from gservat/patch-1
Added support for parsing in the SLES patch level correctly
11 years ago
gservat db2f41bdcb This change is meant to replace distribution_release, not version! 11 years ago
gservat 83f35a63dd Oops... fixed an error 11 years ago
Alfons Zitterbacke 5390ee9763 added AIX network facts 11 years ago
Alfons Zitterbacke cc783b3e1b added AIX network facts 11 years ago
James Tanner cbfeb0a2ea Fixes #5169 Evaluate check_mode in the user module SunOS class 11 years ago
Jasper N. Brouwer 0e11e4c86f Fixed false positive on initctl as enable_cmd
Also on update-rc.d
In service module
11 years ago
jctanner 2670529671 Merge pull request #5090 from dragon3/hostname_support_amazon_linux
hostname module: add support for Amazon Linux
11 years ago
jctanner 872a1ee39b Merge pull request #5107 from maetthu/devel
authorized_key module: rewrite options to dict parser, fixes #5032
11 years ago
jctanner ef92b2cb12 Merge pull request #5063 from samh/devel
Fixed hostname module for RHEL6 Workstation
11 years ago
James Tanner ad837709bd Addresses #5023 Fix import comments 11 years ago
James Tanner 6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 11 years ago
James Tanner c050872458 Fixes #4796 handle unicodedecode errors from dmidecode output 11 years ago
Michael DeHaan 5efcf265d1 Merge pull request #5046 from JensRantil/improve-mount-doc
mention that the mount module will remove mount directories
11 years ago
Matthias Blaser 9d442243ab rewrite options to dict parser, fixes #5032 11 years ago
Michael DeHaan 36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
11 years ago
Michael DeHaan ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 11 years ago
dragon3 d39e6fda92 hostname module: add support for Amazon Linux 11 years ago
gservat 13da2c3ac9 Added support for parsing in the SLES patch level correctly
On SLES, the setup module was returning the architecture as the distribution version (i.e. platform.dist() didn't quite return the right thing). This change checks for /etc/SuSE-release and grabs the second column in the third line as distribution_version.
11 years ago
Sam Hartsfield ae7735b45d Fixed hostname module for RHEL6 Workstation 11 years ago
James Tanner 7be13faae8 Fix comment yaml escaping in authorized_key module 11 years ago
James Tanner 4ba51eef6f Save comment hashes in sshkeys 11 years ago
James Tanner 16b22d0d64 Cleanup debug statements 11 years ago
James Tanner b938554311 Fixes #5032 escape and safely split key options in authorized_keys module 11 years ago
James Tanner d187066339 Fixes #5010 Add user to all defined supplementary groups 11 years ago