1219 Commits (da9ae14ff6ca488a5cca1d68171eb0ad5c747c8d)

Author	SHA1	Message	Date
Toshio Kuratomi	ac54ac618c	Something's strange... let's see if python2.6 is really the same now...	9 years ago
Toshio Kuratomi	eb7db067f9	Fix template test results on python2.6	9 years ago
Abhijit Menon-Sen	8cf1815867	Add an 'extract' filter ... At its most basic, this is nothing more than an array or hash lookup, but when used in conjunction with map, it is very useful. For example, while constructing an "ssh-keyscan …" command to update known_hosts on all hosts in a group, one can get a list of IP addresses with: groups['x']|map('extract', hostvars, 'ec2_ip_address')|list This returns hostvars[a].ec2_ip_address, hostvars[b].ec2_ip_address, and so on. You can even specify an array of keys for a recursive lookup, and mix string and integer keys depending on what you're looking up: ['localhost']|map('extract', hostvars, ['vars','group_names',0])|first == hostvars['localhost']['vars']['group_names'][0] == 'ungrouped' Includes documentation and tests.	9 years ago
Brian Coca	c03afccc05	reformated test, changed big assert to with_items ... much easier to see the individual condition that causes the failure when using with_items and evaluating each part of the assert individually	9 years ago
James Cammarata	dc0fae1af7	Also make sure remote_user is defaulted correctly for delegated hosts ... Fixes #13323	9 years ago
Chris Church	f3476b556d	Add assertions for ansible_date_time in setup result.	9 years ago
James Cammarata	3c8c2fb090	Merge pull request #13208 from agx/zypper-integration-test ... Add integration tests for zypper	9 years ago
James Cammarata	e62fb04a2e	Merge pull request #13229 from zarnovican/bza_fix_test_hg ... test_hg fix: remove reference to "head"	9 years ago
James Cammarata	138068c56e	Merge pull request #13230 from zarnovican/bza_fix_test_svn ... test_svn fix: remove hardcoded "~/ansible_testing/svn" path	9 years ago
Chris Church	272778f732	Modify task executor to reuse connection inside a loop. Fix WinRM connection to set _connected properly and display when remote shell is opened/closed. Add integration test using raw + with_items.	9 years ago
Brano Zarnovican	a30a52ef52	test_svn fix: remove hardcoded "~/ansible_testing/svn" path	9 years ago
Brano Zarnovican	5fc64deffe	test_hg fix: remove reference to "head" ... ERROR! error while evaluating conditional: head.stat.isreg This is remnant from earlier change 50e5d81777 which removed stat on head file..	9 years ago
James Cammarata	91500f8f5f	Fix include param precedence in variable manager	9 years ago
Guido Günther	0821d251c8	Add integration tests for zypper ... Modeled after the yum tests but also tests local package installations as fixed with PR#1256. This depends on PRs #1256, #1261 and #1262 in ansible-modules-extra.	9 years ago
Brano Zarnovican	90f99f29ae	unittest cover for 'run_command' ... All os.*, subprocess.* is mocked to avoid side-effects. Tests are skipped in Py3, since 'run_command' is not Py3-ready, yet.	9 years ago
Brian Coca	e61882ca19	Merge pull request #13170 from robinro/integration_test_git_ansible-modules-core_pull_721 ... add test for changing git remote url	9 years ago
nitzmahone	349e072a74	fix for dynamic (add_host) hosts not available in hostvars ... Looks like there are two pattern caches that need to be cleared for this to work- added the second one. Added integration tests for add_host to prevent future regressions.	9 years ago
Will Thames	4f3430ebeb	Handle unexpected database presence ... Check for database presence in a nice way, rather than dropping the database. Thankfully there was a syntax error in the previous version, so no database would have been dropped. There was no check for whether it succeeded or not.	9 years ago
Robin Roth	6cefdfe148	add test for changing git remote url ... integration test for https://github.com/ansible/ansible-modules-core/pull/721 clone a repo from one url clone an updated version of that repo from a new url make sure the remote url and the working copy are updated	9 years ago
Brian Coca	5d645f3a8b	Merge pull request #13127 from willthames/test_become ... Elevate privileges when checking for file existence	9 years ago
Toshio Kuratomi	318bfbb207	Migrate cli and dependencies to use global display	9 years ago
Brian Coca	206cc50bd9	breaks testing in non virtual envs, since env var can be used in those ... cases removing it from here	9 years ago
Will Thames	5bb759e7ab	Elevate privileges when checking for file existence ... Certain OSs default to home directories as 0700 Without elevating privileges, checking for file existence fails.	9 years ago
Toshio Kuratomi	74fe9d236a	Add a disabled test for accessing private attributes of other objects ... Need to cleanup the code before we can enable this test.	9 years ago
Toshio Kuratomi	aa034f4fcf	Add unit tests for issue #12976	9 years ago
Toshio Kuratomi	37052a983a	Fix unittest dailure with the new squash items code	9 years ago
James Cammarata	23ff08ee6b	Merge pull request #13016 from dvarrazzo/pip-vcs-changed ... Added tests to verify pip installation with VCS urls	9 years ago
Will Thames	91b6004149	Allow blank lines and comments/spaces in galaxy spec files ... Fixes #10641 again. (Regression) Added test to discourage future such regression.	9 years ago
Scott Miller	98b694f5ca	Update README.md	9 years ago
Daniele Varrazzo	542a430e84	Added tests to verify pip installation with VCS urls ... The test reproduces: - bug ansible/ansible#1705 - bug ansible/ansible-modules-core#1645	9 years ago
Brian Coca	c267e1906e	removed invocation from tests as it is only available on very very verbose mode	9 years ago
Chris Meyers	4b88cce6a1	update ansible_test_service checksum	9 years ago
Brian Coca	174de1161b	fixed removing -n in password sudo tests	9 years ago
Brian Coca	b2fc5142eb	moved sudo -S and -n into configurable flags as they might be absent in much older systems ... if password is supplied exsiting -n would get remove from flags	9 years ago
James Cammarata	1910f23144	Merge pull request #12801 from chrismeyersfsu/fix-test_destructive_init ... run correct init system tests	9 years ago
James Cammarata	9b22004540	Merge pull request #12795 from chrismeyersfsu/fix-test_destructive_mysql_user ... remove module param quotes	9 years ago
Toshio Kuratomi	4203850d1a	Break apart a looped dependency to show a warning when parsing playbooks ... Display a warning when a dict key is overwritten by pyyaml Fixes #12888	9 years ago
Brian Coca	f78c82b9ee	don't set user to current user ... also remove condition to bypass setting user if user matches current user this enables forcing user when set to the same user as current user and ignoring .ssh/config while keeping .ssh/config with current user if nothing is specified.	9 years ago
Toshio Kuratomi	ce2b18174e	Merge pull request #12878 from ansible/invocation-fix ... Invocation fix	9 years ago
Toshio Kuratomi	2e87c1f74e	Two fixes to action plugins ... * Fix the task_vars parameter to not default to a mutable type (dict) * Implement invocation in the base class's run() method have each action module call the run() method's implemention in the base class. * Return values from the action plugins' run() method takes the return value from the base class run() method into account so that invocation makes its way to the output. Fixes #12869	9 years ago
James Cammarata	86de1429e5	Cleaning up FIXMEs	9 years ago
Toshio Kuratomi	ed6aa75d63	Add parsing test to travis to catch that invocation is missing	9 years ago
Toshio Kuratomi	6b6d03290a	Restore the automatic addition of invocation to the output ... Revert "Remove auto-added invocation return value as it is not used by v2 and could leak sensitive data." This reverts commit 6ce6b20268. Remove the note that invocation was removed as we've now restored it. Revert "keyword not in ubuntu 14.04" This reverts commit 5c01622457. Revert "remove invocation keyword check" This reverts commit 5177cb3f74.	9 years ago
Will Thames	002972c6cf	Allow meta/main.yml to include roles through spec file ... ansible-playbook now works when run with a playbook that includes a role that includes another role specified using csv format Updated one of the roles used in the tests to fix broken tests - `make test_galaxy` now works Fixes #11486. Also addresses the problem alluded to in #10620.	9 years ago
Toshio Kuratomi	5a0e63af1e	Workaround seeming bug in python-2.6's sys.exit()	9 years ago
Toshio Kuratomi	6e5055e786	Update the use of no_log values to cover everything that heuristic_log_sanitize does. ... Fixes #12792	9 years ago
Chris Meyers	6c265cde49	invoke systemd test for ubuntu >= 15.04 else invoke upstart test	9 years ago
Toshio Kuratomi	c2d188baff	Hide values in json returns which were given in parameters marked no_log.	9 years ago
Toshio Kuratomi	a22cf8ffc1	Properly add the new test and limit six test to lib	9 years ago
Chris Meyers	f864fa8727	run systemd tests for fedora	9 years ago
Brian Coca	c1a404e6ec	Merge pull request #12799 from resmo/for-ansible ... cloudstack: add tests for cs_loadbalancer_rule and _member	9 years ago
James Cammarata	2346a7f170	Merge pull request #12800 from chrismeyersfsu/fix-test_destructive_yum ... remove invocation keyword check	9 years ago
James Cammarata	549bdb2503	Merge pull request #12804 from chrismeyersfsu/fix-test_non_destructive_makefile ... allow env variable override of creds file	9 years ago
Chris Meyers	1b2d17b844	allow env variable override of creds file ... This is important because there is an integration test, test_git, that require an ssh key to clone a privileged github repo.	9 years ago
James Cammarata	8baea3cba8	Merge pull request #12796 from chrismeyersfsu/fix-test_destructive_mysql_variables ... fix up mysql variable assertion logic	9 years ago
Chris Meyers	d6dfd9f502	run correct init system tests	9 years ago
Chris Meyers	5177cb3f74	remove invocation keyword check	9 years ago
Rene Moser	bb5dcc00b6	cloudstack: add tests for cs_loadbalancer_rule and _member	9 years ago
James Cammarata	450c8d45c6	Merge pull request #12787 from chrismeyersfsu/fix-test_destructive_apt ... keyword not in ubuntu 14.04	9 years ago
Chris Meyers	75833c248e	fix up mysql variable assertion logic	9 years ago
Chris Meyers	ce4e98a6d0	remove module param quotes	9 years ago
Toshio Kuratomi	eebd3cc336	Merge pull request #12788 from chrismeyersfsu/fix-test_destructive_state ... remove non-existant state var	9 years ago
Chris Meyers	a0264983ad	remove non-existant state var	9 years ago
Chris Meyers	5c01622457	keyword not in ubuntu 14.04	9 years ago
Brian Coca	6d87bd405d	Merge pull request #12765 from bcoca/lookup_inventory_hostname ... implemented inventory_hostname lookup in v2	9 years ago
Toshio Kuratomi	49f2b84253	Add a code smell test to make sure we're not using the raw system six ... (So we know we have a recent enough version)	9 years ago
Toshio Kuratomi	baa309309d	Bundle a new version of python-six for compatibility along with some code to make it easy for distributions to override the bunndled copy if they have a new enough version.	9 years ago
Marius Gedminas	04a7ef416e	Python 3: print function in a shell oneliner in Makefile ... Fixes File "<string>", line 1 import string,random; print 'ansible-testing-' + ''.join(random.choice(string.ascii_letters + string.digits) for _ in xrange(8)); ^ SyntaxError: invalid syntax when running integration tests with . hacking/env-setup . .tox/py35/bin/activate make -C test/integration test_var_precedence	9 years ago
Marius Gedminas	ec3ada1cda	Fix test on Python 3: vault code expects bytes ... (All tests now succeed on Python 3.5)	9 years ago
Marius Gedminas	5c70f932bd	Fix test on Python 3: vault code expects bytes ... (Third failing test out of four.)	9 years ago
Marius Gedminas	a1d95536f9	Fix test on Python 3: vault code expects bytes ... (Different test than the last commit.)	9 years ago
Marius Gedminas	f58f0c62e1	Fix test on Python 3: vault code expects bytes	9 years ago
Brian Coca	9b088a1e40	implemented inventory_hostname lookup in v2	9 years ago
Chris Church	cb9f350c8f	Merge pull request #12720 from jhawkesworth/test_amc_2147 ... integration tests for ansible modules core 2147	9 years ago
Marius Gedminas	225fe85530	Skip test_module_utils_basic_ansible_module_creation on Python 3 ... This reverts commit 073f10a52a and instead disables the failing test. We're focusing on Python 3 support on the controller first; modules will come later.	9 years ago
James Cammarata	e6d3c6745f	Revert to using local file/dir tests in inventory instead of loader's ... Fixes #12719	9 years ago
=	e141101314	integration tests for ansible modules core 2147	9 years ago
Toshio Kuratomi	15d7f53846	AnsibleModules.log() fix for python3 ... Also add unittests for AnsibleModules.log() Fixes #12586	9 years ago
James Cammarata	0e1a5919c8	Adding unit tests for PlaybookExecutor _get_serialized_batches	9 years ago
Brian Coca	abf2e13955	Revert "Track local_action internally to prevent it from being overridden" ... This reverts commit 49ca0eb797.	9 years ago
James Cammarata	de792ba3c2	Improve handling of unicode errors ... Fixes #12669	9 years ago
James Cammarata	9c9897805f	More ansible-galaxy fixes for the old spec file format	9 years ago
Brian Coca	f73329401b	galaxy updates ... better error reporting on fetching errors use scm if it exists over src unified functions in requirements simplified logic added verbose to tests cleanup code refs, unused options and dead code moved get_opt to base class fixes #11920 fixes #12612 fixes #10454	9 years ago
Brian Coca	5680a9fa32	removed redundant tests, adjusted makefile expected count	9 years ago
Brian Coca	e2ae3215f6	corrected no_log for items and skipped tasks ... corrected output from default callback added new tests for no_log loops updated makefile test to check for both positive and negative occurrences of no_log	9 years ago
Brian Coca	5c39538a73	added no_log tests as per #12214	9 years ago
James Cammarata	775486c9d6	Merge pull request #12589 from jemmyw/consul-http-checks ... Update consul integration test with http checks	9 years ago
Marius Gedminas	0371b14567	Fix test: selinux gets passed byte strings ... (I don't have a system with selinux to test if the module still wants byte strings even on Python 3.)	9 years ago
Marius Gedminas	500e7a1263	Fix test: _to_filesystem_str produces byte strings	9 years ago
Marius Gedminas	f7571cb37f	Python 3: there's no __builtin__ module ... This caused an ImportError in a test module and showed up as one test failure. Now the test module can get imported and many more tests fail (on Python 3). Such is life. ;-)	9 years ago
Brian Coca	ddafed4403	Merge pull request #12528 from bcoca/task_logging ... task logging revamp	9 years ago
James Cammarata	6339bf8a82	Merge branch 'tests' of https://github.com/amenonsen/ansible into amenonsen-tests	9 years ago
James Cammarata	dfa33d0f23	Tweak variable manager use in role includes to avoid test failures	9 years ago
Abhijit Menon-Sen	d100db837b	Add basic tests for expand_hostname_range	9 years ago
Abhijit Menon-Sen	838e71edb7	Add more exhaustive tests for various IPv6 address notations	9 years ago
Brian Coca	8d024c3747	Merge pull request #12472 from resmo/for_ansible ... cloudstack: improvements and tests	9 years ago
Brian Coca	37a918438b	task logging revamp ... * allow global no_log setting, no need to set at play or task level, but can be overriden by them * allow turning off syslog only on task execution from target host (manage_syslog), overlaps with no_log functionality * created log function for task modules to use, now we can remove all syslog references, will use systemd journal if present * added debug flag to modules, so they can make it call new log function conditionally * added debug logging in module's run_command	9 years ago
James Cammarata	ccddda1ebc	Merge pull request #12502 from mgedmin/py3k ... Python 3: make test_variable_manager_precedence pass	9 years ago
James Cammarata	31d5f88a1d	Use the task loop to calculate multiple delegated hosts ... Due to the way we're now calculating delegate_to, if that value is based on a loop variable ('item') we need to calculate all of the possible delegated_to variables for that loop. Fixes #12499	9 years ago
Toshio Kuratomi	a1428d6bed	Remove tmp as a parameter to the connection plugins ... There doesn't appear to be anything that actually uses tmp_path in the connection plugins so we don't need to pass that in to exec_command. That change also means that we don't need to pass tmp_path around in many places in the action plugins any more. there may be more cleanup that can be done there as well (the action plugin's public run() method takes tmp as a keyword arg but that may not be necessary). As a sideeffect of this patch, some potential problems with chmod and the patch, assemble, copy, and template modules has been fixed (those modules called _remote_chmod() with the wrong order for their parameters. Removing the tmp parameter fixed them.)	9 years ago
Toshio Kuratomi	03127dcfae	remove the stdin return value from connection plugin exec_command() methods ... The value was useless -- unused by the callers and always hardcoded to the empty string.	9 years ago
Marius Gedminas	0624797375	Bugfix: if you define a custom __eq__, you must define a __hash__ too ... Also, on Python 3 the stock object.__hash__ raises an error ("unhashable type"), and we have code that uses Host instances as dict keys.	9 years ago
Marius Gedminas	a2bc6b4b26	Bugfix: if you define __eq__, you should define __ne__ too	9 years ago
Marius Gedminas	5d29a2eabd	Python 3: shlex.split() wants unicode ... On Python 2, shlex.split() raises if you pass it a unicode object with non-ASCII characters in it. The Ansible codebase copes by explicitly converting the string using to_bytes() before passing it to shlex.split(). On Python 3, shlex.split() raises ('bytes' object has no attribute 'read') if you pass a bytes object. Oops. This commit introduces a new wrapper function, shlex_split, that transparently performs the to_bytes/to_unicode conversions only on Python 2. Currently I've only converted one call site (the one that was causing a unit test to fail on Python 3). If this approach is deemed suitable, I'll convert them all.	9 years ago
Rene Moser	9514ac860d	cloudstack: more integration tests	9 years ago
Abhijit Menon-Sen	2fcdb37e7b	Support «hosts: groupname[1:]» notation (~= 'the rest of the group')	9 years ago
Abhijit Menon-Sen	21142f5723	Add some tests for split/apply_subscript	9 years ago
Abhijit Menon-Sen	2d420a9bb7	Allow hexadecimal ranges in IPv6 addresses, not only 0-9	9 years ago
James Cammarata	951128d7a6	Merge branch 'hostpatterns' of https://github.com/amenonsen/ansible into amenonsen-hostpatterns	9 years ago
Victor Salgado	01ae60d524	Add more tests for _split_pattern for when the input is a list	9 years ago
Abhijit Menon-Sen	abd006657b	Add test/units/inventory with a few _split_pattern tests ... There were no inventory-specific unit tests earlier, so we add a new directory for them with some initial low-level tests of _split_pattern with various valid and deprecated pattern strings.	9 years ago
Florian Apolloner	d9f873495e	Ported over #7158 to support SELinux context switches.	9 years ago
Florian Apolloner	8548690ca3	Added a test to ensure that sudo is only used if remote and become user difer.	9 years ago
Toshio Kuratomi	3db8070aa3	Fix urlopen usage to use open_url instead ... Add a travis test for urlopen usage	9 years ago
Chris Church	43b15ab9a4	Merge pull request #12385 from cchurch/winrm_put_empty_file ... Enable winrm put_file to upload an empty file.	9 years ago
Chris Church	93af0b327f	Merge pull request #12384 from cchurch/powershell_strict_mode ... Add PowerShell exception handling and turn on strict mode.	9 years ago
Chris Church	1d15e8f37a	Pass windows command as-is without splitting/rejoining parameters. ... * Fixes extra spaces added between parameters from https://github.com/ansible/ansible-modules-core/issues/1929 * Correctly decode PowerShell command encoded as UTF-16-LE so that it displays correctly in debug messages, fixes the other issue from https://github.com/ansible/ansible-modules-core/issues/1929 * Add test to verify that script parameters are passed as-is, so $true is interpreted as a boolean, fixes https://github.com/ansible/ansible/issues/10947	9 years ago
Chris Church	87db5119ea	Merge pull request #12049 from cchurch/win_group_tests ... Add integration tests for win_group module.	9 years ago
Chris Church	b44e02143a	Merge pull request #12050 from cchurch/test_win_msi_creates ... Add tests for creates parameter to win_msi module.	9 years ago
James Cammarata	3f8e12d1f7	Merge pull request #12359 from cchurch/fetch_no_fail_on_missing ... Fix fetch to not fail for missing file when fail_if_missing=False	9 years ago
Chris Church	6ab4cff7db	Enable winrm put_file to upload an empty file.	9 years ago
Chris Church	5c65ee7f0c	Add PowerShell exception handling and turn on strict mode. ... * Add exception handling when running PowerShell modules to provide exception message and stack trace. * Enable strict mode for all PowerShell modules and internal commands. * Update common PowerShell code to fix strict mode errors. * Fix an issue with Set-Attr where it would not replace an existing property if already set. * Add tests for exception handling using modified win_ping modules.	9 years ago
James Cammarata	d818a72375	Merge branch 'normalize_plugin_paths' of https://github.com/bcoca/ansible into bcoca-normalize_plugin_paths	9 years ago
Chris Church	15070e2af8	Merge pull request #11790 from brianlloyd/win_lineinfile ... Integration tests for windows implementation of lineinfile	9 years ago
Brian Coca	b6d6c2e4db	corrected all missing paths changes	9 years ago
Chris Church	904b8ca27b	Update win_msi tests to specify msi url and paths via variables.	9 years ago
Chris Church	0300294f6e	Add tests for creates parameter to win_msi module.	9 years ago
Chris Church	260b9f648c	Fix fetch action plugin to not fail if file is missing and fail_if_missing=False (the default). Add tests to test_fetch role to verify it works as expected.	9 years ago
James Cammarata	36b5858f51	Fix unit tests for change related to local_action	9 years ago
James Cammarata	49ca0eb797	Track local_action internally to prevent it from being overridden ... Fixes #12053	9 years ago
Abhijit Menon-Sen	88a20e7a20	Fix broken integration test with unicode hostnames ... 1. The test did "name: '{{hostnames}}.{{item}}'" inside a with_sequence loop, which didn't do what was intended: it expanded hostnames into an array, appended ".1", and set name to the resulting string. This can be converted to a simple with_items loop. 2. Some of the entries in hostnames contained punctuation characters, which I see no reason to support in inventory hostnames anyway. 3. Once the add_host failures are fixed, the playbook later fails when the unicode hostnames are interpolated into debug output in ssh.py due to an encoding error. This is only one of the many places that may fail when using unicode inventory hostnames; we work around it by providing an ansible_ssh_host setting.	9 years ago
Abhijit Menon-Sen	7479ab47e0	Be stricter about parsing hostname labels ... Labels must start with an alphanumeric character, may contain alphanumeric characters or hyphens, but must not end with a hyphen. We enforce those rules, but allow underscores wherever hyphens are accepted, and allow alphanumeric ranges anywhere. We relax the definition of "alphanumeric" to include Unicode characters even though such inventory hostnames cannot be used in practice unless an ansible_ssh_host is set for each of them. We still don't enforce length restrictions—the fact that we have to accept ranges makes it more complex, and it doesn't seem especially worthwhile.	9 years ago
Abhijit Menon-Sen	065bb52109	Be systematic about parsing and validating hostnames and addresses ... This adds a parse_address(pattern) utility function that returns (host,port), and uses it wherever where we accept IPv4 and IPv6 addresses and hostnames (or host patterns): the inventory parser the the add_host action plugin. It also introduces a more extensive set of unit tests that supersedes the old add_host unit tests (which didn't actually test add_host, but only the parsing function).	9 years ago
Marius Gedminas	f91b28ef23	Fix safe_eval() of set literals ... There was code to support set literals (on Python 2.7 and newer), but it was buggy: SAFE_NODES.union() doesn't modify SAFE_NODES in place, instead it returns a new set object that is then silently discarded. I added a unit test and fixed the code. I also changed the version check to use sys.version_tuple instead of a string comparison, for consistency with the subsequent Python 3.4 version check that I added in the previous commit.	9 years ago
Brian Coca	5809a2e81d	Merge pull request #12299 from resmo/feature/test_cs_user ... cloudstack: new integration test role test_cs_user	9 years ago
James Cammarata	444987cde6	Fix unit test for plugins after basedir/push_basedir removal	9 years ago
Rene Moser	f6382a160d	cloudstack: new integration test role test_cs_user	9 years ago
Toshio Kuratomi	e2c49b4ef4	Fix problem with "=" in the initial file path.	9 years ago
Toshio Kuratomi	3a50393cf7	Merge pull request #12269 from mgedmin/py3k ... Python 3: fix TypeError: unorderable types in test	9 years ago
Toshio Kuratomi	c1039de70c	Compatibility with six-1.3.0	9 years ago
James Cammarata	ac6f61ec7f	Properly handle group/host_var files with dots in them ... Fixes #12245	9 years ago
Marius Gedminas	c22f4ee697	Add a comment explaining why async = 1 in the test	9 years ago
Marius Gedminas	1a1c9203e2	Python 3: fix TypeError: unorderable types in test ... The full error was ====================================================================== ERROR: test_task_executor_execute (units.executor.test_task_executor.TestTaskExecutor) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/mg/src/ansible/test/units/executor/test_task_executor.py", line 252, in test_task_executor_execute mock_action.run.return_value = dict(ansible_facts=dict()) File "/home/mg/src/ansible/lib/ansible/executor/task_executor.py", line 317, in _execute if self._task.async > 0: TypeError: unorderable types: MagicMock() > int() ---------------------------------------------------------------------- Experiments show that Python 2 MagicMock() > 0 is true, so I'm setting the async property on mock_task to 1. (If I set it to 0, the test fails anyway.)	9 years ago
James Cammarata	ff9f5d7dc8	Starting to add additional unit tests for VariableManager ... Required some rewiring in inventory code to make sure we're using the DataLoader class for some data file operations, which makes mocking them much easier. Also identified two corner cases not currently handled by the code, related to inventory variable sources and which one "wins". Also noticed we weren't properly merging variables from multiple group/host_var file locations (inventory directory vs. playbook directory locations) so fixed as well.	9 years ago
Brian Coca	c17fbf2f12	simplify become testing and handling, we had drifted and were doulbe checking prompt, become and become_pass ... fixed tests to conform to new signature and now tests both with and w/o password now we are more explicit about self.prompt	9 years ago
Toshio Kuratomi	e218bf8da9	Do not escape backslashes when processing a template file. ... Fixes #12198 Fixes #12241	9 years ago
James Cammarata	b2cb3153f1	Fix unit tests for PlayIterator changes regarding fact gathering	9 years ago
Marius Gedminas	a32bf1ec18	Simplify FactCache.copy() ... Also fix the bug (missing from six import iteritems) I introduced in 823677b490.	9 years ago
Marius Gedminas	823677b490	Replace .iteritems() with six.iteritems() ... Replace .iteritems() with six.iteritems() everywhere except in module_utils (because there's no 'six' on the remote host). And except in lib/ansible/galaxy/data/metadata_template.j2, because I'm not sure six is available there.	9 years ago
Toshio Kuratomi	1b64702b9a	Fix templar unittests for change in preserve_trailing_newline parameter's default value	9 years ago